Mailing List Archive

Code review for the next little while
Hi everyone,

You all probably have noticed more people getting involved in code
review (and of course saw Brion's mail). This is partly in
anticipation of Tim being afk, and partly because we're long overdue
for distributing the load.

Here's who we have available for code review, and what they'll be focused on:
*  Brion - general review, see his mail from earlier this week
*  Chad - general review
*  Roan - ResourceLoader, API, CentralNotice, UploadWizard
*  Trevor - general review, mostly front-end
*  Tim - general review
* Mark - general review as available

I'll let each of them elaborate on their areas of focus.

I imagine we will want to give the code review pages on mediawiki.org
some love in the coming days and weeks, starting here:
http://www.mediawiki.org/wiki/Code_review
...and:
http://www.mediawiki.org/wiki/Requests_for_review

We have a number of related pages that potentially need to be merged,
reorganized, or deleted. I'll plug away at this, and I'll appreciate
any help on this (be bold; we'll revert if we don't like).

Rob

_______________________________________________
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: Code review for the next little while [ In reply to ]
Rob Lanphier wrote:
> I imagine we will want to give the code review pages on mediawiki.org
> some love in the coming days and weeks, starting here:
> http://www.mediawiki.org/wiki/Code_review
> ...and:
> http://www.mediawiki.org/wiki/Requests_for_review
>
> We have a number of related pages that potentially need to be merged,
> reorganized, or deleted. I'll plug away at this, and I'll appreciate
> any help on this (be bold; we'll revert if we don't like).

The only "major" reorganization that's needed right now on MediaWiki.org
that I see is a possible merge of
http://www.mediawiki.org/wiki/Requests_for_review and
http://www.mediawiki.org/wiki/Review_queue

"Review queue" is much older, but still contains a nasty amount of open
bugs. I guess the big question for me is, "is the goal of the current code
review blitz to simply catch up on the review backlog or is the goal of the
current code review blitz to fix some of these much older bugs?"

For example, "Requests for review" lists the ArticleEmblems extension, a
very new extension that now needs review. Meanwhile, there are requests like
https://bugzilla.wikimedia.org/show_bug.cgi?id=13163#c14 (listed on "Review
queue") that really need some love.

MZMcBride



_______________________________________________
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l