Mailing List Archive

[MediaWiki-commits] [Gerrit] (bug 457) use semantic headings for the navigation menu - change (mediawiki/core[master])
Siebrand has submitted this change and it was merged.

Change subject: (bug 457) use semantic headings for the navigation menu
......................................................................


(bug 457) use semantic headings for the navigation menu

This changes the current scheme of using (varies per skin) <h4>, <h5>
and/or <h6> tags (with nothing apart from the main <h1> above them in
the hierarchy) to <h2> above the entire navigation and <h3>s as portlet
headings.

The <h2> is hidden for normal browsers, but accessible for screen-readers
or text browsers. Its content comes from a new message called
"navigation-heading".

The changes were applied to Vector, Monobook, Modern and CologneBlue. The
change to Monobook also resulted in the heading appearing in Chick and
MySkin (I intentionally didn't implement hiding it in these skins, as they
are intended respectively as a super-lightweight one and a skim "template")
and in Simple (where I did hide it, but didn't bother with further CSS fixups).

Related changes and technical notes:
* Monobook had various styles for apparently all heading levels inside of a
.portlet, but only <h5>s (now <h3>s) could ever be generated.
The styles were also ancient, straight from 2004 (I git-blamed),
so I removed them, as they were almost certainly completely unused.
* Modern lacked font-size for .portlet h5 (now h3). It worked mostly okay
before (font-size of h5 is similar to size of regular text), but after
headings were changed to <h3>s, they became too large. I used
font-size:0.83em (copied from Opera's user-agent stylesheet), but this
might result in slight font-size changes on various browsers.
* Vector's variant menu is deeply broken. I changed the bonkers structure
to two <h3>s, one with id=mw-vector-current-variant. This is still
broken, but I don't really know how to do it properly.
* In Vector's CSS, the height for div.vectorMenu h3 a (previously h5 a)
had to be changed. I used 1.9em, the same as used for div.vectorTabs li a,
but this probably shouldn't be measured in ems anyway.
* CologneBlue and Vector lacked wrappers over the entire navigation;
I added <div id="mw-navigation"> to both of them. In CologneBlue this
also required moving <div id="toplinks"> to the bottom of the generated
HTML, which is a good idea anyway.

Change-Id: I9a2ebd503ec9dd901802a9b3b1f5137a85990373
---
M languages/messages/MessagesEn.php
M languages/messages/MessagesQqq.php
M maintenance/language/messages.inc
M skins/CologneBlue.php
M skins/Modern.php
M skins/MonoBook.php
M skins/Vector.php
M skins/cologneblue/screen.css
M skins/modern/main.css
M skins/monobook/main.css
M skins/simple/main.css
M skins/vector/screen.css
M skins/vector/vector.js
13 files changed, 100 insertions(+), 83 deletions(-)

Approvals:
Nikerabbit: Looks good to me, but someone else must approve
Siebrand: Looks good to me, approved
jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/30361
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9a2ebd503ec9dd901802a9b3b1f5137a85990373
Gerrit-PatchSet: 8
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Matmarex <matma.rex@gmail.com>
Gerrit-Reviewer: Aude <aude.wiki@gmail.com>
Gerrit-Reviewer: Daniel Friesen <daniel@nadir-seen-fire.com>
Gerrit-Reviewer: Danny B. <wikimedia.danny.b@email.cz>
Gerrit-Reviewer: Dereckson <dereckson@espace-win.org>
Gerrit-Reviewer: Hoo man <hoo@online.de>
Gerrit-Reviewer: Matmarex <matma.rex@gmail.com>
Gerrit-Reviewer: Nikerabbit <niklas.laxstrom@gmail.com>
Gerrit-Reviewer: Siebrand <siebrand@wikimedia.org>
Gerrit-Reviewer: Tpt <thomaspt@hotmail.fr>
Gerrit-Reviewer: jenkins-bot

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits