Mailing List Archive

[issue14809] Add HTTP status codes introduced by RFC 6585
New submission from EungJun Yi <semtlenori@gmail.com>:

This patch add HTTP status codes introduced by RFC 6585, to http.client and http.server.

428 Precondition Required
429 Too Many Requests
431 Request Header Fields Too Large
511 Network Authentication Required

----------
components: Library (Lib)
files: rfc6585.patch
keywords: patch
messages: 160651
nosy: EungJun.Yi
priority: normal
severity: normal
status: open
title: Add HTTP status codes introduced by RFC 6585
type: enhancement
versions: Python 3.3
Added file: http://bugs.python.org/file25582/rfc6585.patch

_______________________________________
Python tracker <report@bugs.python.org>
<http://bugs.python.org/issue14809>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com
[issue14809] Add HTTP status codes introduced by RFC 6585 [ In reply to ]
Hynek Schlawack <hs@ox.cx> added the comment:

I've cross-checked the patch against the RFC and it LGTM. Tests still pass as expected.

----------
nosy: +hynek
stage: -> patch review

_______________________________________
Python tracker <report@bugs.python.org>
<http://bugs.python.org/issue14809>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com
[issue14809] Add HTTP status codes introduced by RFC 6585 [ In reply to ]
Hynek Schlawack <hs@ox.cx> added the comment:

EungYun,

After further research I've found two issue which you should fix before it can be checked in:

- The multi-line strings are missing spaces at their line break (429 and 431).
- The error codes are documented at http://hg.python.org/cpython/file/26b8ec8a7800/Doc/library/http.client.rst#l180 , so you should add the new ones there.
- You should mention the new RFC at Lib/http/server.py#l576 .

Would you like to update your patch?

----------
stage: patch review -> needs patch

_______________________________________
Python tracker <report@bugs.python.org>
<http://bugs.python.org/issue14809>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com
[issue14809] Add HTTP status codes introduced by RFC 6585 [ In reply to ]
Changes by EungJun Yi <semtlenori@gmail.com>:


Added file: http://bugs.python.org/file25597/rfc6585.patch

_______________________________________
Python tracker <report@bugs.python.org>
<http://bugs.python.org/issue14809>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com
[issue14809] Add HTTP status codes introduced by RFC 6585 [ In reply to ]
EungJun Yi <semtlenori@gmail.com> added the comment:

Hynek, I have fixed them and upload the patch, rfc6585-rev2.patch.

----------

_______________________________________
Python tracker <report@bugs.python.org>
<http://bugs.python.org/issue14809>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com
[issue14809] Add HTTP status codes introduced by RFC 6585 [ In reply to ]
Changes by Senthil Kumaran <senthil@uthcode.com>:


----------
nosy: +orsenthil

_______________________________________
Python tracker <report@bugs.python.org>
<http://bugs.python.org/issue14809>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com
[issue14809] Add HTTP status codes introduced by RFC 6585 [ In reply to ]
Roundup Robot <devnull@psf.upfronthosting.co.za> added the comment:

New changeset 981aabe6ea2f by Hynek Schlawack in branch 'default':
#14809: Add HTTP status codes from RFC 6585 to http.server and http.client
http://hg.python.org/cpython/rev/981aabe6ea2f

----------
nosy: +python-dev

_______________________________________
Python tracker <report@bugs.python.org>
<http://bugs.python.org/issue14809>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com
[issue14809] Add HTTP status codes introduced by RFC 6585 [ In reply to ]
Hynek Schlawack <hs@ox.cx> added the comment:

Thank you for your contribution to Python, EungJun!

Just two small remarks:

- Please sign and submit the contributor form from http://www.python.org/psf/contrib/ . You'll get a nice star next to your name in return. :)
- I have fixed the flow of one of the lines. It's no big deal, but pep8 asks for a max line length of 79 characters.

----------
resolution: -> fixed
stage: needs patch -> committed/rejected
status: open -> closed

_______________________________________
Python tracker <report@bugs.python.org>
<http://bugs.python.org/issue14809>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com