Mailing List Archive

[issue14662] shutil.move doesn't handle ENOTSUP raised by chflags on OS X
Changes by Hynek Schlawack <hs@ox.cx>:


----------
assignee: -> hynek
title: shutil.move broken in 2.7.3 on OSX (chflags fails) -> shutil.move doesn't handle ENOTSUP raised by chflags on OS X

_______________________________________
Python tracker <report@bugs.python.org>
<http://bugs.python.org/issue14662>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com
[issue14662] shutil.move doesn't handle ENOTSUP raised by chflags on OS X [ In reply to ]
Antoine Pitrou <pitrou@free.fr> added the comment:

The test fails here (Linux), since there's no os.chflags:

======================================================================
ERROR: test_copystat_handles_harmless_chflags_errors (test.test_shutil.TestShutil)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/antoine/cpython/default/Lib/test/test_shutil.py", line 302, in test_copystat_handles_harmless_chflags_errors
old_chflags = os.chflags
AttributeError: 'module' object has no attribute 'chflags'

----------

_______________________________________
Python tracker <report@bugs.python.org>
<http://bugs.python.org/issue14662>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com
[issue14662] shutil.move doesn't handle ENOTSUP raised by chflags on OS X [ In reply to ]
Hynek Schlawack <hs@ox.cx> added the comment:

Fixed for 2.7

----------
Added file: http://bugs.python.org/file25434/expand-chflags-catch-2.7-v2.diff

_______________________________________
Python tracker <report@bugs.python.org>
<http://bugs.python.org/issue14662>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com
[issue14662] shutil.move doesn't handle ENOTSUP raised by chflags on OS X [ In reply to ]
Hynek Schlawack <hs@ox.cx> added the comment:

Fixed for 3.2.

----------
Added file: http://bugs.python.org/file25435/expand-chflags-catch-3.2-v2.diff

_______________________________________
Python tracker <report@bugs.python.org>
<http://bugs.python.org/issue14662>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com
[issue14662] shutil.move doesn't handle ENOTSUP raised by chflags on OS X [ In reply to ]
Hynek Schlawack <hs@ox.cx> added the comment:

And finally tip.

----------
Added file: http://bugs.python.org/file25436/expand-chflags-catch-tip-v2.diff

_______________________________________
Python tracker <report@bugs.python.org>
<http://bugs.python.org/issue14662>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com
[issue14662] shutil.move doesn't handle ENOTSUP raised by chflags on OS X [ In reply to ]
Antoine Pitrou <pitrou@free.fr> added the comment:

Looks ok to me, but I don't have a system with os.chflags to test on.

----------

_______________________________________
Python tracker <report@bugs.python.org>
<http://bugs.python.org/issue14662>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com
[issue14662] shutil.move doesn't handle ENOTSUP raised by chflags on OS X [ In reply to ]
Ned Deily <nad@acm.org> added the comment:

I will test and check it in next week if still open.

----------

_______________________________________
Python tracker <report@bugs.python.org>
<http://bugs.python.org/issue14662>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com
[issue14662] shutil.move doesn't handle ENOTSUP raised by chflags on OS X [ In reply to ]
Roundup Robot <devnull@psf.upfronthosting.co.za> added the comment:

New changeset e12efebc3ba6 by Ned Deily in branch '2.7':
Issue #14662: Prevent shutil failures on OS X when destination does not
http://hg.python.org/cpython/rev/e12efebc3ba6

New changeset ae141eebcf96 by Ned Deily in branch '3.2':
Issue #14662: Prevent shutil failures on OS X when destination does not
http://hg.python.org/cpython/rev/ae141eebcf96

New changeset 93599d5e0a23 by Ned Deily in branch 'default':
Issue #14662: Prevent shutil failures on OS X when destination does not
http://hg.python.org/cpython/rev/93599d5e0a23

----------
nosy: +python-dev

_______________________________________
Python tracker <report@bugs.python.org>
<http://bugs.python.org/issue14662>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com
[issue14662] shutil.move doesn't handle ENOTSUP raised by chflags on OS X [ In reply to ]
Ned Deily <nad@acm.org> added the comment:

Thanks for the patch! Tested with an NFS-mounted file system on OS X. Applied for 2.7.4, 3.2.4, and 3.3.0.

----------
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed

_______________________________________
Python tracker <report@bugs.python.org>
<http://bugs.python.org/issue14662>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/list-python-bugs%40lists.gossamer-threads.com