Mailing List Archive

Update README doc to include missing test cases
Dear OpenSSH developers,

I have created a pull request https://github.com/openssh/openssh-portable/pull/133 for submitting one patch.
With that patch, aim is to update the regress README document to include introduction of all the test cases present in regress.
Could this pull request be reviewed.

Thanks,
Jitendra

_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev
RE: Update README doc to include missing test cases [ In reply to ]
Hi Folks/Maintainers,

Could Pull request mentioned below in email be reviewed.
I am not sure, if asking for PR review is ok in this mailing list or there is another way for asking review of the patches. So, if I am missing some steps in getting patches reviewed, then please correct me.

Thanks,
Jitendra

-----Original Message-----
From: openssh-unix-dev [mailto:openssh-unix-dev-bounces+jitendra.sharma=intel.com@mindrot.org] On Behalf Of Sharma, Jitendra
Sent: Monday, June 24, 2019 11:42 AM
To: openssh-unix-dev@mindrot.org
Subject: Update README doc to include missing test cases

Dear OpenSSH developers,

I have created a pull request https://github.com/openssh/openssh-portable/pull/133 for submitting one patch.
With that patch, aim is to update the regress README document to include introduction of all the test cases present in regress.
Could this pull request be reviewed.

Thanks,
Jitendra

_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev

_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev
Re: Update README doc to include missing test cases [ In reply to ]
On 2019/06/26 14:33, Sharma, Jitendra wrote:
> Hi Folks/Maintainers,
>
> Could Pull request mentioned below in email be reviewed.
> I am not sure, if asking for PR review is ok in this mailing list or there is another way for asking review of the patches. So, if I am missing some steps in getting patches reviewed, then please correct me.

That was only 2 days ago, you are expecting a lot from a volunteer project
to be prodding people so soon...

_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev
Re: Update README doc to include missing test cases [ In reply to ]
On Wed, Jun 26, 2019 at 03:42:21PM +0100, Stuart Henderson wrote:
> On 2019/06/26 14:33, Sharma, Jitendra wrote:
> > Could Pull request mentioned below in email be reviewed.
> > I am not sure, if asking for PR review is ok in this mailing list or there is another way for asking review of the patches. So, if I am missing some steps in getting patches reviewed, then please correct me.
>
> That was only 2 days ago, you are expecting a lot from a volunteer project
> to be prodding people so soon...

I'd also suggest reading the project README before trying to send
patches to it, which says:

Please read https://www.openssh.com/report.html for bug reporting
instructions and note that we do not use Github for bug reporting or
patch/pull-request management.

--
Colin Watson [cjwatson@debian.org]
_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev
Re: Update README doc to include missing test cases [ In reply to ]
On Thu, 27 Jun 2019 at 01:52, Colin Watson <cjwatson@debian.org> wrote:
> On Wed, Jun 26, 2019 at 03:42:21PM +0100, Stuart Henderson wrote:
[...]
> > That was only 2 days ago, you are expecting a lot from a volunteer project
> > to be prodding people so soon...

That's true, there's only a couple of us and we only get to it intermittently.

> I'd also suggest reading the project README before trying to send
> patches to it, which says:

That's true, however since a lot of people don't read that and send
them anyway we do try to periodically process the ones that apply
directly to -portable (as this one does).

Anyway the patch has been applied, thanks.

--
Darren Tucker (dtucker at dtucker.net)
GPG key 11EAA6FA / A86E 3E07 5B19 5880 E860 37F4 9357 ECEF 11EA A6FA (new)
Good judgement comes with experience. Unfortunately, the experience
usually comes from bad judgement.
_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev@mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev