Mailing List Archive

Re: Ticket #10794: [PATCH] ffmpeg: Dont discard PES sections split across a TS packet
On Mon, 2012-07-02 at 22:53 +0000, MythTV wrote:
> #10794: [PATCH] ffmpeg: Dont discard PES sections split across a TS packet
> -----------------------------------+----------------------------
> Reporter: Lawrence Rust <lvr@…> | Owner: danielk
> Type: Patch - Bug Fix | Status: new
> Priority: minor | Milestone: 0.26
> Component: MythTV - DVB | Version: 0.25-fixes
> Severity: medium | Resolution:
> Keywords: MHEG 'red button' | Ticket locked: 0
> -----------------------------------+----------------------------
>
> Comment (by beirdo):
>
> Please note: from 0.26-pre onwards, this is mpegts-mythtv.c
>
> Please do not mess with mpegts.c in ffmpeg at all past the creation of our
> own version unless absolutely necessary.
>
> This is a perfect example of why you should be developing on master, not
> on old branches. Whether danielk applies this to fixes/0.25 is, of
> course, his decision to make :)

This patch is to fix a serious bug in existing branches (0.25 and
earlier) that is causing significant (loss of service) impact on users
of BBC interactive services on Freesat. I know that this doesn't
include many devs. It isn't a new feature.

It's fine saying that development should be done on master, but you need
to test those changes on live systems in order to gain confidence. We
have one live system that the family uses and it gets well tested and
that's where my patches get tested before submission.

Iff I could build a version of Myth post fixes/0.24 that would run
reliably for more than a few hours on my live or test system then I
would be interested in finding solutions for those branches too. Our
usage is a mix of recording, playback, livetv, dvd's and music and with
0.25 I'm seeing core dumps or lockups (requiring manual intervention)
every few hours whereas 0.24 (with my own patches) is almost
bulletproof.

--
Lawrence
_______________________________________________
mythtv-dev mailing list
mythtv-dev@mythtv.org
http://www.mythtv.org/mailman/listinfo/mythtv-dev
Re: Ticket #10794: [PATCH] ffmpeg: Dont discard PES sections split across a TS packet [ In reply to ]
On Tuesday 03 Jul 2012 09:31:46 Lawrence Rust wrote:
> with 0.25 I'm seeing core dumps or lockups (requiring manual intervention)
> every few hours

Which ticket numbers are these?
--
Stuart Morgan
_______________________________________________
mythtv-dev mailing list
mythtv-dev@mythtv.org
http://www.mythtv.org/mailman/listinfo/mythtv-dev
Re: Ticket #10794: [PATCH] ffmpeg: Dont discard PES sections split across a TS packet [ In reply to ]
On Tue, 2012-07-03 at 09:22 +0100, Stuart Morgan wrote:
> On Tuesday 03 Jul 2012 09:31:46 Lawrence Rust wrote:
> > with 0.25 I'm seeing core dumps or lockups (requiring manual intervention)
> > every few hours
>
> Which ticket numbers are these?

As you well know I have submitted hundreds of bug reports, patches and
new features which have largely been ignored. Consequently, I now only
submit those which I regard as crucial.

If you are interested I maintain a set of commented patches with my
mythbuild.sh script here:
http://www.softsystem.co.uk/download/mythtv/mythbuild-CURRENT.zip

Currently there are 96 patches for master, 98 for fixes/0.25 and 136 for
fixes/0.24.

In addition I have a TODO list of 18 items for fixes/0.25 that require
further investigation and fixing before I could consider upgrading my
live system. And that's just the tip of the iceberg - I haven't even
started on Win32 problems yet.

--
Lawrence
_______________________________________________
mythtv-dev mailing list
mythtv-dev@mythtv.org
http://www.mythtv.org/mailman/listinfo/mythtv-dev
Re: Ticket #10794: [PATCH] ffmpeg: Dont discard PES sections split across a TS packet [ In reply to ]
2012/7/3 Lawrence Rust <lvr@softsystem.co.uk>

>
> If you are interested I maintain a set of commented patches with my
> mythbuild.sh script here:
> http://www.softsystem.co.uk/download/mythtv/mythbuild-CURRENT.zip
>
>
Hi Lawrence,

thanks for posting those. I have successfully applied all of your master
patches to the MythBuntu source package and am building right now. I will
test it tonight at home (Germany), as I hope some of your patches will fix
some recurring problems I have here.

Do you update the above link regularly?

Cheers,

Elkin
Re: Ticket #10794: [PATCH] ffmpeg: Dont discard PES sections split across a TS packet [ In reply to ]
On Tue, 2012-07-03 at 13:12 +0200, Elkin Fricke wrote:
> 2012/7/3 Lawrence Rust <lvr@softsystem.co.uk>
>
> If you are interested I maintain a set of commented patches
> with my
> mythbuild.sh script here:
> http://www.softsystem.co.uk/download/mythtv/mythbuild-CURRENT.zip
>
>
> Hi Lawrence,
>
> thanks for posting those. I have successfully applied all of your
> master patches to the MythBuntu source package and am building right
> now. I will test it tonight at home (Germany), as I hope some of your
> patches will fix some recurring problems I have here.

Maybe, but most of the patches are duplicates of those to fixes/0.25. I
haven't worked much on git master specific problems to date. One step
at a time.

> Do you update the above link regularly?

At least once weekly and generally more to sync with the main repo.

Let me know how you get on. All comments and criticism welcome.

--
Lawrence
_______________________________________________
mythtv-dev mailing list
mythtv-dev@mythtv.org
http://www.mythtv.org/mailman/listinfo/mythtv-dev
Re: Ticket #10794: [PATCH] ffmpeg: Dont discard PES sections split across a TS packet [ In reply to ]
On Tuesday 03 Jul 2012 10:43:56 Lawrence Rust wrote:
> As you well know I have submitted hundreds of bug reports, patches and
> new features which have largely been ignored. Consequently, I now only
> submit those which I regard as crucial.

Nothing gets ignored, just dealt with as and when people have the time or
interest. That said, especially since you've invited comments and criticism
you might want to know that several devs do avoid giving feedback on your work
because fairly or not you've earned a reputation for taking criticism badly
and occasionally being belligerent.

Your work _IS_ usually appreciated, you've been nominated for commit privs
more than once and on each occasion the vote has gone against you because
people feel you are hard to work with. Refusing to open tickets and that sort
of thing do nothing to change people's minds.

> If you are interested I maintain a set of commented patches with my
> mythbuild.sh script here:
> http://www.softsystem.co.uk/download/mythtv/mythbuild-CURRENT.zip
>
> Currently there are 96 patches for master, 98 for fixes/0.25 and 136 for
> fixes/0.24.

Thank you, I'm looking through those now.

FWIW -
"[PATCH 84/96] libmythui: Prevent memory leak of MythUIType children" is
incorrect. QObject takes ownership of children and will delete them, those
objects do not leak.
--
Stuart Morgan
_______________________________________________
mythtv-dev mailing list
mythtv-dev@mythtv.org
http://www.mythtv.org/mailman/listinfo/mythtv-dev