Mailing List Archive

Re: [mythtv-commits] Ticket #8394: When watching a recording, up and down arrows will activate jump forward and jump back even though all key bindings are removed
On 04/29/2010 08:11 AM, aaron wrote:
> On Wed, Apr 28, 2010 at 19:55, MythTV wrote:
>
>> #8394: When watching a recording, up and down arrows will activate jump forward
>> and jump back even though all key bindings are removed
>> --------------------------------------------------+-------------------------
>> Reporter: Peter Semple<petersemple@…> | Owner: janne
>> Type: defect | Status: new
>> Priority: minor | Milestone: unknown
>> Component: MythTV - Video Playback | Version: 0.21
>> Severity: medium | Mlocked: 0
>> --------------------------------------------------+-------------------------
>> When watching a recording, the up and down arrow keys will activate the
>> jump forward and jump back functions. This will lead to the recording
>> jumping by the defined number of minutes. This happens even after all
>> keybindings are removed from the jump forward and jump back functions in
>> Edit Keys. It can be a particular pain with a keyboard or remote that
>> generates these signals due to interference.
>>
> This is "expected," isn't it?

Pretty sure it is, but I there's not enough information in the report
for me to say for sure, and I haven't had a chance to randomly change
things on my setup to try to figure out exactly has been changed.

> Frustrating enough that I've been
> patching it out of my codebase for many years. Ever since the day it
> was introduced (and I believe it was introduced before there were
> customizable keybindings)
>
> But those specific keys are hard-coded; I think the logic is, if
> you're watching a recording and you press "Channel Up" (or Down) it
> does a jump. If you're watching LiveTV it does a channel change.
> Something like that.
>
> I think Mike Dean had said he was planning on changing it, but no
> doubt it's far down on his priority list.
>

It would help immensely if someone could specify exactly which
keybindings you're talking about--and I don't mean keys. So, for
example, are you talking about CHANNELUP/DOWN (mapped to Up/Down arrows,
respectively) in TV Playback? Are you talking about JUMPFFWD/RWND
(mapped to PgDown/Up, respectively) in TV Playback? What all
keybindings are you unmapping? I'm assuming you're not unmapping Global
UP/DOWN (also mapped to Up/Down arrows). What action are you seeing
when you hit the key? Are you sure it's a jump (where you see, "Jump
Back/Ahead" in the OSD), and not a seek (where you see, "Skip
Back/Ahead" in the OSD)?

And, most importantly, what behavior are you guys actually looking for?
Are you saying you want MythTV to /ignore/ the keypress? Or are you
saying that you've mapped Up/Down to some other action and MythTV is
still doing a jump and not doing whatever other action you're trying to use?

Thanks,
Mike
_______________________________________________
mythtv-dev mailing list
mythtv-dev@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev
Re: Ticket #8394: When watching a recording, up and down arrows will activate jump forward and jump back even though all key bindings are removed [ In reply to ]
On Thu, Apr 29, 2010 at 01:52:07PM -0400, Michael T. Dean wrote:
> On 04/29/2010 08:11 AM, aaron wrote:
> >But those specific keys are hard-coded; I think the logic is, if
> >you're watching a recording and you press "Channel Up" (or Down) it
> >does a jump. If you're watching LiveTV it does a channel change.
> >Something like that.
> >
> >I think Mike Dean had said he was planning on changing it, but no
> >doubt it's far down on his priority list.
>
> It would help immensely if someone could specify exactly which
> keybindings you're talking about--and I don't mean keys. So, for
> example, are you talking about CHANNELUP/DOWN (mapped to Up/Down
> arrows, respectively) in TV Playback? Are you talking about
> JUMPFFWD/RWND (mapped to PgDown/Up, respectively) in TV Playback?
> What all keybindings are you unmapping? I'm assuming you're not
> unmapping Global UP/DOWN (also mapped to Up/Down arrows). What
> action are you seeing when you hit the key? Are you sure it's a
> jump (where you see, "Jump Back/Ahead" in the OSD), and not a seek
> (where you see, "Skip Back/Ahead" in the OSD)?

Mike, I'm pretty sure they're talking about the CHANNELUP/DOWN actions
as handled in TV::ActivePostQHandleAction(). If not watching live TV
nor a DVD, the code makes CHANNELUP/DOWN behave like JUMPFFWD/RWND.

> And, most importantly, what behavior are you guys actually looking
> for? Are you saying you want MythTV to /ignore/ the keypress? Or
> are you saying that you've mapped Up/Down to some other action and
> MythTV is still doing a jump and not doing whatever other action
> you're trying to use?

Personally, I want all of the hardcoded overloading of actions to go
away so I have more freedom to map keys to actions the way I want. As
it stands now, I have to modify the code (just like the OP) to do
that. For example, I too have commented out the DoSeek()s in the
TV::ActivePostQHandleAction() CHANNELUP/DOWN handling so I can use my
channel up/down keys for something else when not watching live TV or a
DVD. In all, I've currently got 8 separate changes in my local
tv_play.cpp to achieve my desired key handling. I'd like to get rid
of them all someday.

David
--
David Engel
david@istwok.net
_______________________________________________
mythtv-dev mailing list
mythtv-dev@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev
Re: [mythtv-commits] Ticket #8394: When watching a recording, up and down arrows will activate jump forward and jump back even though all key bindings are removed [ In reply to ]
On Thu, Apr 29, 2010 at 13:52, Michael T. Dean <mtdean@thirdcontact.com> wrote:
>
> And, most importantly, what behavior are you guys actually looking for?  Are
> you saying you want MythTV to /ignore/ the keypress?  Or are you saying that
> you've mapped Up/Down to some other action and MythTV is still doing a jump
> and not doing whatever other action you're trying to use?

When I'm watching a *recording*, I expect Up/Down (which I do have
mapped to CHANNELUP/DOWN) to do nothing. When I'm watching LiveTV I
expect the channel to change (well, Browse the channels, but same
difference). The LiveTV behaviour *is* working correctly... from what
I remember; it has been a while since I used it.

I have PageUp / PageDown mapped to the skip forward / back 10 minutes,
and those are separate buttons on my remote. I have no need for
Up/Down to do it too.

(Mike, please don't interpret any of the above as an argument; I'm
just trying to explain what I mean from what I recall. It has been a
while since I removed those blocks of code. You did help me to find
them a couple of months ago... I don't have easy access to search the
archives at the moment or I'd find a link to exactly what I'm talking
about)

aaron
_______________________________________________
mythtv-dev mailing list
mythtv-dev@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev
Re: [mythtv-commits] Ticket #8394: When watching a recording, up and down arrows will activate jump forward and jump back even though all key bindings are removed [ In reply to ]
On 04/29/2010 03:33 PM, aaron wrote:
> On Thu, Apr 29, 2010 at 13:52, Michael T. Dean wrote:
>
>> And, most importantly, what behavior are you guys actually looking for? Are
>> you saying you want MythTV to /ignore/ the keypress? Or are you saying that
>> you've mapped Up/Down to some other action and MythTV is still doing a jump
>> and not doing whatever other action you're trying to use?
>>
> When I'm watching a *recording*, I expect Up/Down (which I do have
> mapped to CHANNELUP/DOWN) to do nothing. When I'm watching LiveTV I
> expect the channel to change (well, Browse the channels, but same
> difference). The LiveTV behaviour *is* working correctly... from what
> I remember; it has been a while since I used it.
>
> I have PageUp / PageDown mapped to the skip forward / back 10 minutes,
> and those are separate buttons on my remote. I have no need for
> Up/Down to do it too.
>
> (Mike, please don't interpret any of the above as an argument; I'm
> just trying to explain what I mean from what I recall. It has been a
> while since I removed those blocks of code. You did help me to find
> them a couple of months ago... I don't have easy access to search the
> archives at the moment or I'd find a link to exactly what I'm talking
> about)
>

I'm not interpreting it as an argument--it was the exact information I
was requesting. :)

I just wanted to know for sure that everyone was on the same page before
I said the behavior is expected. Since both you and David have given
the same interpretation of the report, I'll assume that we are (and
Peter can let me know later if he had something else in mind).

Anyway, that means you are right on all counts--it's the currently
expected behavior, and it is something I'm planning to fix.
Unfortunately, there are a lot of things that need changing to fix it
properly, so it won't be a quick (and not necessarily a near-term) fix.

So, thanks for getting the discussion started on the ticket--I had the
ticket marked as a Later, but I'm glad to have it handled. :)

And thanks to David for explaining the specifics of the problem Peter is
seeing in http://www.gossamer-threads.com/lists/mythtv/dev/434205#434205 .

Thanks,
Mike
_______________________________________________
mythtv-dev mailing list
mythtv-dev@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev
Re: [mythtv-commits] Ticket #8394: When watching a recording, up and down arrows will activate jump forward and jump back even though all key bindings are removed [ In reply to ]
On Thu, Apr 29, 2010 at 16:06, Michael T. Dean <mtdean@thirdcontact.com> wrote:
>
> I'm not interpreting it as an argument--it was the exact information I was
> requesting.  :)

Excellent. It has just been a long and frustrating day for me, so when
I re-read my message before sending I worried it was getting
confrontational. Good to see I was wrong :)

>
> Anyway, that means you are right on all counts--it's the currently expected
> behavior, and it is something I'm planning to fix.

Good to see I was right

;-)


Once this gets fixed properly I can look forward to some ugly merge
conflicts, I expect... but that's my problem... Which I will probably
solve by dumping my changes entirely :)

aaron
_______________________________________________
mythtv-dev mailing list
mythtv-dev@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev
Re: [mythtv-commits] Ticket #8394: When watching a recording, up and down arrows will activate jump forward and jump back even though all key bindings are removed [ In reply to ]
On 04/29/2010 04:14 PM, aaron wrote:
> On Thu, Apr 29, 2010 at 16:06, Michael T. Dean wrote:
>
>> I'm not interpreting it as an argument--it was the exact information I was
>> requesting. :)
>>
> Excellent. It has just been a long and frustrating day for me, so when
> I re-read my message before sending I worried it was getting
> confrontational. Good to see I was wrong :)
>
>> Anyway, that means you are right on all counts--it's the currently expected
>> behavior, and it is something I'm planning to fix.
>>
> Good to see I was right
>
> ;-)
>
>
> Once this gets fixed properly I can look forward to some ugly merge
> conflicts, I expect... but that's my problem... Which I will probably
> solve by dumping my changes entirely :)
>

If you can, that means I'll have succeeded in the refactoring. :)

Mike
_______________________________________________
mythtv-dev mailing list
mythtv-dev@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev