Mailing List Archive

[PATCH] (3 patches) lcd, cdripper and musictree
Hi...

I've got three patches for various things, all patches are done vs.
cvs from 4/20.

lcd.patch (at http://eskil.org/mythtv/patches/lcd.patch because of size):
- works with both 0.4.5 (latest released LCDd) and CVS current (yes, I
know another patch for this was just posted, but this patch has much
more).
- fixes to work with 8 line LCDs (previous didn't work with more than
5).
- more levels to the LCD_DEBUG define.
- optional toggle to enabled LCD heartbeat in appearances.
- optional toggle to make music show either "Aritist - Title" or "Artist
[Album] Title".
- fixes to replace " with ' in strings, since having " inside strings
sent to LCDd will screw up.
- added more things to the music screen (fixes bug 98)
- it takes artist/album and title
- it shows time played/total if more than 2 lines on LCD
- showsprogress bar of while playing
- fix in mythdialogs to ensure that generic progress bars look proper on
LCD.
- fix to uitypes (UIManagedTree) to display both "<<" and ">>" if the
tree is non-root/non-leaf.
- reset LCD object when appearances change, no need to restart frontend
when chaning LCD settings.
- changed mythmusic to use the music screen on the LCD, and pass over
artist/album/title and show music progress.

musicsplit.patch (attached):
adds another keyword (splitartist1) for the music tree. Where
splitartist groups artists by four letters at a time, splitartist1
groups by one. Makes it much easier to navigate around large music
collections.

cdrip.patch (attached):
- place focus on the "Import cd" button, since it's most likely to be
the option wanted (and makes it a bit easier when using a remote
control).
- overall progress uses total sectors read rather than pr. track, gives
a much smoother progress bar.
- display progress on the LCD via the generic screen.

Much appreciated,
eskil
---
Re: [PATCH] (3 patches) lcd, cdripper and musictree [ In reply to ]
On Friday 22 April 2005 12:26 am, Eskil Heyn Olsen wrote:
> Hi...
>
> I've got three patches for various things, all patches are done vs.
> cvs from 4/20.
>
> lcd.patch (at http://eskil.org/mythtv/patches/lcd.patch because of size):

I've applied this, minus:
> - fix in mythdialogs to ensure that generic progress bars look proper on
> LCD.

The / 1000's there to keep it from updating the UI too often.

> musicsplit.patch (attached):
> cdrip.patch (attached):

These went in to CVS unchanged.

Isaac
_______________________________________________
mythtv-dev mailing list
mythtv-dev@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev
Re: [PATCH] (3 patches) lcd, cdripper and musictree [ In reply to ]
On Tue, 2005-05-03 at 03:17 -0400, Isaac Richards wrote:

> I've applied this, minus:
> > - fix in mythdialogs to ensure that generic progress bars look proper on
> > LCD.
>
> The / 1000's there to keep it from updating the UI too often.

Do you mean the LCD or the UI ? The "curprogress % steps" check is only
there for the QT, so it'll update normally, where as the LCD will update
every time it's called (and the LCD is probably much slower than QT).

The problem is, that the rounding makes the progress bar incorrect.

Ie.

MythProgressDialog p ("foo", 1500); // int steps = 1500/1000 = 1.
p->setProgress (1100); // float fProgress = 1100/(1*1000.0) = 110%
instead of 73%.

so the LCD progress bar finishes too early depending on the total steps.

How about if I change the patch so the LCD also only gets updated if
"curprogress % steps == 0", but then keep the tsteps so the LCD updates
correctly ?

And thanks for applying the patches.

eskil
---
Re: [PATCH] (3 patches) lcd, cdripper and musictree [ In reply to ]
On Tuesday 03 May 2005 01:55 pm, Eskil Heyn Olsen wrote:
> How about if I change the patch so the LCD also only gets updated if
> "curprogress % steps == 0", but then keep the tsteps so the LCD updates
> correctly ?

Sure.

Isaac
_______________________________________________
mythtv-dev mailing list
mythtv-dev@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev