Mailing List Archive

[MythTV/mythtv] c4af2b: tidy: Fix memory leak warnings in SignalMonitor::I...
Branch: refs/heads/master
Home: https://github.com/MythTV/mythtv
Commit: c4af2b097d3e65b9ada35254e363143f756f00dc
https://github.com/MythTV/mythtv/commit/c4af2b097d3e65b9ada35254e363143f756f00dc
Author: David Hampton <mythtv@love2code.net>
Date: 2019-03-28 (Thu, 28 Mar 2019)

Changed paths:
M mythtv/libs/libmythtv/recorders/signalmonitor.cpp

Log Message:
-----------
tidy: Fix memory leak warnings in SignalMonitor::Init.

The clang-tidy "new/delete leak" checker pointed out several possible
object leaks in the SignalMonitor Init code. There is no leak here.
This is an artifact of the way the code is written, because all of the
conditionally compiled tests have to assume that they might be the
first test. Starting with a fake case allows all of the conditionally
compiled cases to start with an 'else if' test, which eliminates the
false positive warnings about leaked objects.


Commit: d5a04997c2d80b4ca2c90ace94f995037b08c425
https://github.com/MythTV/mythtv/commit/d5a04997c2d80b4ca2c90ace94f995037b08c425
Author: David Hampton <mythtv@love2code.net>
Date: 2019-03-28 (Thu, 28 Mar 2019)

Changed paths:
M mythtv/programs/mythcommflag/main.cpp

Log Message:
-----------
tidy: Fix memory leak warnings in mythcommflag.

The clang-tidy "new/delete leak" checker pointed out that the
print_comm_flag_output might be attempting to delete the global
variable 'cout'. The complaint occurs because clang-tidy doesn't seem
to remember previous branch choices. It takes the false branch for
the first of the two 'if (output_filename != "-")' clauses and the
true branch for the other, even thought none of the intervening code
resets the variable. Using a slightly different second test achieves
the same ends, without confusing the clang-tidy checker.


Commit: 4e674935ce2040e4b2c11b6ac75dbc4de22d70d2
https://github.com/MythTV/mythtv/commit/4e674935ce2040e4b2c11b6ac75dbc4de22d70d2
Author: David Hampton <mythtv@love2code.net>
Date: 2019-03-28 (Thu, 28 Mar 2019)

Changed paths:
M mythtv/programs/mythfrontend/exitprompt.cpp
M mythtv/programs/mythtv-setup/exitprompt.cpp
M mythtv/programs/mythtv-setup/startprompt.cpp

Log Message:
-----------
tidy: Fix warnings about using freed memory in handleExit.

The clang-tidy "new/delete leak" checker pointed out that this
function can use the 'dlg' variable after it has been freed. The
QApplication::quit function does return, unlike the C library
function, so add a 'return' statement after the call to quit.

This function appears in multiple applications.

Add to 24e9442c45 ExitPrompter::handleExit


Commit: ed44a0e7e8ab5154bc38534295c56c0ddc7c3eed
https://github.com/MythTV/mythtv/commit/ed44a0e7e8ab5154bc38534295c56c0ddc7c3eed
Author: David Hampton <mythtv@love2code.net>
Date: 2019-03-28 (Thu, 28 Mar 2019)

Changed paths:
M mythtv/programs/mythfrontend/statusbox.cpp

Log Message:
-----------
tidy: Fix duplicate variable assignment in StatusBox::keyPressEvent.

The clang-tidy "dead stores" checker pointed out a duplicate variable
assignment in this function. Remove the duplicate assignment.


Commit: d987ad529b7c645c0c586b2dde1b444524419cb1
https://github.com/MythTV/mythtv/commit/d987ad529b7c645c0c586b2dde1b444524419cb1
Author: David Hampton <mythtv@love2code.net>
Date: 2019-03-28 (Thu, 28 Mar 2019)

Changed paths:
M mythtv/programs/mythlcdserver/main.cpp

Log Message:
-----------
tidy: Fix memory leak in lcdserver main function.

The clang-tidy "new/delete leak" checker pointed out that the
lcdserver main function creates an LCDServer object but never deletes
it. This is a trivial problem, as the lcdserver is exiting when it
fails to free the memory. The memory will be freed when the process
terminates. Add a proper delete call for this object so that code
analyzers don't complain.


Commit: 3fa23834a2e8e4be8f711b236afc35c79bb57418
https://github.com/MythTV/mythtv/commit/3fa23834a2e8e4be8f711b236afc35c79bb57418
Author: David Hampton <mythtv@love2code.net>
Date: 2019-03-28 (Thu, 28 Mar 2019)

Changed paths:
M mythtv/programs/mythtranscode/main.cpp

Log Message:
-----------
tidy: Fix memory leak in mythtranscode main function.

The clang-tidy "new/delete leak" checker pointed out that the
mythtranscode main function creates a ProgramInfo object, but in an
error condition fails to delete it. This is a trivial problem, as
mythtransode is exiting when it fails to free the memory. The memory
will be freed when the process terminates. Add a proper delete call
for this object so that code analyzers don't complain.


Commit: 69b89f8e717b88a2811893d485cde15d24a5af1f
https://github.com/MythTV/mythtv/commit/69b89f8e717b88a2811893d485cde15d24a5af1f
Author: David Hampton <mythtv@love2code.net>
Date: 2019-03-28 (Thu, 28 Mar 2019)

Changed paths:
M mythtv/programs/mythlcdserver/lcdprocclient.cpp

Log Message:
-----------
tidy: Remove unused assignments in lcdprocclient.cpp.

The clang-tidy "dead stores" checker pointed out two places where
variables are assigned, but the assigned value is never used. In the
first, the variable can be completely removed. In the second, the
dead assignment can be removed and the scope of the variable reduced.


Commit: 7b8c02b779abc8584d5efe9fb14f339166d38d9d
https://github.com/MythTV/mythtv/commit/7b8c02b779abc8584d5efe9fb14f339166d38d9d
Author: David Hampton <mythtv@love2code.net>
Date: 2019-03-28 (Thu, 28 Mar 2019)

Changed paths:
M mythtv/programs/mythutil/mpegutils.cpp

Log Message:
-----------
tidy: Remove unused assignments in mpegutils.cpp.

The clang-tidy "dead stores" checker pointed out two places where a
variable is assigned, but the assigned value is never used. Remove
these two dead assignments.


Commit: 05f0d811d01d0ec40db03d519c5daead7d54beee
https://github.com/MythTV/mythtv/commit/05f0d811d01d0ec40db03d519c5daead7d54beee
Author: David Hampton <mythtv@love2code.net>
Date: 2019-03-28 (Thu, 28 Mar 2019)

Changed paths:
M mythtv/programs/mythshutdown/main.cpp

Log Message:
-----------
tidy: Remove unused assignments in mythshutdown main function.

The clang-tidy "dead stores" checker pointed out one places where a
variable is assigned, but the assigned value is never used. Remove
these the dead assignments.


Commit: a33871de0aecff60046152fa4d28ca97f27183c0
https://github.com/MythTV/mythtv/commit/a33871de0aecff60046152fa4d28ca97f27183c0
Author: David Hampton <mythtv@love2code.net>
Date: 2019-03-28 (Thu, 28 Mar 2019)

Changed paths:
M mythtv/programs/mythbackend/mainserver.cpp

Log Message:
-----------
tidy: Remove unused assignments in MainServer::DeleteFile.

The clang-tidy "dead stores" checker pointed out two places where the
result of a system call is assigned to a variable, but the variable is
never used. Remove these the dead assignments. If there's an error,
the function will print the content of errno before it exits.


Commit: feb280a6c7728d70def21327ab978ba1cb4106c0
https://github.com/MythTV/mythtv/commit/feb280a6c7728d70def21327ab978ba1cb4106c0
Author: David Hampton <mythtv@love2code.net>
Date: 2019-03-29 (Fri, 29 Mar 2019)

Changed paths:
M mythplugins/mythmusic/mythmusic/playlisteditorview.cpp
M mythtv/libs/libmythbase/remotefile.cpp
M mythtv/programs/mythbackend/main_helpers.cpp
M mythtv/programs/mythfrontend/customedit.cpp
M mythtv/programs/mythfrontend/editvideometadata.cpp
M mythtv/programs/mythfrontend/videofileassoc.cpp

Log Message:
-----------
tidy: Annotate code that there is no memory leak.

The clang-tidy "new/delete leak" checker found a couple of places in
mythfrontend where it believes there is an object leak. These do not
appear to be actual leaks as the object constructor adds itself to a
list maintained by its parent. Annotate the code with this
information, so that next time leaks are being this information will
be easily available.


Commit: a36850c970d26eedc6453d1ad9efeb70fcad013b
https://github.com/MythTV/mythtv/commit/a36850c970d26eedc6453d1ad9efeb70fcad013b
Author: David Hampton <mythtv@love2code.net>
Date: 2019-03-29 (Fri, 29 Mar 2019)

Changed paths:
M mythtv/programs/mythbackend/mediaserver.cpp
M mythtv/programs/mythbackend/mediaserver.h

Log Message:
-----------
tidy: Fix memory leak in mythbacked mediaserver code.

The clang-tidy "new/delete leak" checker pointed out that the
WebSocketServer created in the mediaserver initialization didn't have
a corresponding delete. This is a trivial problem, as the server
should last until the backend shuts down. Add code to remember the
pointer to the web socket server on the MediaServer object, and then
delete it from the MediaServer destructor.


Commit: 528c0c967034db44e563b246d64a79fb28e1eba1
https://github.com/MythTV/mythtv/commit/528c0c967034db44e563b246d64a79fb28e1eba1
Author: David Hampton <mythtv@love2code.net>
Date: 2019-04-01 (Mon, 01 Apr 2019)

Changed paths:
M mythtv/programs/mythbackend/backendcontext.cpp
M mythtv/programs/mythbackend/backendcontext.h
M mythtv/programs/mythbackend/main_helpers.cpp

Log Message:
-----------
tidy: Fix memory leak in mythbacked helpers code.

The clang-tidy "new/delete leak" checker pointed out that the system
event handler created in the run_backend function didn't have a
corresponding delete. This is a trivial problem, as the object should
last until the backend shuts down. Create a global pointer to this
object, like all the other objects in this function, and delete it
when the programs is being torn down.


Commit: 91f293375bb59ff2b2a3a3d299fa58de752a6166
https://github.com/MythTV/mythtv/commit/91f293375bb59ff2b2a3a3d299fa58de752a6166
Author: David Hampton <mythtv@love2code.net>
Date: 2019-04-01 (Mon, 01 Apr 2019)

Changed paths:
M mythtv/libs/libmythtv/test/test_mpegtables/test_mpegtables.cpp

Log Message:
-----------
tidy: Fix a bunch of null dereference warnings in test_mpegtables.

The clang-tidy "null dereference" checker pointed out a bunch of
potential null dereferences in the test_mpegtables code. The
dereferences are not obvious, as they occur inside of functions from
mpegdescriptors.h that have been inlined into the test code. Adding
simple tests for descriptor validity, and exiting when they aren't
valid, eliminates all these warnings.


Commit: 6d79376e6c46d4c95955e79f10aec34e7d90ec38
https://github.com/MythTV/mythtv/commit/6d79376e6c46d4c95955e79f10aec34e7d90ec38
Author: David Hampton <mythtv@love2code.net>
Date: 2019-04-01 (Mon, 01 Apr 2019)

Changed paths:
M mythtv/libs/libmythtv/privatedecoder_crystalhd.cpp

Log Message:
-----------
tidy: Check initialization results in PrivateDecoderCrystalHD::Init.

The clang-tidy "dead stores" checker pointed out three places where
initialization function return codes are stored, but then never
checked. Add checking of these return values, which should make the
existing warning messages get printed upon failure.


Commit: 209873913d7b5f169209f30fa5b93c8d03e4d968
https://github.com/MythTV/mythtv/commit/209873913d7b5f169209f30fa5b93c8d03e4d968
Author: David Hampton <mythtv@love2code.net>
Date: 2019-04-01 (Mon, 01 Apr 2019)

Changed paths:
M mythtv/libs/libmythtv/teletextscreen.cpp

Log Message:
-----------
tidy: Fix stored variable never read warning in TeletextScreen::DrawLine. (again)

The clang-tidy "dead stores" checker pointed out that a variable in
this function is set, but that value is never used. Drop the
variables entirely as they don't do anything useful.


Commit: a418d340da30b1933d944a6de14b859561b2e24f
https://github.com/MythTV/mythtv/commit/a418d340da30b1933d944a6de14b859561b2e24f
Author: David Hampton <mythtv@love2code.net>
Date: 2019-04-01 (Mon, 01 Apr 2019)

Changed paths:
M mythtv/libs/libmythtv/avformatdecoder.cpp
M mythtv/libs/libmythtv/channelscan/channelscan_sm.cpp
M mythtv/libs/libmythtv/eithelper.cpp
M mythtv/libs/libmythtv/mpeg/dvbdescriptors.h
M mythtv/libs/libmythtv/mpeg/dvbtables.cpp
M mythtv/libs/libmythtv/mpeg/mpegdescriptors.cpp
M mythtv/libs/libmythtv/mpeg/mpegdescriptors.h
M mythtv/libs/libmythtv/mpeg/mpegtables.cpp
M mythtv/libs/libmythtv/mpeg/scanstreamdata.cpp
M mythtv/libs/libmythtv/mpeg/splicedescriptors.cpp
M mythtv/libs/libmythtv/mpeg/splicedescriptors.h
M mythtv/libs/libmythtv/recorders/dvbcam.cpp

Log Message:
-----------
tidy: Fix a bunch of null dereference warnings related to MPEG descriptors.

The clang-tidy "null dereference" checker pointed out a bunch of
potential null dereferences in the mpeg descriptor/tables code. These
are the result of the code creating various objects, and then blindly
dereferencing the _data pointer in those objects (mostly via member
functions). The problem with those dereferences is that the object
constructor clears the _data pointer if the information passed into
the constructor was too short. Add a number of tests to check the
validity of the _data pointer before dereferencing it.

This change also tightens up the code to select Australian and Greek
category names from the EIT information, replacing switch statements
with table lookups.


Commit: d1dbaa0df6e8e1a6328b6b84a6a72e69edc642e9
https://github.com/MythTV/mythtv/commit/d1dbaa0df6e8e1a6328b6b84a6a72e69edc642e9
Author: David Hampton <mythtv@love2code.net>
Date: 2019-04-01 (Mon, 01 Apr 2019)

Changed paths:
M mythtv/libs/libmythtv/mythframe.cpp

Log Message:
-----------
tidy: Clean up SSE feature present checks.

The clang-tidy "implicit boolean conversion" check pointed out a
number of places in this code where booleans are converted to/from
integers. Clean up the code to eliminate these implicit conversions.

https://clang.llvm.org/extra/clang-tidy/checks/readability-implicit-bool-conversion.html


Commit: f7d42661328c768344c2f2e013dda12cea783c23
https://github.com/MythTV/mythtv/commit/f7d42661328c768344c2f2e013dda12cea783c23
Author: David Hampton <mythtv@love2code.net>
Date: 2019-04-01 (Mon, 01 Apr 2019)

Changed paths:
M mythtv/libs/libmythtv/mythframe.cpp
M mythtv/libs/libmythtv/mythframe.h

Log Message:
-----------
tidy: Clean up SSE hw vs sw copying speed detection.

The clang-tidy "implicit boolean conversion" check pointed out a
number of places in this code where booleans are converted to/from
integers. Clean up the code to eliminate these implicit conversions.

https://clang.llvm.org/extra/clang-tidy/checks/readability-implicit-bool-conversion.html


Commit: 3db5a9ee89ae75e715eaa99e1f0691b3f1abddac
https://github.com/MythTV/mythtv/commit/3db5a9ee89ae75e715eaa99e1f0691b3f1abddac
Author: David Hampton <mythtv@love2code.net>
Date: 2019-04-01 (Mon, 01 Apr 2019)

Changed paths:
M mythplugins/mytharchive/mytharchivehelper/main.cpp
M mythplugins/mythgallery/mythgallery/glsingleview.cpp
M mythplugins/mythgallery/mythgallery/imageview.cpp
M mythplugins/mythgallery/mythgallery/singleview.cpp
M mythplugins/mythmusic/mythmusic/flacencoder.cpp
M mythplugins/mythmusic/mythmusic/lameencoder.cpp
M mythplugins/mythmusic/mythmusic/vorbisencoder.cpp
M mythplugins/mythnetvision/mythfillnetvision/main.cpp

Log Message:
-----------
tidy: Clean up constructor/destructor calls to virtual functions. (plugins)

The clang-tidy "C++ virtual call" check pointed out many places where
constructors and destructors call virtual functions. Constructors and
destructors may call a function from their own class or any base
classes, but they may not call a function from a derived class. These
virtual calls should be fully specified with the class name to make
their meaning unambiguous.


Commit: d14ecd743e0959b24d98f1a3222ef21b669c4f1d
https://github.com/MythTV/mythtv/commit/d14ecd743e0959b24d98f1a3222ef21b669c4f1d
Author: David Hampton <mythtv@love2code.net>
Date: 2019-04-01 (Mon, 01 Apr 2019)

Changed paths:
M mythtv/libs/libmyth/mediamonitor-unix.cpp
M mythtv/libs/libmyth/programinfo.cpp
M mythtv/libs/libmyth/programinfo.h
M mythtv/libs/libmythbase/filesysteminfo.cpp
M mythtv/libs/libmythbase/housekeeper.cpp
M mythtv/libs/libmythbase/loggingserver.cpp
M mythtv/libs/libmythbase/mythcommandlineparser.cpp
M mythtv/libs/libmythbase/mythsignalingtimer.cpp
M mythtv/libs/libmythbase/mythsystem.cpp
M mythtv/libs/libmythmetadata/imagemetadata.cpp
M mythtv/libs/libmythtv/Bluray/bdringbuffer.cpp
M mythtv/libs/libmythtv/HLS/httplivestreambuffer.cpp
M mythtv/libs/libmythtv/avformatdecoder.cpp
M mythtv/libs/libmythtv/channelscan/channelscanner.cpp
M mythtv/libs/libmythtv/diseqc.cpp
M mythtv/libs/libmythtv/diseqc.h
M mythtv/libs/libmythtv/dvdstream.cpp
M mythtv/libs/libmythtv/fileringbuffer.cpp
M mythtv/libs/libmythtv/icringbuffer.cpp
M mythtv/libs/libmythtv/mpeg/mpegstreamdata.cpp
M mythtv/libs/libmythtv/mpeg/pespacket.h
M mythtv/libs/libmythtv/mpeg/premieredescriptors.h
M mythtv/libs/libmythtv/mpeg/splicedescriptors.h
M mythtv/libs/libmythtv/privatedecoder_crystalhd.cpp
M mythtv/libs/libmythtv/recorders/ExternalChannel.cpp
M mythtv/libs/libmythtv/recorders/ExternalChannel.h
M mythtv/libs/libmythtv/recorders/ExternalSignalMonitor.cpp
M mythtv/libs/libmythtv/recorders/asichannel.cpp
M mythtv/libs/libmythtv/recorders/asisignalmonitor.cpp
M mythtv/libs/libmythtv/recorders/cetonchannel.cpp
M mythtv/libs/libmythtv/recorders/cetonsignalmonitor.cpp
M mythtv/libs/libmythtv/recorders/dtvrecorder.cpp
M mythtv/libs/libmythtv/recorders/dtvsignalmonitor.cpp
M mythtv/libs/libmythtv/recorders/dvbchannel.cpp
M mythtv/libs/libmythtv/recorders/dvbsignalmonitor.cpp
M mythtv/libs/libmythtv/recorders/firewirechannel.cpp
M mythtv/libs/libmythtv/recorders/firewiresignalmonitor.cpp
M mythtv/libs/libmythtv/recorders/hdhrchannel.cpp
M mythtv/libs/libmythtv/recorders/hdhrsignalmonitor.cpp
M mythtv/libs/libmythtv/recorders/iptvchannel.cpp
M mythtv/libs/libmythtv/recorders/iptvsignalmonitor.cpp
M mythtv/libs/libmythtv/recorders/linuxfirewiredevice.cpp
M mythtv/libs/libmythtv/recorders/recorderbase.cpp
M mythtv/libs/libmythtv/recorders/signalmonitor.cpp
M mythtv/libs/libmythtv/recorders/v4l2encsignalmonitor.cpp
M mythtv/libs/libmythtv/recorders/v4lchannel.cpp
M mythtv/libs/libmythtv/recordinginfo.h
M mythtv/libs/libmythtv/streamingringbuffer.cpp
M mythtv/libs/libmythtv/videoout_nullvdpau.cpp
M mythtv/libs/libmythtv/videoout_opengl.cpp
M mythtv/libs/libmythtv/videoout_openglvaapi.cpp
M mythtv/libs/libmythtv/videoout_vdpau.cpp
M mythtv/libs/libmythtv/videooutbase.cpp
M mythtv/libs/libmythtv/videosource.cpp
M mythtv/libs/libmythui/mythpainter_ogl.cpp
M mythtv/libs/libmythui/mythpainter_vdpau.cpp
M mythtv/libs/libmythui/mythrender_opengl.cpp
M mythtv/libs/libmythui/mythrender_opengl1.cpp
M mythtv/libs/libmythui/mythrender_opengl2.cpp
M mythtv/libs/libmythui/mythscreenstack.cpp
M mythtv/libs/libmythui/mythuitext.cpp
M mythtv/libs/libmythui/screensaver-x11.cpp
M mythtv/libs/libmythupnp/configuration.cpp
M mythtv/libs/libmythupnp/msocketdevice.cpp
M mythtv/libs/libmythupnp/msocketdevice.h

Log Message:
-----------
tidy: Clean up constructor/destructor calls to virtual functions. (libs)

The clang-tidy "C++ virtual call" check pointed out many places where
constructors and destructors call virtual functions. Constructors and
destructors may call a function from their own class or any base
classes, but they may not call a function from a derived class. These
virtual calls should be fully specified with the class name to make
their meaning unambiguous.


Commit: 7bef26593bc2d8cd9173e31620f6303595d1560f
https://github.com/MythTV/mythtv/commit/7bef26593bc2d8cd9173e31620f6303595d1560f
Author: David Hampton <mythtv@love2code.net>
Date: 2019-04-01 (Mon, 01 Apr 2019)

Changed paths:
M mythtv/programs/mythavtest/commandlineparser.cpp
M mythtv/programs/mythbackend/commandlineparser.cpp
M mythtv/programs/mythccextractor/commandlineparser.cpp
M mythtv/programs/mythcommflag/commandlineparser.cpp
M mythtv/programs/mythexternrecorder/commandlineparser.cpp
M mythtv/programs/mythfilerecorder/commandlineparser.cpp
M mythtv/programs/mythfilldatabase/commandlineparser.cpp
M mythtv/programs/mythfrontend/commandlineparser.cpp
M mythtv/programs/mythfrontend/galleryslide.h
M mythtv/programs/mythfrontend/guidegrid.cpp
M mythtv/programs/mythjobqueue/commandlineparser.cpp
M mythtv/programs/mythlcdserver/commandlineparser.cpp
M mythtv/programs/mythmediaserver/commandlineparser.cpp
M mythtv/programs/mythmetadatalookup/commandlineparser.cpp
M mythtv/programs/mythpreviewgen/commandlineparser.cpp
M mythtv/programs/mythscreenwizard/commandlineparser.cpp
M mythtv/programs/mythshutdown/commandlineparser.cpp
M mythtv/programs/mythtranscode/audioreencodebuffer.cpp
M mythtv/programs/mythtranscode/commandlineparser.cpp
M mythtv/programs/mythtv-setup/commandlineparser.cpp
M mythtv/programs/mythutil/commandlineparser.cpp
M mythtv/programs/mythwelcome/commandlineparser.cpp

Log Message:
-----------
tidy: Clean up constructor/destructor calls to virtual functions. (programs)

The clang-tidy "C++ virtual call" check pointed out many places where
constructors and destructors call virtual functions. Constructors and
destructors may call a function from their own class or any base
classes, but they may not call a function from a derived class. These
virtual calls should be fully specified with the class name to make
their meaning unambiguous.


Commit: 22d9406d38a6401938f31c961633085392cd5320
https://github.com/MythTV/mythtv/commit/22d9406d38a6401938f31c961633085392cd5320
Author: David Hampton <mythtv@love2code.net>
Date: 2019-04-01 (Mon, 01 Apr 2019)

Changed paths:
M mythtv/libs/libmythtv/mpeg/scanstreamdata.cpp
M mythtv/libs/libmythtv/mpeg/scanstreamdata.h

Log Message:
-----------
Convert variable from int to boolean in scanstreamdata.h.

Also prefix the name with 'm_'.


Commit: 56b22da302d24271e8dbfe99750b857295002a4a
https://github.com/MythTV/mythtv/commit/56b22da302d24271e8dbfe99750b857295002a4a
Author: David Hampton <mythtv@love2code.net>
Date: 2019-04-01 (Mon, 01 Apr 2019)

Changed paths:
M mythtv/libs/libmythtv/recorders/v4l2encstreamhandler.cpp

Log Message:
-----------
Use correct error variable in the V4L2encStreamHandler class.

This structure inherits error variables from two different base
structure. Fix three places where commit 266f1eb11a (which changed
member names to start with m_) used the wrong error variable, since
one of the two conflicting names in the base classes had to be
changes.


Commit: 4ce623acb995aae71d13f1bc804aa5176c0ef360
https://github.com/MythTV/mythtv/commit/4ce623acb995aae71d13f1bc804aa5176c0ef360
Author: David Hampton <mythtv@love2code.net>
Date: 2019-04-01 (Mon, 01 Apr 2019)

Changed paths:
M mythtv/libs/libmyth/audio/audiooutputalsa.cpp
M mythtv/libs/libmyth/audio/audiooutputalsa.h
M mythtv/libs/libmythtv/cc708decoder.cpp
M mythtv/libs/libmythtv/cc708reader.cpp
M mythtv/libs/libmythtv/cc708reader.h
M mythtv/libs/libmythtv/cc708window.cpp
M mythtv/libs/libmythtv/cc708window.h
M mythtv/libs/libmythtv/channelgroup.cpp
M mythtv/libs/libmythtv/channelgroup.h
M mythtv/libs/libmythtv/teletextscreen.cpp
M mythtv/libs/libmythtv/teletextscreen.h

Log Message:
-----------
tidy: Convert function arguments from int to boolean.

The clang-tidy "implicit boolean conversion" check pointed out a
couple of places where booleans were being converted to integers in
order to call a function. Upon inspection, the best solution was to
convert the called function argument to take a boolean value.

https://clang.llvm.org/extra/clang-tidy/checks/readability-implicit-bool-conversion.html


Commit: b7886b461a9f7f821fb17ac1e11a136cfe464371
https://github.com/MythTV/mythtv/commit/b7886b461a9f7f821fb17ac1e11a136cfe464371
Author: David Hampton <mythtv@love2code.net>
Date: 2019-04-01 (Mon, 01 Apr 2019)

Changed paths:
M mythtv/libs/libmythbase/mythsocket.cpp

Log Message:
-----------
Fix timeout on mediaserver announcements.

The socket code was converted in 2009 from taking a boolean to indicate
a 'short' timeout, to taking an actual timeout in milliseconds. Fix
one location that didn't get converted.


Commit: a62a4e95da01b4cecd7405dd59f66396c6cd6c59
https://github.com/MythTV/mythtv/commit/a62a4e95da01b4cecd7405dd59f66396c6cd6c59
Author: David Hampton <mythtv@love2code.net>
Date: 2019-04-01 (Mon, 01 Apr 2019)

Changed paths:
M mythtv/libs/libmythtv/avformatdecoder.cpp
M mythtv/libs/libmythtv/cc708reader.cpp

Log Message:
-----------
Fix parameters on CC708 call to create StreamInfo.

The StreamInfo code was enhanced in 2010 to include an additional
orig_num_channels required argument. Fix three locations that didn't
get converted. These wasn't caught because the compiler silently
converted what was once an optional boolean argument into a now
required integer argument, and the converted value of zero was a
reasonable value.

Add to 39e30b8938. Fix comment.


Commit: 923847d6a0249e87d2b9cfba3dfb11f5e00b0cf4
https://github.com/MythTV/mythtv/commit/923847d6a0249e87d2b9cfba3dfb11f5e00b0cf4
Author: David Hampton <mythtv@love2code.net>
Date: 2019-04-01 (Mon, 01 Apr 2019)

Changed paths:
M mythtv/libs/libmyth/programinfo.cpp

Log Message:
-----------
tidy: Explicitly convert enum to boolean in ProgramInfo::SaveAutoExpire.

The clang-tidy "implicit boolean conversion" check pointed out a
places where an enum is converted to a boolean. Make this an explicit
test against the enum value that corresponds to zero.

https://clang.llvm.org/extra/clang-tidy/checks/readability-implicit-bool-conversion.html


Commit: 4aee8d1468da54989638a01dfc3790f5fa996e39
https://github.com/MythTV/mythtv/commit/4aee8d1468da54989638a01dfc3790f5fa996e39
Author: David Hampton <mythtv@love2code.net>
Date: 2019-04-01 (Mon, 01 Apr 2019)

Changed paths:
M mythtv/libs/libmythtv/avformatdecoder.cpp
M mythtv/libs/libmythtv/decoderbase.cpp

Log Message:
-----------
tidy: Fix return value from DecoderBase SetTrack and AutoSelectTrack.

The clang-tidy "implicit boolean conversion" check pointed out a
couple of places in this file where functions return a boolean that
gets implicitly cast to an integer. According to the documentation
the return value is supposed to be a track number (or -1). This bug
appears to have been introduced by work done in 2006, but was never
found because all callers of these function ignore the returned
values.

https://clang.llvm.org/extra/clang-tidy/checks/readability-implicit-bool-conversion.html


Commit: 3d713932f08f423e53f9f775593773a41e9d9871
https://github.com/MythTV/mythtv/commit/3d713932f08f423e53f9f775593773a41e9d9871
Author: David Hampton <mythtv@love2code.net>
Date: 2019-04-01 (Mon, 01 Apr 2019)

Changed paths:
M mythtv/libs/libmythtv/avformatdecoder.cpp
M mythtv/libs/libmythtv/privatedecoder_crystalhd.cpp

Log Message:
-----------
tidy: Explicitly convert boolean to integer for some library calls.

The clang-tidy "implicit boolean conversion" check pointed out a
couple of places where a system library is expecting a boolean value,
but the API states that the value is an integer. These true/false
values could be converted to 1/0, but the intent seems more obvious if
the true/false values are kept and are explicitly converted to integer
values.

https://clang.llvm.org/extra/clang-tidy/checks/readability-implicit-bool-conversion.html


Commit: 54739ef396a75e0039360de6ec3b724cd08d477e
https://github.com/MythTV/mythtv/commit/54739ef396a75e0039360de6ec3b724cd08d477e
Author: David Hampton <mythtv@love2code.net>
Date: 2019-04-01 (Mon, 01 Apr 2019)

Changed paths:
M mythtv/libs/libmythtv/avformatdecoder.cpp

Log Message:
-----------
tidy: Return zero instead of false.

The clang-tidy "implicit boolean conversion" check pointed out a
place where function that returns 'int' was returning the value
false that is implicitly cast to zero. Replace this implicit cast
with the number 0.

https://clang.llvm.org/extra/clang-tidy/checks/readability-implicit-bool-conversion.html


Commit: ac9b30cec099d21a65a0e4e4161bc1111ce11ce6
https://github.com/MythTV/mythtv/commit/ac9b30cec099d21a65a0e4e4161bc1111ce11ce6
Author: David Hampton <mythtv@love2code.net>
Date: 2019-04-01 (Mon, 01 Apr 2019)

Changed paths:
M mythtv/libs/libmythtv/dsmcc.cpp
M mythtv/programs/mythcommflag/BorderDetector.cpp

Log Message:
-----------
tidy: Don't set variables that will be ignored.


Commit: c14413e519b8b183c0929c3dea44bc7c9d28dfbe
https://github.com/MythTV/mythtv/commit/c14413e519b8b183c0929c3dea44bc7c9d28dfbe
Author: David Hampton <mythtv@love2code.net>
Date: 2019-04-01 (Mon, 01 Apr 2019)

Changed paths:
M mythtv/libs/libmythtv/recorders/channelbase.cpp

Log Message:
-----------
tidy: Fix error return value from ChannelBase::GetChanID.

The clang-tidy "implicit boolean conversion" check pointed out that
this function returns false when there is no channel id, instead of
returning an integer. Return -1 like in the other error returns.

https://clang.llvm.org/extra/clang-tidy/checks/readability-implicit-bool-conversion.html


Commit: 4bbdf0ce98f5364d3b6c558855d745ff6fc6dfd1
https://github.com/MythTV/mythtv/commit/4bbdf0ce98f5364d3b6c558855d745ff6fc6dfd1
Author: David Hampton <mythtv@love2code.net>
Date: 2019-04-01 (Mon, 01 Apr 2019)

Changed paths:
M mythtv/libs/libmythtv/recorders/recorderbase.cpp
M mythtv/libs/libmythtv/recorders/recorderbase.h

Log Message:
-----------
Add a SetBoolOption function to RecorderBase.

The clang-tidy "implicit boolean conversion" check pointed out a
couple of places where booleans were implicitly converted to integers
and then passed to the SetOption function. Add a SetBoolOption
function (that handles the bool->int conversion) to allow better type
checking of the callers.

https://clang.llvm.org/extra/clang-tidy/checks/readability-implicit-bool-conversion.html


Commit: 7ec01cbe795b704a563e15e88fdb7fd760fd2261
https://github.com/MythTV/mythtv/commit/7ec01cbe795b704a563e15e88fdb7fd760fd2261
Author: David Hampton <mythtv@love2code.net>
Date: 2019-04-01 (Mon, 01 Apr 2019)

Changed paths:
M mythtv/libs/libmythtv/recorders/dtvsignalmonitor.cpp

Log Message:
-----------
Eliminate implicit bool->int casting in dtvsignalmonitor.cpp.

The clang-tidy "implicit boolean conversion" check pointed out a
couple of implicit bool->integer conversions in the HandlePMT
function. Rewrite two lines to eliminate the warning messages.

https://clang.llvm.org/extra/clang-tidy/checks/readability-implicit-bool-conversion.html


Commit: db8c9cc581ee85e343ed5e3adb1d0ffdeb723ef4
https://github.com/MythTV/mythtv/commit/db8c9cc581ee85e343ed5e3adb1d0ffdeb723ef4
Author: David Hampton <mythtv@love2code.net>
Date: 2019-04-01 (Mon, 01 Apr 2019)

Changed paths:
M mythtv/libs/libmythui/mythdialogbox.cpp

Log Message:
-----------
tidy: Fix error return value from mythdialogbox WaitFor function.

The clang-tidy "implicit boolean conversion" check pointed out that
this function implicitly casts the result of block.exec to a boolean
return value. Make the conversion explicit.

https://clang.llvm.org/extra/clang-tidy/checks/readability-implicit-bool-conversion.html


Commit: 6b8cc3b0da1ed0074cf989b460080f4ba72c409b
https://github.com/MythTV/mythtv/commit/6b8cc3b0da1ed0074cf989b460080f4ba72c409b
Author: David Hampton <mythtv@love2code.net>
Date: 2019-04-01 (Mon, 01 Apr 2019)

Changed paths:
M mythtv/libs/libmythtv/tv_play.cpp
M mythtv/libs/libmythui/mythuiwebbrowser.cpp

Log Message:
-----------
tidy: Use boolean operator instead of integer operator.

The clang-tidy "implicit boolean conversion" check pointed out that
two booleans were being converted to integers, or-ed together, and
then being converted back to a boolean. Simpler to just use the
boolean or operator.

https://clang.llvm.org/extra/clang-tidy/checks/readability-implicit-bool-conversion.html


Commit: 3894c4efbca03127887b658a8cb3d579bc0cc8e7
https://github.com/MythTV/mythtv/commit/3894c4efbca03127887b658a8cb3d579bc0cc8e7
Author: David Hampton <mythtv@love2code.net>
Date: 2019-04-01 (Mon, 01 Apr 2019)

Changed paths:
M mythtv/libs/libmythui/cecadapter.cpp
M mythtv/libs/libmythupnp/upnpdevice.cpp
M mythtv/libs/libmythupnp/upnpdevice.h
M mythtv/programs/mythfrontend/videodlg.cpp

Log Message:
-----------
tidy: Use '=default' where possible.

Using explicitly defaulted function declarations enables more
opportunities in optimization, because the compiler might treat
explicitly defaulted functions as trivial. These changes were
pointed out by the clang-tidy program.


Commit: 798356d921508b8a2dddd752e2fb7d0556c27b7c
https://github.com/MythTV/mythtv/commit/798356d921508b8a2dddd752e2fb7d0556c27b7c
Author: David Hampton <mythtv@love2code.net>
Date: 2019-04-01 (Mon, 01 Apr 2019)

Changed paths:
M mythtv/libs/libmythtv/remoteencoder.cpp
M mythtv/libs/libmythtv/tv_rec.cpp
M mythtv/programs/mythbackend/encoderlink.cpp
M mythtv/programs/mythbackend/mainserver.cpp

Log Message:
-----------
tidy: Fix misleading variable name.

The is_complete_valid_channel_on_rec variable is not a boolean as is
implied by the 'is_' prefix. Its actually an integer. Rename the
variable to prevent confusion.


Commit: e214d729e50b5aac8f1fec0e4d99e9652d202712
https://github.com/MythTV/mythtv/commit/e214d729e50b5aac8f1fec0e4d99e9652d202712
Author: David Hampton <mythtv@love2code.net>
Date: 2019-04-01 (Mon, 01 Apr 2019)

Changed paths:
M mythtv/programs/mythfilerecorder/mythfilerecorder.cpp

Log Message:
-----------
Initialize variable with 0 instead of false.


Commit: c5567897a0980527e45b39e52a3af10276cbe393
https://github.com/MythTV/mythtv/commit/c5567897a0980527e45b39e52a3af10276cbe393
Author: David Hampton <mythtv@love2code.net>
Date: 2019-04-01 (Mon, 01 Apr 2019)

Changed paths:
M mythtv/programs/mythfrontend/globalsettings.cpp

Log Message:
-----------
tidy: Change spinbox setting calls to use 0/1 instead of false/true.

The clang-tidy "implicit boolean conversion" check pointed out a
couple of places where *SpinBoxSetting was called with a boolean
instead of an integer. The spinbox code was changed in 2017, and the
change expected this implicit conversion to occur for backward
compatibility. Convert callers so the backward compatibility is no
longer necessary.

https://clang.llvm.org/extra/clang-tidy/checks/readability-implicit-bool-conversion.html


Commit: c7819f57eec13a63d108b9f2d8a8d0aea1859eff
https://github.com/MythTV/mythtv/commit/c7819f57eec13a63d108b9f2d8a8d0aea1859eff
Author: David Hampton <mythtv@love2code.net>
Date: 2019-04-01 (Mon, 01 Apr 2019)

Changed paths:
M mythtv/programs/mythtranscode/transcode.cpp

Log Message:
-----------
Add a get_bool_option function to transcode.cpp.

The clang-tidy "implicit boolean conversion" check pointed out a
couple of places where integers were implicitly converted to booleans
in conditional statements. Add a get_bool_option function (that
handles the int->bool conversion) to allow better type checking of the
callers.

https://clang.llvm.org/extra/clang-tidy/checks/readability-implicit-bool-conversion.html


Commit: 44431bf7449c15dc8b107c7e5333952558b00ddc
https://github.com/MythTV/mythtv/commit/44431bf7449c15dc8b107c7e5333952558b00ddc
Author: David Hampton <mythtv@love2code.net>
Date: 2019-04-01 (Mon, 01 Apr 2019)

Changed paths:
M mythtv/libs/libmythtv/subtitlescreen.cpp

Log Message:
-----------
tidy: Fix memory leak in subtitle code.

The clang-tidy "new/delete leak" checker pointed out that the
allocated providerBaseShape object might be leaked. Free the memory
if it isn't assigned to another variable.


Commit: ab7b44d42aaf18b80fa27075b4e09f3e90dda112
https://github.com/MythTV/mythtv/commit/ab7b44d42aaf18b80fa27075b4e09f3e90dda112
Author: David Hampton <mythtv@love2code.net>
Date: 2019-04-01 (Mon, 01 Apr 2019)

Changed paths:
M mythplugins/mytharchive/mytharchive/recordingselector.cpp
M mythplugins/mytharchive/mytharchive/videoselector.cpp
M mythplugins/mythmusic/mythmusic/bumpscope.cpp
M mythplugins/mythmusic/mythmusic/visualize.cpp
M mythplugins/mythmusic/mythmusic/vorbisencoder.cpp
M mythplugins/mythzoneminder/mythzmserver/zmserver.cpp
M mythplugins/mythzoneminder/mythzoneminder/zmevents.cpp
M mythtv/libs/libmyth/audio/eldutils.cpp
M mythtv/libs/libmyth/omxcontext.cpp
M mythtv/libs/libmyth/programinfo.cpp
M mythtv/libs/libmythfreesurround/freesurround.cpp
M mythtv/libs/libmythmpeg2/header.c
M mythtv/libs/libmythtv/audioplayer.cpp
M mythtv/libs/libmythtv/avformatdecoder.cpp
M mythtv/libs/libmythtv/cardutil.cpp
M mythtv/libs/libmythtv/cc608decoder.cpp
M mythtv/libs/libmythtv/channelscan/channelimporter.cpp
M mythtv/libs/libmythtv/channelscan/channelscan_sm.cpp
M mythtv/libs/libmythtv/channelscan/scaninfo.cpp
M mythtv/libs/libmythtv/channelsettings.cpp
M mythtv/libs/libmythtv/channelutil.cpp
M mythtv/libs/libmythtv/dbcheck.cpp
M mythtv/libs/libmythtv/decoderbase.cpp
M mythtv/libs/libmythtv/diseqc.cpp
M mythtv/libs/libmythtv/dsmccobjcarousel.cpp
M mythtv/libs/libmythtv/dtvconfparser.cpp
M mythtv/libs/libmythtv/dtvmultiplex.cpp
M mythtv/libs/libmythtv/eithelper.cpp
M mythtv/libs/libmythtv/filtermanager.cpp
M mythtv/libs/libmythtv/frequencytables.cpp
M mythtv/libs/libmythtv/mpeg/atscstreamdata.cpp
M mythtv/libs/libmythtv/mpeg/atsctables.cpp
M mythtv/libs/libmythtv/mpeg/dvbstreamdata.cpp
M mythtv/libs/libmythtv/mpeg/dvbtables.cpp
M mythtv/libs/libmythtv/mpeg/mpegdescriptors.cpp
M mythtv/libs/libmythtv/mpeg/mpegstreamdata.cpp
M mythtv/libs/libmythtv/mpeg/mpegtables.cpp
M mythtv/libs/libmythtv/mpeg/scanstreamdata.cpp
M mythtv/libs/libmythtv/mpeg/sctetables.cpp
M mythtv/libs/libmythtv/mpeg/tsstreamdata.cpp
M mythtv/libs/libmythtv/mythplayer.cpp
M mythtv/libs/libmythtv/nuppeldecoder.cpp
M mythtv/libs/libmythtv/openglvideo.cpp
M mythtv/libs/libmythtv/programdata.cpp
M mythtv/libs/libmythtv/recorders/NuppelVideoRecorder.cpp
M mythtv/libs/libmythtv/recorders/channelbase.cpp
M mythtv/libs/libmythtv/recorders/dtvrecorder.cpp
M mythtv/libs/libmythtv/recorders/dtvsignalmonitor.cpp
M mythtv/libs/libmythtv/recorders/hdhrstreamhandler.cpp
M mythtv/libs/libmythtv/recorders/linuxavcinfo.cpp
M mythtv/libs/libmythtv/recorders/mpegrecorder.cpp
M mythtv/libs/libmythtv/recorders/signalmonitor.cpp
M mythtv/libs/libmythtv/recorders/streamhandler.cpp
M mythtv/libs/libmythtv/recorders/v4l2encstreamhandler.cpp
M mythtv/libs/libmythtv/recordingprofile.cpp
M mythtv/libs/libmythtv/subtitlescreen.cpp
M mythtv/libs/libmythtv/transporteditor.cpp
M mythtv/libs/libmythtv/tv_play.cpp
M mythtv/libs/libmythtv/tv_rec.cpp
M mythtv/libs/libmythtv/tvbrowsehelper.cpp
M mythtv/libs/libmythtv/tvremoteutil.cpp
M mythtv/libs/libmythtv/videobuffers.cpp
M mythtv/libs/libmythtv/videoout_xv.cpp
M mythtv/libs/libmythtv/videosource.cpp
M mythtv/libs/libmythui/DisplayRes.cpp
M mythtv/libs/libmythui/DisplayResScreen.cpp
M mythtv/libs/libmythui/DisplayResX.cpp
M mythtv/libs/libmythui/x11colors.cpp
M mythtv/libs/libmythupnp/ssdp.cpp
M mythtv/programs/mythbackend/main.cpp
M mythtv/programs/mythbackend/main_helpers.cpp
M mythtv/programs/mythbackend/mainserver.cpp
M mythtv/programs/mythbackend/scheduler.cpp
M mythtv/programs/mythbackend/services/dvr.cpp
M mythtv/programs/mythcommflag/HistogramAnalyzer.cpp
M mythtv/programs/mythcommflag/SceneChangeDetector.cpp
M mythtv/programs/mythfrontend/audiogeneralsettings.cpp
M mythtv/programs/mythfrontend/globalsettings.cpp
M mythtv/programs/mythfrontend/guidegrid.cpp
M mythtv/programs/mythfrontend/manualschedule.cpp
M mythtv/programs/mythfrontend/playbackbox.cpp
M mythtv/programs/mythfrontend/prevreclist.cpp
M mythtv/programs/mythfrontend/progfind.cpp
M mythtv/programs/mythfrontend/proglist.cpp
M mythtv/programs/mythfrontend/proglist_helpers.cpp
M mythtv/programs/mythfrontend/scheduleeditor.cpp
M mythtv/programs/mythfrontend/viewschedulediff.cpp
M mythtv/programs/mythpreviewgen/main.cpp
M mythtv/programs/mythtv-setup/main.cpp

Log Message:
-----------
tidy: Use the correct type for loop counters.

The clang-tidy "loop variable too small" check pointed out many places
where the variable used in a for loop is too small for upper limit on
the value being counted. Almost all of these are for using a uint to
count up to x.size(). Since the size() function returns a value of
type size_t, the trivial solution to these is to change the counter
type to size_t so its always guaranteed to be the right size.

https://clang.llvm.org/extra/clang-tidy/checks/bugprone-too-small-loop-variable.html


Commit: 24b9988ccd8dfd72d1ad525de19f87dbb5c3880e
https://github.com/MythTV/mythtv/commit/24b9988ccd8dfd72d1ad525de19f87dbb5c3880e
Author: David Hampton <mythtv@love2code.net>
Date: 2019-04-01 (Mon, 01 Apr 2019)

Changed paths:
M mythtv/filters/adjust/filter_adjust.c
M mythtv/libs/libmythtv/recorders/vbitext/vbi.c

Log Message:
-----------
tidy: Fix bugprone 'incorrect rounding'.

The clang-tidy "incorrect rounding" check pointed out two remaining
places where the code used "(int)(var + 0.5)" to round a variable to
an integer. Replaces these with calls to lround.

https://clang.llvm.org/extra/clang-tidy/checks/bugprone-incorrect-roundings.html


Commit: 82cdc47e7875b37391e4e57e82671deee11982af
https://github.com/MythTV/mythtv/commit/82cdc47e7875b37391e4e57e82671deee11982af
Author: David Hampton <mythtv@love2code.net>
Date: 2019-04-01 (Mon, 01 Apr 2019)

Changed paths:
M mythplugins/mythzoneminder/mythzoneminder/zmliveplayer.cpp
M mythplugins/mythzoneminder/mythzoneminder/zmliveplayer.h

Log Message:
-----------
tidy: Rename zmliveplayer showMenu function and mark it as an override.

The clang-tidy "virtual near miss" check pointed out one function that
appears should have been an override but didn't match exactly. The
first letter of this function is lowercase with the first letter of
the function in the parent class is uppercase. They both take the
same arguments. Change the capitalization on this function name and
mark it as an override.

https://clang.llvm.org/extra/clang-tidy/checks/bugprone-virtual-near-miss.html


Commit: bdea4df1063c0c92cca85dcac241ee2ff5e5837f
https://github.com/MythTV/mythtv/commit/bdea4df1063c0c92cca85dcac241ee2ff5e5837f
Author: David Hampton <mythtv@love2code.net>
Date: 2019-04-01 (Mon, 01 Apr 2019)

Changed paths:
M mythtv/libs/libmythmpeg2/header.c

Log Message:
-----------
tidy: Fix suspicious string comparisons in mpeg2 header.c.

The clang-tidy "suspicious string compare" pointed out two places
where the return value of memcmp wasn't explicitly tested against
zero. Add an explicit test.

https://clang.llvm.org/extra/clang-tidy/checks/bugprone-suspicious-string-compare.html


Commit: 3682ce20f8ba18e4491c4ecc46c655b7150d5d71
https://github.com/MythTV/mythtv/commit/3682ce20f8ba18e4491c4ecc46c655b7150d5d71
Author: David Hampton <mythtv@love2code.net>
Date: 2019-04-01 (Mon, 01 Apr 2019)

Changed paths:
M mythplugins/mytharchive/mytharchivehelper/external/pxsup2dast.c
M mythtv/filters/denoise3d/filter_denoise3d.c
M mythtv/filters/yadif/filter_yadif.c
M mythtv/libs/libmyth/audio/audiooutputbase.h
M mythtv/libs/libmythbase/unzip.cpp
M mythtv/libs/libmythmpeg2/idct.c
M mythtv/libs/libmythmpeg2/idct_mmx.c
M mythtv/libs/libmythmpeg2/motion_comp.c
M mythtv/libs/libmythmpeg2/slice.c
M mythtv/libs/libmythtv/visualisations/goom/goom_tools.h
M mythtv/libs/libmythtv/visualisations/goom/mathtools.h
M mythtv/libs/libmythtv/visualisations/goom/tentacle3d.c
M mythtv/libs/libmythtv/visualisations/goom/v3d.h

Log Message:
-----------
tidy: Add parentheses around macro arguments.

The clang-tidy "bugprone macro parentheses" checker pointed out a
number of places where the arguments to macros weren't enclosed in
parentheses. This can cause unexpected behavior if the argument isn't
a single variable, but is an expression. Extra parentheses added by
clang-tidy; additional table cleanups in idct_mmx.c done by hand.

https://clang.llvm.org/extra/clang-tidy/checks/bugprone-macro-parentheses.html


Commit: c62b45c9c6c7f825f4121f3334d67ab869230829
https://github.com/MythTV/mythtv/commit/c62b45c9c6c7f825f4121f3334d67ab869230829
Author: David Hampton <mythtv@love2code.net>
Date: 2019-04-01 (Mon, 01 Apr 2019)

Changed paths:
M mythtv/libs/libmythui/mythuifilebrowser.cpp

Log Message:
-----------
Fix UI File Browser to show sizes in tenths.

The clang-tidy "integer division result used by floating point" test
indicated that MythUIFileBrowser::FormatSize was taking the size of a
file, performing an integer division, converting the result to a
double, and printing it. This is guaranteed to always produce an
integer result, so the cast to double is superfluous. The intended
result seems to be to print out some number of decimal places and not
just an integer, so cast the file size to a double before dividing the
number. Also tweak the parameters to QString::arg so that it will
only print out a single place after the decimal point.

https://clang.llvm.org/extra/clang-tidy/checks/bugprone-integer-division.html


Commit: 448623b12cb45f73b34c751ce1fdadfb0553045f
https://github.com/MythTV/mythtv/commit/448623b12cb45f73b34c751ce1fdadfb0553045f
Author: David Hampton <mythtv@love2code.net>
Date: 2019-04-01 (Mon, 01 Apr 2019)

Changed paths:
M mythplugins/mythnetvision/mythnetvision/netsearch.cpp

Log Message:
-----------
Simplify code in netsearch.cpp to count number of pages.

The clang-tidy "integer division result used by floating point" test
indicated that NetSearch::SearchFinished the calculations to determine
the number of pages needed to display all results was using floating
point calculations. These calculations can be simplified using the
properties of integer division. Straight division will provide the
number of full pages needed to display the results, and a modulo
operation will indicate whether an additional partial page of results
is needed.

https://clang.llvm.org/extra/clang-tidy/checks/bugprone-integer-division.html


Commit: 96254b3e6e6705006b6a6c59c65bde9c1f06c822
https://github.com/MythTV/mythtv/commit/96254b3e6e6705006b6a6c59c65bde9c1f06c822
Author: David Hampton <mythtv@love2code.net>
Date: 2019-04-01 (Mon, 01 Apr 2019)

Changed paths:
A message
M mythplugins/mythgallery/mythgallery/glsingleview.cpp
M mythplugins/mythmusic/mythmusic/bumpscope.cpp
M mythplugins/mythmusic/mythmusic/visualize.cpp
M mythtv/libs/libmythtv/mythplayer.cpp
M mythtv/libs/libmythtv/visualisations/videovisualcircles.cpp
M mythtv/libs/libmythtv/visualisations/videovisualspectrum.cpp
M mythtv/libs/libmythui/mythdisplay.cpp
M mythtv/programs/mythbackend/mainserver.cpp
M mythtv/programs/mythbackend/scheduler.cpp

Log Message:
-----------
tidy: Clean up integer division warnings.

The clang-tidy "integer division result used by floating point" test
pointed out a number of potential rounding issues. Fix most of these
by converting to a float/double before the division, wither by a an
explicit cast or by changing the integer divisor to a float divisor.
Fix the scheduler by rewriting the code to be more explicit about
what's happening.

https://clang.llvm.org/extra/clang-tidy/checks/bugprone-integer-division.html


Commit: 3e6d4afa2a94febe579578f02362ba18413dfffe
https://github.com/MythTV/mythtv/commit/3e6d4afa2a94febe579578f02362ba18413dfffe
Author: David Hampton <mythtv@love2code.net>
Date: 2019-04-01 (Mon, 01 Apr 2019)

Changed paths:
M mythtv/programs/mythtranscode/main.cpp

Log Message:
-----------
tidy: Convert variables to boolean in mythtranscode.

The clang-tidy "implicit boolean conversion" check pointed out a
couple of places where integers were implicitly converted to booleans
in conditional statements. The simple solution is ton convert these
variable to be of type boolean.

https://clang.llvm.org/extra/clang-tidy/checks/readability-implicit-bool-conversion.html


Commit: 64f4861e709e94b19496f1cc97ecf376a1144a27
https://github.com/MythTV/mythtv/commit/64f4861e709e94b19496f1cc97ecf376a1144a27
Author: David Hampton <mythtv@love2code.net>
Date: 2019-04-01 (Mon, 01 Apr 2019)

Changed paths:
A .clang-tidy

Log Message:
-----------
Current working .clang-tidy file.


Commit: 4fe06058d506e80a8db04646e60cf0b27377f431
https://github.com/MythTV/mythtv/commit/4fe06058d506e80a8db04646e60cf0b27377f431
Author: David Hampton <mythtv@love2code.net>
Date: 2019-04-01 (Mon, 01 Apr 2019)

Changed paths:
M mythtv/libs/libmythbase/mythcorecontext.cpp
M mythtv/libs/libmythbase/mythcorecontext.h
M mythtv/libs/libmythbase/mythsocket.cpp
M mythtv/libs/libmythmetadata/imagemanager.h
M mythtv/libs/libmythtv/avformatdecoder.cpp
M mythtv/libs/libmythtv/cardutil.cpp
M mythtv/libs/libmythtv/cardutil.h
M mythtv/libs/libmythtv/channelscan/channelscan_sm.cpp
M mythtv/libs/libmythtv/dtvconfparserhelpers.cpp
M mythtv/libs/libmythtv/dtvconfparserhelpers.h
M mythtv/libs/libmythtv/dtvmultiplex.cpp
M mythtv/libs/libmythtv/dtvmultiplex.h
M mythtv/libs/libmythtv/eitfixup.cpp
M mythtv/libs/libmythtv/eitfixup.h
M mythtv/libs/libmythtv/eithelper.cpp
M mythtv/libs/libmythtv/mpeg/mpegdescriptors.h
M mythtv/libs/libmythtv/recorders/channelbase.cpp
M mythtv/libs/libmythtv/recorders/dtvchannel.cpp
M mythtv/libs/libmythtv/recorders/dvbchannel.cpp
M mythtv/libs/libmythtv/recordinginfo.cpp
M mythtv/libs/libmythtv/transporteditor.cpp
M mythtv/libs/libmythtv/videosource.cpp
M mythtv/programs/mythbackend/mainserver.cpp
M mythtv/programs/mythbackend/scheduler.cpp

Log Message:
-----------
Merge branch 'master' into 'clang-tidy' branch.


Commit: 62adc17c723672e18e824de6567f77277cbb6708
https://github.com/MythTV/mythtv/commit/62adc17c723672e18e824de6567f77277cbb6708
Author: David Hampton <mythtv@love2code.net>
Date: 2019-04-01 (Mon, 01 Apr 2019)

Changed paths:
A .clang-tidy
A message
M mythplugins/mytharchive/mytharchive/recordingselector.cpp
M mythplugins/mytharchive/mytharchive/videoselector.cpp
M mythplugins/mytharchive/mytharchivehelper/external/pxsup2dast.c
M mythplugins/mytharchive/mytharchivehelper/main.cpp
M mythplugins/mythgallery/mythgallery/glsingleview.cpp
M mythplugins/mythgallery/mythgallery/imageview.cpp
M mythplugins/mythgallery/mythgallery/singleview.cpp
M mythplugins/mythmusic/mythmusic/bumpscope.cpp
M mythplugins/mythmusic/mythmusic/flacencoder.cpp
M mythplugins/mythmusic/mythmusic/lameencoder.cpp
M mythplugins/mythmusic/mythmusic/playlisteditorview.cpp
M mythplugins/mythmusic/mythmusic/visualize.cpp
M mythplugins/mythmusic/mythmusic/vorbisencoder.cpp
M mythplugins/mythnetvision/mythfillnetvision/main.cpp
M mythplugins/mythnetvision/mythnetvision/netsearch.cpp
M mythplugins/mythzoneminder/mythzmserver/zmserver.cpp
M mythplugins/mythzoneminder/mythzoneminder/zmevents.cpp
M mythplugins/mythzoneminder/mythzoneminder/zmliveplayer.cpp
M mythplugins/mythzoneminder/mythzoneminder/zmliveplayer.h
M mythtv/filters/adjust/filter_adjust.c
M mythtv/filters/denoise3d/filter_denoise3d.c
M mythtv/filters/yadif/filter_yadif.c
M mythtv/libs/libmyth/audio/audiooutputalsa.cpp
M mythtv/libs/libmyth/audio/audiooutputalsa.h
M mythtv/libs/libmyth/audio/audiooutputbase.h
M mythtv/libs/libmyth/audio/eldutils.cpp
M mythtv/libs/libmyth/mediamonitor-unix.cpp
M mythtv/libs/libmyth/omxcontext.cpp
M mythtv/libs/libmyth/programinfo.cpp
M mythtv/libs/libmyth/programinfo.h
M mythtv/libs/libmythbase/filesysteminfo.cpp
M mythtv/libs/libmythbase/housekeeper.cpp
M mythtv/libs/libmythbase/loggingserver.cpp
M mythtv/libs/libmythbase/mythcommandlineparser.cpp
M mythtv/libs/libmythbase/mythsignalingtimer.cpp
M mythtv/libs/libmythbase/mythsystem.cpp
M mythtv/libs/libmythbase/remotefile.cpp
M mythtv/libs/libmythbase/unzip.cpp
M mythtv/libs/libmythfreesurround/freesurround.cpp
M mythtv/libs/libmythmetadata/imagemetadata.cpp
M mythtv/libs/libmythmpeg2/header.c
M mythtv/libs/libmythmpeg2/idct.c
M mythtv/libs/libmythmpeg2/idct_mmx.c
M mythtv/libs/libmythmpeg2/motion_comp.c
M mythtv/libs/libmythmpeg2/slice.c
M mythtv/libs/libmythtv/Bluray/bdringbuffer.cpp
M mythtv/libs/libmythtv/HLS/httplivestreambuffer.cpp
M mythtv/libs/libmythtv/audioplayer.cpp
M mythtv/libs/libmythtv/avformatdecoder.cpp
M mythtv/libs/libmythtv/cardutil.cpp
M mythtv/libs/libmythtv/cc608decoder.cpp
M mythtv/libs/libmythtv/cc708decoder.cpp
M mythtv/libs/libmythtv/cc708reader.cpp
M mythtv/libs/libmythtv/cc708reader.h
M mythtv/libs/libmythtv/cc708window.cpp
M mythtv/libs/libmythtv/cc708window.h
M mythtv/libs/libmythtv/channelgroup.cpp
M mythtv/libs/libmythtv/channelgroup.h
M mythtv/libs/libmythtv/channelscan/channelimporter.cpp
M mythtv/libs/libmythtv/channelscan/channelscan_sm.cpp
M mythtv/libs/libmythtv/channelscan/channelscanner.cpp
M mythtv/libs/libmythtv/channelscan/scaninfo.cpp
M mythtv/libs/libmythtv/channelsettings.cpp
M mythtv/libs/libmythtv/channelutil.cpp
M mythtv/libs/libmythtv/dbcheck.cpp
M mythtv/libs/libmythtv/decoderbase.cpp
M mythtv/libs/libmythtv/diseqc.cpp
M mythtv/libs/libmythtv/diseqc.h
M mythtv/libs/libmythtv/dsmcc.cpp
M mythtv/libs/libmythtv/dsmccobjcarousel.cpp
M mythtv/libs/libmythtv/dtvconfparser.cpp
M mythtv/libs/libmythtv/dtvmultiplex.cpp
M mythtv/libs/libmythtv/dvdstream.cpp
M mythtv/libs/libmythtv/eithelper.cpp
M mythtv/libs/libmythtv/fileringbuffer.cpp
M mythtv/libs/libmythtv/filtermanager.cpp
M mythtv/libs/libmythtv/frequencytables.cpp
M mythtv/libs/libmythtv/icringbuffer.cpp
M mythtv/libs/libmythtv/mpeg/atscstreamdata.cpp
M mythtv/libs/libmythtv/mpeg/atsctables.cpp
M mythtv/libs/libmythtv/mpeg/dvbdescriptors.h
M mythtv/libs/libmythtv/mpeg/dvbstreamdata.cpp
M mythtv/libs/libmythtv/mpeg/dvbtables.cpp
M mythtv/libs/libmythtv/mpeg/mpegdescriptors.cpp
M mythtv/libs/libmythtv/mpeg/mpegdescriptors.h
M mythtv/libs/libmythtv/mpeg/mpegstreamdata.cpp
M mythtv/libs/libmythtv/mpeg/mpegtables.cpp
M mythtv/libs/libmythtv/mpeg/pespacket.h
M mythtv/libs/libmythtv/mpeg/premieredescriptors.h
M mythtv/libs/libmythtv/mpeg/scanstreamdata.cpp
M mythtv/libs/libmythtv/mpeg/scanstreamdata.h
M mythtv/libs/libmythtv/mpeg/sctetables.cpp
M mythtv/libs/libmythtv/mpeg/splicedescriptors.cpp
M mythtv/libs/libmythtv/mpeg/splicedescriptors.h
M mythtv/libs/libmythtv/mpeg/tsstreamdata.cpp
M mythtv/libs/libmythtv/mythframe.cpp
M mythtv/libs/libmythtv/mythframe.h
M mythtv/libs/libmythtv/mythplayer.cpp
M mythtv/libs/libmythtv/nuppeldecoder.cpp
M mythtv/libs/libmythtv/openglvideo.cpp
M mythtv/libs/libmythtv/privatedecoder_crystalhd.cpp
M mythtv/libs/libmythtv/programdata.cpp
M mythtv/libs/libmythtv/recorders/ExternalChannel.cpp
M mythtv/libs/libmythtv/recorders/ExternalChannel.h
M mythtv/libs/libmythtv/recorders/ExternalSignalMonitor.cpp
M mythtv/libs/libmythtv/recorders/NuppelVideoRecorder.cpp
M mythtv/libs/libmythtv/recorders/asichannel.cpp
M mythtv/libs/libmythtv/recorders/asisignalmonitor.cpp
M mythtv/libs/libmythtv/recorders/cetonchannel.cpp
M mythtv/libs/libmythtv/recorders/cetonsignalmonitor.cpp
M mythtv/libs/libmythtv/recorders/channelbase.cpp
M mythtv/libs/libmythtv/recorders/dtvrecorder.cpp
M mythtv/libs/libmythtv/recorders/dtvsignalmonitor.cpp
M mythtv/libs/libmythtv/recorders/dvbcam.cpp
M mythtv/libs/libmythtv/recorders/dvbchannel.cpp
M mythtv/libs/libmythtv/recorders/dvbsignalmonitor.cpp
M mythtv/libs/libmythtv/recorders/firewirechannel.cpp
M mythtv/libs/libmythtv/recorders/firewiresignalmonitor.cpp
M mythtv/libs/libmythtv/recorders/hdhrchannel.cpp
M mythtv/libs/libmythtv/recorders/hdhrsignalmonitor.cpp
M mythtv/libs/libmythtv/recorders/hdhrstreamhandler.cpp
M mythtv/libs/libmythtv/recorders/iptvchannel.cpp
M mythtv/libs/libmythtv/recorders/iptvsignalmonitor.cpp
M mythtv/libs/libmythtv/recorders/linuxavcinfo.cpp
M mythtv/libs/libmythtv/recorders/linuxfirewiredevice.cpp
M mythtv/libs/libmythtv/recorders/mpegrecorder.cpp
M mythtv/libs/libmythtv/recorders/recorderbase.cpp
M mythtv/libs/libmythtv/recorders/recorderbase.h
M mythtv/libs/libmythtv/recorders/signalmonitor.cpp
M mythtv/libs/libmythtv/recorders/streamhandler.cpp
M mythtv/libs/libmythtv/recorders/v4l2encsignalmonitor.cpp
M mythtv/libs/libmythtv/recorders/v4l2encstreamhandler.cpp
M mythtv/libs/libmythtv/recorders/v4lchannel.cpp
M mythtv/libs/libmythtv/recorders/vbitext/vbi.c
M mythtv/libs/libmythtv/recordinginfo.h
M mythtv/libs/libmythtv/recordingprofile.cpp
M mythtv/libs/libmythtv/remoteencoder.cpp
M mythtv/libs/libmythtv/streamingringbuffer.cpp
M mythtv/libs/libmythtv/subtitlescreen.cpp
M mythtv/libs/libmythtv/teletextscreen.cpp
M mythtv/libs/libmythtv/teletextscreen.h
M mythtv/libs/libmythtv/test/test_mpegtables/test_mpegtables.cpp
M mythtv/libs/libmythtv/transporteditor.cpp
M mythtv/libs/libmythtv/tv_play.cpp
M mythtv/libs/libmythtv/tv_rec.cpp
M mythtv/libs/libmythtv/tvbrowsehelper.cpp
M mythtv/libs/libmythtv/tvremoteutil.cpp
M mythtv/libs/libmythtv/videobuffers.cpp
M mythtv/libs/libmythtv/videoout_nullvdpau.cpp
M mythtv/libs/libmythtv/videoout_opengl.cpp
M mythtv/libs/libmythtv/videoout_openglvaapi.cpp
M mythtv/libs/libmythtv/videoout_vdpau.cpp
M mythtv/libs/libmythtv/videoout_xv.cpp
M mythtv/libs/libmythtv/videooutbase.cpp
M mythtv/libs/libmythtv/videosource.cpp
M mythtv/libs/libmythtv/visualisations/goom/goom_tools.h
M mythtv/libs/libmythtv/visualisations/goom/mathtools.h
M mythtv/libs/libmythtv/visualisations/goom/tentacle3d.c
M mythtv/libs/libmythtv/visualisations/goom/v3d.h
M mythtv/libs/libmythtv/visualisations/videovisualcircles.cpp
M mythtv/libs/libmythtv/visualisations/videovisualspectrum.cpp
M mythtv/libs/libmythui/DisplayRes.cpp
M mythtv/libs/libmythui/DisplayResScreen.cpp
M mythtv/libs/libmythui/DisplayResX.cpp
M mythtv/libs/libmythui/cecadapter.cpp
M mythtv/libs/libmythui/mythdialogbox.cpp
M mythtv/libs/libmythui/mythdisplay.cpp
M mythtv/libs/libmythui/mythpainter_ogl.cpp
M mythtv/libs/libmythui/mythpainter_vdpau.cpp
M mythtv/libs/libmythui/mythrender_opengl.cpp
M mythtv/libs/libmythui/mythrender_opengl1.cpp
M mythtv/libs/libmythui/mythrender_opengl2.cpp
M mythtv/libs/libmythui/mythscreenstack.cpp
M mythtv/libs/libmythui/mythuifilebrowser.cpp
M mythtv/libs/libmythui/mythuitext.cpp
M mythtv/libs/libmythui/mythuiwebbrowser.cpp
M mythtv/libs/libmythui/screensaver-x11.cpp
M mythtv/libs/libmythui/x11colors.cpp
M mythtv/libs/libmythupnp/configuration.cpp
M mythtv/libs/libmythupnp/msocketdevice.cpp
M mythtv/libs/libmythupnp/msocketdevice.h
M mythtv/libs/libmythupnp/ssdp.cpp
M mythtv/libs/libmythupnp/upnpdevice.cpp
M mythtv/libs/libmythupnp/upnpdevice.h
M mythtv/programs/mythavtest/commandlineparser.cpp
M mythtv/programs/mythbackend/backendcontext.cpp
M mythtv/programs/mythbackend/backendcontext.h
M mythtv/programs/mythbackend/commandlineparser.cpp
M mythtv/programs/mythbackend/encoderlink.cpp
M mythtv/programs/mythbackend/main.cpp
M mythtv/programs/mythbackend/main_helpers.cpp
M mythtv/programs/mythbackend/mainserver.cpp
M mythtv/programs/mythbackend/mediaserver.cpp
M mythtv/programs/mythbackend/mediaserver.h
M mythtv/programs/mythbackend/scheduler.cpp
M mythtv/programs/mythbackend/services/dvr.cpp
M mythtv/programs/mythccextractor/commandlineparser.cpp
M mythtv/programs/mythcommflag/BorderDetector.cpp
M mythtv/programs/mythcommflag/HistogramAnalyzer.cpp
M mythtv/programs/mythcommflag/SceneChangeDetector.cpp
M mythtv/programs/mythcommflag/commandlineparser.cpp
M mythtv/programs/mythcommflag/main.cpp
M mythtv/programs/mythexternrecorder/commandlineparser.cpp
M mythtv/programs/mythfilerecorder/commandlineparser.cpp
M mythtv/programs/mythfilerecorder/mythfilerecorder.cpp
M mythtv/programs/mythfilldatabase/commandlineparser.cpp
M mythtv/programs/mythfrontend/audiogeneralsettings.cpp
M mythtv/programs/mythfrontend/commandlineparser.cpp
M mythtv/programs/mythfrontend/customedit.cpp
M mythtv/programs/mythfrontend/editvideometadata.cpp
M mythtv/programs/mythfrontend/exitprompt.cpp
M mythtv/programs/mythfrontend/galleryslide.h
M mythtv/programs/mythfrontend/globalsettings.cpp
M mythtv/programs/mythfrontend/guidegrid.cpp
M mythtv/programs/mythfrontend/manualschedule.cpp
M mythtv/programs/mythfrontend/playbackbox.cpp
M mythtv/programs/mythfrontend/prevreclist.cpp
M mythtv/programs/mythfrontend/progfind.cpp
M mythtv/programs/mythfrontend/proglist.cpp
M mythtv/programs/mythfrontend/proglist_helpers.cpp
M mythtv/programs/mythfrontend/scheduleeditor.cpp
M mythtv/programs/mythfrontend/statusbox.cpp
M mythtv/programs/mythfrontend/videodlg.cpp
M mythtv/programs/mythfrontend/videofileassoc.cpp
M mythtv/programs/mythfrontend/viewschedulediff.cpp
M mythtv/programs/mythjobqueue/commandlineparser.cpp
M mythtv/programs/mythlcdserver/commandlineparser.cpp
M mythtv/programs/mythlcdserver/lcdprocclient.cpp
M mythtv/programs/mythlcdserver/main.cpp
M mythtv/programs/mythmediaserver/commandlineparser.cpp
M mythtv/programs/mythmetadatalookup/commandlineparser.cpp
M mythtv/programs/mythpreviewgen/commandlineparser.cpp
M mythtv/programs/mythpreviewgen/main.cpp
M mythtv/programs/mythscreenwizard/commandlineparser.cpp
M mythtv/programs/mythshutdown/commandlineparser.cpp
M mythtv/programs/mythshutdown/main.cpp
M mythtv/programs/mythtranscode/audioreencodebuffer.cpp
M mythtv/programs/mythtranscode/commandlineparser.cpp
M mythtv/programs/mythtranscode/main.cpp
M mythtv/programs/mythtranscode/transcode.cpp
M mythtv/programs/mythtv-setup/commandlineparser.cpp
M mythtv/programs/mythtv-setup/exitprompt.cpp
M mythtv/programs/mythtv-setup/main.cpp
M mythtv/programs/mythtv-setup/startprompt.cpp
M mythtv/programs/mythutil/commandlineparser.cpp
M mythtv/programs/mythutil/mpegutils.cpp
M mythtv/programs/mythwelcome/commandlineparser.cpp

Log Message:
-----------
Merge clang-tidy cleanups. (set 3)


Compare: https://github.com/MythTV/mythtv/compare/987699ac2dd8...62adc17c7236
_______________________________________________
mythtv-commits mailing list
mythtv-commits@mythtv.org
http://lists.mythtv.org/mailman/listinfo/mythtv-commits