Mailing List Archive

1 2  View All
Re: Ticket #13400: Video playback wrong aspect ratio [ In reply to ]
#13400: Video playback wrong aspect ratio
-------------------------------------+-------------------------------
Reporter: Klaas de Waal | Owner: Peter Bennett
Type: Bug Report - General | Status: new
Priority: minor | Milestone: 31.0
Component: MythTV - Video Playback | Version: Master Head
Severity: medium | Resolution:
Keywords: video playback gui qt | Ticket locked: 0
-------------------------------------+-------------------------------
Changes (by Peter Bennett):

* status: closed => new
* resolution: Invalid =>


Old description:

> Video playback with mythfrontend now has the wrong aspect ratio. Also the
> on-screen "Paused" display has disappeared.\\
>
> A version of mythtv master compiled two days ago is correct; a version
> compiled today is wrong.\\
>
> Attached are two screenshots of the same recording with the different
> frontends, both paused at approximately the same moment.\\
>
> Version of the old/correct mythfrontend:
>
> {{{
> [klaas@modu mma-dvbt]$ mythfrontend --version
> Please attach all output as a file in bug reports.
> MythTV Version : v31-Pre-47-g4543b46083-dirty
> MythTV Branch : master
> Network Protocol : 91
> Library API : 31.20190109-1
> QT Version : 5.11.3
> Options compiled in:
> linux profile use_hidesyms using_alsa using_oss using_pulse
> using_pulseoutput using_backend using_bindings_perl using_bindings_python
> using_bindings_php using_crystalhd using_dvb using_firewire
> using_frontend using_hdhomerun using_vbox using_ceton using_hdpvr
> using_ivtv using_joystick_menu using_libcec using_libcrypto
> using_libdns_sd using_libfftw3 using_libxml2 using_lirc using_mheg
> using_opengl using_opengl_video using_opengl_themepainter using_qtwebkit
> using_qtscript using_qtdbus using_taglib using_v4l2 using_x11
> using_xnvctrl using_xnvctrl_external using_libbluray_external
> using_xrandr using_xv using_profiletype using_systemd_notify
> using_systemd_journal using_bindings_perl using_bindings_python
> using_bindings_php using_freetype2 using_mythtranscode using_opengl
> using_vaapi using_vaapi2 using_nvdec using_vdpau using_ffmpeg_threads
> using_mheg using_libass using_libxml2
> [klaas@modu mma-dvbt]$
>
> }}}
>
> Version of new/wrong mythfrontend:
>

> {{{
> [klaas@modu mma]$ mythfrontend --version
> Please attach all output as a file in bug reports.
> MythTV Version : v31-Pre-56-gfa86a6a293
> MythTV Branch : master
> Network Protocol : 91
> Library API : 31.20190109-1
> QT Version : 5.11.3
> Options compiled in:
> linux profile use_hidesyms using_alsa using_oss using_pulse
> using_pulseoutput using_backend using_bindings_perl using_bindings_python
> using_bindings_php using_crystalhd using_dvb using_firewire
> using_frontend using_hdhomerun using_vbox using_ceton using_hdpvr
> using_ivtv using_joystick_menu using_libcec using_libcrypto
> using_libdns_sd using_libfftw3 using_libxml2 using_lirc using_mheg
> using_opengl using_opengl_video using_opengl_themepainter using_qtwebkit
> using_qtscript using_qtdbus using_taglib using_v4l2 using_x11
> using_xnvctrl using_xnvctrl_external using_libbluray_external
> using_xrandr using_xv using_profiletype using_systemd_notify
> using_systemd_journal using_bindings_perl using_bindings_python
> using_bindings_php using_freetype2 using_mythtranscode using_opengl
> using_vaapi using_vaapi2 using_nvdec using_vdpau using_ffmpeg_threads
> using_mheg using_libass using_libxml2
> [klaas@modu mma]$
>
> }}}
>
> The mythfrontend log files are also attached.\\
>
> Linux system is Fedora 29, no video hardware.\\
>
> This problem could have been introduced with the GUI-related commits of
> Feb 4, 2019 by linuxdude42.\\

New description:

Aspect ratio is calculated incorrectly on systems with two monitors.

Prior description -
Video playback with mythfrontend now has the wrong aspect ratio. Also the
on-screen "Paused" display has disappeared.\\

~~A version of mythtv master compiled two days ago is correct; a version
compiled today is wrong.~~

Attached are two screenshots of the same recording with the different
frontends, both paused at approximately the same moment.\\

Version of the old/correct mythfrontend:

{{{
[klaas@modu mma-dvbt]$ mythfrontend --version
Please attach all output as a file in bug reports.
MythTV Version : v31-Pre-47-g4543b46083-dirty
MythTV Branch : master
Network Protocol : 91
Library API : 31.20190109-1
QT Version : 5.11.3
Options compiled in:
linux profile use_hidesyms using_alsa using_oss using_pulse
using_pulseoutput using_backend using_bindings_perl using_bindings_python
using_bindings_php using_crystalhd using_dvb using_firewire using_frontend
using_hdhomerun using_vbox using_ceton using_hdpvr using_ivtv
using_joystick_menu using_libcec using_libcrypto using_libdns_sd
using_libfftw3 using_libxml2 using_lirc using_mheg using_opengl
using_opengl_video using_opengl_themepainter using_qtwebkit using_qtscript
using_qtdbus using_taglib using_v4l2 using_x11 using_xnvctrl
using_xnvctrl_external using_libbluray_external using_xrandr using_xv
using_profiletype using_systemd_notify using_systemd_journal
using_bindings_perl using_bindings_python using_bindings_php
using_freetype2 using_mythtranscode using_opengl using_vaapi using_vaapi2
using_nvdec using_vdpau using_ffmpeg_threads using_mheg using_libass
using_libxml2
[klaas@modu mma-dvbt]$

}}}

Version of new/wrong mythfrontend:


{{{
[klaas@modu mma]$ mythfrontend --version
Please attach all output as a file in bug reports.
MythTV Version : v31-Pre-56-gfa86a6a293
MythTV Branch : master
Network Protocol : 91
Library API : 31.20190109-1
QT Version : 5.11.3
Options compiled in:
linux profile use_hidesyms using_alsa using_oss using_pulse
using_pulseoutput using_backend using_bindings_perl using_bindings_python
using_bindings_php using_crystalhd using_dvb using_firewire using_frontend
using_hdhomerun using_vbox using_ceton using_hdpvr using_ivtv
using_joystick_menu using_libcec using_libcrypto using_libdns_sd
using_libfftw3 using_libxml2 using_lirc using_mheg using_opengl
using_opengl_video using_opengl_themepainter using_qtwebkit using_qtscript
using_qtdbus using_taglib using_v4l2 using_x11 using_xnvctrl
using_xnvctrl_external using_libbluray_external using_xrandr using_xv
using_profiletype using_systemd_notify using_systemd_journal
using_bindings_perl using_bindings_python using_bindings_php
using_freetype2 using_mythtranscode using_opengl using_vaapi using_vaapi2
using_nvdec using_vdpau using_ffmpeg_threads using_mheg using_libass
using_libxml2
[klaas@modu mma]$

}}}

The mythfrontend log files are also attached.\\

Linux system is Fedora 29, no video hardware.\\

This problem could have been introduced with the GUI-related commits of
Feb 4, 2019 by linuxdude42.\\

--

Comment:

Re-opened for consideration of the patch

--
Ticket URL: <https://code.mythtv.org/trac/ticket/13400#comment:16>
MythTV <http://www.mythtv.org>
MythTV Media Center
Re: Ticket #13400: Video playback wrong aspect ratio [ In reply to ]
#13400: Video playback wrong aspect ratio
-------------------------------------+-------------------------------
Reporter: Klaas de Waal | Owner: Peter Bennett
Type: Bug Report - General | Status: new
Priority: minor | Milestone: 31.0
Component: MythTV - Video Playback | Version: Master Head
Severity: medium | Resolution:
Keywords: video playback gui qt | Ticket locked: 0
-------------------------------------+-------------------------------

Comment (by Stuart Auchterlonie):

Replying to [comment:11 Peter Bennett]:

> Set up a unique user id for Mythfrontend.
> Log on with that user and use display setup to disable one monitor.
> Every time you logon with that user you get one screen, when logging on
with a different user id you can use both screens.

Realistically this isn't the best approach. My dev frontend systems have 2
monitors
connected, which allows a nice testing setup (ie. debuggers, code etc on
one screen,
and the frontend on the other screen), or watching stuff you need to catch
up on whilst
doing some other stuff at the same time.

--
Ticket URL: <https://code.mythtv.org/trac/ticket/13400#comment:17>
MythTV <http://www.mythtv.org>
MythTV Media Center
Re: Ticket #13400: Video playback wrong aspect ratio [ In reply to ]
#13400: Video playback wrong aspect ratio
-------------------------------------+-------------------------------
Reporter: Klaas de Waal | Owner: Peter Bennett
Type: Bug Report - General | Status: new
Priority: minor | Milestone: 31.0
Component: MythTV - Video Playback | Version: Master Head
Severity: medium | Resolution:
Keywords: video playback gui qt | Ticket locked: 0
-------------------------------------+-------------------------------

Comment (by jpilk):

I have applied the patch from Comment 15 in a build for Fedora 28 of
today's master, c6a7cf187, and tested with normal playback and that of
recorded BBC SD and HD testcards. The pictures now exactly fill the
window-on-monitor or TV-screen, as they did before the commit that
prompted this ticket. I haven't yet tried it on a single-screen system...

My mode of operation with two screens is described is this post:

http://lists.mythtv.org/pipermail/mythtv-users/2019-March/399749.html

--
Ticket URL: <https://code.mythtv.org/trac/ticket/13400#comment:18>
MythTV <http://www.mythtv.org>
MythTV Media Center
Re: Ticket #13400: Video playback wrong aspect ratio [ In reply to ]
#13400: Video playback wrong aspect ratio
-------------------------------------+-------------------------------
Reporter: Klaas de Waal | Owner: Peter Bennett
Type: Bug Report - General | Status: new
Priority: minor | Milestone: 31.0
Component: MythTV - Video Playback | Version: Master Head
Severity: medium | Resolution:
Keywords: video playback gui qt | Ticket locked: 0
-------------------------------------+-------------------------------

Comment (by jpilk):

No problem seen with my normal windowed playback on a single screen with
old intel graphics

00:02.0 VGA compatible controller: Intel Corporation 82Q33 Express
Integrated Graphics Controller (rev 02)

xorg-x11-drv-intel-2.99.917-28.20180530.el7.x86_64

and MythTV built from the same sources as in Comment 18

--
Ticket URL: <https://code.mythtv.org/trac/ticket/13400#comment:19>
MythTV <http://www.mythtv.org>
MythTV Media Center
Re: Ticket #13400: Video playback wrong aspect ratio [ In reply to ]
#13400: Video playback wrong aspect ratio
-------------------------------------+-------------------------------
Reporter: Klaas de Waal | Owner: Klaas de Waal
Type: Bug Report - General | Status: assigned
Priority: minor | Milestone: 31.0
Component: MythTV - Video Playback | Version: Master Head
Severity: medium | Resolution:
Keywords: video playback gui qt | Ticket locked: 0
-------------------------------------+-------------------------------
Changes (by Peter Bennett):

* owner: Peter Bennett => Klaas de Waal
* status: new => assigned


--
Ticket URL: <https://code.mythtv.org/trac/ticket/13400#comment:20>
MythTV <http://www.mythtv.org>
MythTV Media Center
Re: Ticket #13400: Video playback wrong aspect ratio [ In reply to ]
#13400: Video playback wrong aspect ratio
-------------------------------------+-------------------------------
Reporter: Klaas de Waal | Owner: Klaas de Waal
Type: Bug Report - General | Status: assigned
Priority: minor | Milestone: 31.0
Component: MythTV - Video Playback | Version: Master Head
Severity: medium | Resolution:
Keywords: video playback gui qt | Ticket locked: 0
-------------------------------------+-------------------------------
Changes (by Klaas de Waal):

* Attachment "20190306-video-aspect.patch" added.

Functionally the same as the 20190206 patch but looks better.

--
Ticket URL: <https://code.mythtv.org/trac/ticket/13400>
MythTV <http://www.mythtv.org>
MythTV Media Center
Re: Ticket #13400: Video playback wrong aspect ratio [ In reply to ]
#13400: Video playback wrong aspect ratio
-------------------------------------+-------------------------------
Reporter: Klaas de Waal | Owner: Klaas de Waal
Type: Bug Report - General | Status: closed
Priority: minor | Milestone: 31.0
Component: MythTV - Video Playback | Version: Master Head
Severity: medium | Resolution: fixed
Keywords: video playback gui qt | Ticket locked: 0
-------------------------------------+-------------------------------
Changes (by Klaas de Waal <kdewaal@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"5de99ad3d7172dc496d63eea579fef8b33a1080f/mythtv"
5de99ad3d7/mythtv]:
{{{
#!CommitTicketReference repository="mythtv"
revision="5de99ad3d7172dc496d63eea579fef8b33a1080f"
Video aspect ratio wrong on systems with multiple monitors

On a system with two monitors, positioned horizontally next to each other,
the vertical size of the video in a window is correct but the horizontal
size
is about half what it should be.
The same is true for full-screen video, without an enclosing window.

This problem is most likely introduced in commit b2c82a3, dated Feb 1,
"Convert from QDesktopWindow to QScreen".

Before this commit a system with multiple monitors was treaded as
"Xinerama".
After this commit a system with mulitple monitors is seen as one big
screen
with an area which is the bounding box of the screens of all monitors.
The name display as used in the code now refers to the big "bounding box"
screen.

The video aspect ratio computations use the size of the display in mm.
The bug was here that the display size in mm was used in conjunction
with the size in pixels of the first screen.
In order to scale correct the size in pixels of the display has to be
used.

Note: the change from QDesktopWidget to QScreen is a Good Thing because
the QDesktopWidget is declared obsolete.
Note: with this fix included the video scaling in a multiple monitor
system is now exact which is better than before, in the "Xinerama" mode.

Fixes #13400
}}}

--
Ticket URL: <https://code.mythtv.org/trac/ticket/13400#comment:21>
MythTV <http://www.mythtv.org>
MythTV Media Center

1 2  View All