Mailing List Archive

Ticket #13363: (Very) Minor improvements to StringList protocol encoding debug
#13363: (Very) Minor improvements to StringList protocol encoding debug
----------------------------------+--------------------------
Reporter: ijc | Owner: (none)
Type: Patch - Feature | Status: new
Priority: minor | Milestone: needs_triage
Component: MythTV - General | Version: Master Head
Severity: medium | Keywords:
Ticket locked: 0 |
----------------------------------+--------------------------
Two incredibly small tweaks made during my debug of #13315...

* Don't unnecessarily construct the `QByteArray payload` in
`ReadStringListReal()`, it is only used for the debug log so move the
construction inside the condition.
* Increase the length of the log of the encoded `QStringList` in
`WriteStringListReal` and `ReadStringListReal` to 127 (from 85) in the
non-debug case. I found 85 wasn't quite enough to see what was going on
for some commands when using real world path lengths in the command
arguments. (127 is entirely arbitrary, I had been using 255 in my local
debug but that seemed quite a lot so I settled in 127 for this
submission...)

--
Ticket URL: <https://code.mythtv.org/trac/ticket/13363>
MythTV <http://www.mythtv.org>
MythTV Media Center
Re: Ticket #13363: (Very) Minor improvements to StringList protocol encoding debug [ In reply to ]
#13363: (Very) Minor improvements to StringList protocol encoding debug
------------------------------+------------------------------
Reporter: ijc | Owner: (none)
Type: Patch - Feature | Status: new
Priority: minor | Milestone: needs_triage
Component: MythTV - General | Version: Master Head
Severity: medium | Resolution:
Keywords: | Ticket locked: 0
------------------------------+------------------------------
Changes (by ijc):

* Attachment "0001-ReadStringListReal-move-construction-of-
QByteArray-u.patch" added.


--
Ticket URL: <https://code.mythtv.org/trac/ticket/13363>
MythTV <http://www.mythtv.org>
MythTV Media Center
Re: Ticket #13363: (Very) Minor improvements to StringList protocol encoding debug [ In reply to ]
#13363: (Very) Minor improvements to StringList protocol encoding debug
------------------------------+------------------------------
Reporter: ijc | Owner: (none)
Type: Patch - Feature | Status: new
Priority: minor | Milestone: needs_triage
Component: MythTV - General | Version: Master Head
Severity: medium | Resolution:
Keywords: | Ticket locked: 0
------------------------------+------------------------------
Changes (by ijc):

* Attachment "0002-Read-WriteStringList-Increase-length-of-debug-
output.patch" added.


--
Ticket URL: <https://code.mythtv.org/trac/ticket/13363>
MythTV <http://www.mythtv.org>
MythTV Media Center
Re: Ticket #13363: (Very) Minor improvements to StringList protocol encoding debug [ In reply to ]
#13363: (Very) Minor improvements to StringList protocol encoding debug
------------------------------+-------------------------------
Reporter: ijc | Owner: David Hampton
Type: Patch - Feature | Status: assigned
Priority: minor | Milestone: needs_triage
Component: MythTV - General | Version: Master Head
Severity: medium | Resolution:
Keywords: | Ticket locked: 0
------------------------------+-------------------------------
Changes (by David Hampton):

* owner: (none) => David Hampton
* status: new => assigned


--
Ticket URL: <https://code.mythtv.org/trac/ticket/13363#comment:1>
MythTV <http://www.mythtv.org>
MythTV Media Center
Re: Ticket #13363: (Very) Minor improvements to StringList protocol encoding debug [ In reply to ]
#13363: (Very) Minor improvements to StringList protocol encoding debug
------------------------------+-------------------------------
Reporter: ijc | Owner: David Hampton
Type: Patch - Feature | Status: assigned
Priority: minor | Milestone: 30.1
Component: MythTV - General | Version: Master Head
Severity: medium | Resolution:
Keywords: | Ticket locked: 0
------------------------------+-------------------------------
Changes (by David Hampton):

* milestone: needs_triage => 30.1


--
Ticket URL: <https://code.mythtv.org/trac/ticket/13363#comment:2>
MythTV <http://www.mythtv.org>
MythTV Media Center
Re: Ticket #13363: (Very) Minor improvements to StringList protocol encoding debug [ In reply to ]
#13363: (Very) Minor improvements to StringList protocol encoding debug
------------------------------+-------------------------------
Reporter: ijc | Owner: David Hampton
Type: Patch - Feature | Status: assigned
Priority: minor | Milestone: 31.0
Component: MythTV - General | Version: Master Head
Severity: medium | Resolution:
Keywords: | Ticket locked: 0
------------------------------+-------------------------------
Changes (by David Hampton):

* milestone: 30.1 => 31.0


--
Ticket URL: <https://code.mythtv.org/trac/ticket/13363#comment:3>
MythTV <http://www.mythtv.org>
MythTV Media Center
Re: Ticket #13363: (Very) Minor improvements to StringList protocol encoding debug [ In reply to ]
#13363: (Very) Minor improvements to StringList protocol encoding debug
------------------------------+-------------------------------
Reporter: ijc | Owner: David Hampton
Type: Patch - Feature | Status: closed
Priority: minor | Milestone: 31.0
Component: MythTV - General | Version: Master Head
Severity: medium | Resolution: fixed
Keywords: | Ticket locked: 0
------------------------------+-------------------------------
Changes (by Ian Campbell <ijc@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"72f71a7e109eb388decd67f86bfefdf32c065cbc/mythtv"
72f71a7e1/mythtv]:
{{{
#!CommitTicketReference repository="mythtv"
revision="72f71a7e109eb388decd67f86bfefdf32c065cbc"
Minor improvements to StringList protocol encoding debug.

Fixes #13363.

Signed-off-by: David Hampton <mythtv@love2code.net>
}}}

--
Ticket URL: <https://code.mythtv.org/trac/ticket/13363#comment:4>
MythTV <http://www.mythtv.org>
MythTV Media Center