Mailing List Archive: Ticket #4047: channel_icons.pl uses $Myth->load_channels(); iso $Myth->_load

Ticket #4047: channel_icons.pl uses $Myth->load_channels(); iso $Myth->_load_channels();

Oct 3, 2007, 9:56 PM

Post #1 of 3 (817 views)

#4047: channel_icons.pl uses $Myth->load_channels(); iso $Myth->_load_channels();
-------------------------+--------------------------------------------------
Reporter: anonymous | Owner: danielk
Type: defect | Status: new
Priority: minor | Milestone: unknown
Component: channelscan | Version: 0.20.2
Severity: medium | Mlocked: 0
-------------------------+--------------------------------------------------
In line 94 of channel_icons.pl $Myth->load_channels(); is used.
This creates an error message:
Can't locate object method "load_channels" via package "MythTV" at
channel_icons.pl line 94.

In none of the perl libraries/programs which comes with mythtv
load_channels is used. The function which is available in Myth.pm is
called _load_channels. If _load_channels is renamed to load_channels it's
working but might break other code.

Please decide which name is correct.

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/4047>
MythTV <http://svn.mythtv.org/trac>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits

Re: Ticket #4047: channel_icons.pl uses $Myth->load_channels(); iso $Myth->_load_channels(); [ In reply to ]

mythtv at cvs

Oct 9, 2007, 2:37 PM

Post #2 of 3 (735 views)

Permalink

#4047: channel_icons.pl uses $Myth->load_channels(); iso $Myth->_load_channels();
-------------------------+--------------------------------------------------
Reporter: anonymous | Owner: danielk
Type: defect | Status: closed
Priority: minor | Milestone: unknown
Component: channelscan | Version: 0.20.2
Severity: medium | Resolution: invalid
Mlocked: 0 |
-------------------------+--------------------------------------------------
Changes (by xris):

* status: new => closed
* resolution: => invalid

Comment:

Please don't mix/match MythTV versions. Things are expected to break when
you do that.

P.S. underscore prefix is a common way to denote private/protected object
methods (which perl has no other way to identify). That method was not
intended for public use, and thus it started with an underscore. When I
wrote the channel icon script in trunk, and realized that I needed a
public method to load channels, the method got renamed. Thus, both are
correct. You're using the wrong version of MythTV, and nothing outside of
the perl bindings should have ever been using the underscore version of
the method name.

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/4047#comment:1>
MythTV <http://svn.mythtv.org/trac>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits

Re: Ticket #4047: channel_icons.pl uses $Myth->load_channels(); iso $Myth->_load_channels(); [ In reply to ]

mythtv at cvs

Oct 9, 2007, 2:37 PM

Post #3 of 3 (754 views)

Permalink

#4047: channel_icons.pl uses $Myth->load_channels(); iso $Myth->_load_channels();
------------------------------+---------------------------------------------
Reporter: anonymous | Owner: danielk
Type: defect | Status: closed
Priority: minor | Milestone: unknown
Component: perl / nuvexport | Version: 0.20.2
Severity: medium | Resolution: invalid
Mlocked: 0 |
------------------------------+---------------------------------------------
Changes (by xris):

* component: channelscan => perl / nuvexport

--
Ticket URL: <http://svn.mythtv.org/trac/ticket/4047#comment:2>
MythTV <http://svn.mythtv.org/trac>
MythTV
_______________________________________________
mythtv-commits mailing list
mythtv-commits@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits