Mailing List Archive

You can call me code elf (was: [RELEASE CANDIDATE] Apache-Test-1.34 RC1)
On Thursday, December 16, 2010 01:07:00 Fred Moyer wrote:
> Maybe a code elf will come
> out of the woodwork and magically fix it...

Fixed in revision 1053063.

Apache::Test users, please test this revision with your modules. See

svn log -r 1053063

for a detailed description and

svn diff -c 1053063

for what has changed.

The new test file t/import.t has a set of usage cases.

The new code works with mod_perl and fixes the 0Xtestmore tests in
Apache::Test.

mod_perl is not a good test case here because it does not use the
-withtestmore option. Passing the AT test suite does not mean much either
because it is quite limited. So, please test it and provide test cases if
possible.

A bit late but, Merry Christmas and a Happy New Year,
Torsten Förtsch

--
Need professional modperl support? Hire me! (http://foertsch.name)

Like fantasy? http://kabatinte.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: You can call me code elf (was: [RELEASE CANDIDATE] Apache-Test-1.34 RC1) [ In reply to ]
2010/12/27 Torsten Förtsch <torsten.foertsch@gmx.net>:
> On Thursday, December 16, 2010 01:07:00 Fred Moyer wrote:
>> Maybe a code elf will come
>> out of the woodwork and magically fix it...

:)

> Fixed in revision 1053063.
>
> Apache::Test users, please test this revision with your modules. See
>
>  svn log -r 1053063
>
> for a detailed description and
>
>  svn diff -c 1053063
>
> for what has changed.
>
> The new test file t/import.t has a set of usage cases.

All ok on Darwin/5.12.2, got a failure on Linux/5.8.8/2.2.9

t/import.t ............... 1/47 Use of uninitialized value in open at
/home/phred/dev/perl/lib/5.8.8/Test/Builder.pm line 1599.
# Test 46 got: "1..17\n# Using Apache/Test.pm version 1.34\nok 1 -
hugo is not erwin\n" (t/import.t at line 136)
# Expected: "(?m-xis:^1\\.\\.17$)" (planned)
# t/import.t line 136 is: Test::skip $pio, $output, qr/^1\.\.17$/m, 'planned';
t/import.t ............... Failed 1/47 subtests

Nothing in the error logs noteworthy.


>
> The new code works with mod_perl and fixes the 0Xtestmore tests in
> Apache::Test.
>
> mod_perl is not a good test case here because it does not use the
> -withtestmore option. Passing the AT test suite does not mean much either
> because it is quite limited. So, please test it and provide test cases if
> possible.
>
> A bit late but, Merry Christmas and a Happy New Year,
> Torsten Förtsch
>
> --
> Need professional modperl support? Hire me! (http://foertsch.name)
>
> Like fantasy? http://kabatinte.net
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: You can call me code elf (was: [RELEASE CANDIDATE] Apache-Test-1.34 RC1) [ In reply to ]
On Wednesday, December 29, 2010 04:19:05 Fred Moyer wrote:
> All ok on Darwin/5.12.2, got a failure on Linux/5.8.8/2.2.9
>
> t/import.t ............... 1/47 Use of uninitialized value in open at
> /home/phred/dev/perl/lib/5.8.8/Test/Builder.pm line 1599.
> # Test 46 got: "1..17\n# Using Apache/Test.pm version 1.34\nok 1 -
> hugo is not erwin\n" (t/import.t at line 136)
> # Expected: "(?m-xis:^1\\.\\.17$)" (planned)
> # t/import.t line 136 is: Test::skip $pio, $output, qr/^1\.\.17$/m,
> 'planned'; t/import.t ............... Failed 1/47 subtests

That's the old perl version. Could you please retest revision 1053949 (or
later).

The following command shows the bug:

$ perl -Mstrict -e 'my $re=qr/^a$/m; printf "%vd: %s\n", $^V, "a\nx"=~$re ?
"match" : "no match"'

5.12.1: match
5.8.8: no match

Perl 5.8.8 forgets about the m-flag.

Torsten Förtsch

--
Need professional modperl support? Hire me! (http://foertsch.name)

Like fantasy? http://kabatinte.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org