Mailing List Archive

[jira] [Updated] (LUCENE-4077) ToParentBlockJoinCollector provides no way to access computed scores and the maxScore
[ https://issues.apache.org/jira/browse/LUCENE-4077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael McCandless updated LUCENE-4077:
---------------------------------------

Attachment: LUCENE-4077.patch

Patch.

I added getMaxScore to ToParentBlockJoinCollector, and GroupDocs.score to access the aggregated score for the group. I also added a ScoreMergeMode enum to TopGroups.merge to control how the scores from the same group across multiple shards should be merged.

> ToParentBlockJoinCollector provides no way to access computed scores and the maxScore
> -------------------------------------------------------------------------------------
>
> Key: LUCENE-4077
> URL: https://issues.apache.org/jira/browse/LUCENE-4077
> Project: Lucene - Java
> Issue Type: Bug
> Components: modules/join
> Affects Versions: 3.4, 3.5, 3.6
> Reporter: Christoph Kaser
> Assignee: Michael McCandless
> Attachments: LUCENE-4077.patch
>
>
> The constructor of ToParentBlockJoinCollector allows to turn on the tracking of parent scores and the maximum parent score, however there is no way to access those scores because:
> * maxScore is a private field, and there is no getter
> * TopGroups / GroupDocs does not provide access to the scores for the parent documents, only the children

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-4077) ToParentBlockJoinCollector provides no way to access computed scores and the maxScore [ In reply to ]
[ https://issues.apache.org/jira/browse/LUCENE-4077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael McCandless updated LUCENE-4077:
---------------------------------------

Attachment: LUCENE-4077.patch

Ugh, sorry. Sneaky NaN!

I added an assert in TestBJQ that shows the failure, then fixed it...

> ToParentBlockJoinCollector provides no way to access computed scores and the maxScore
> -------------------------------------------------------------------------------------
>
> Key: LUCENE-4077
> URL: https://issues.apache.org/jira/browse/LUCENE-4077
> Project: Lucene - Java
> Issue Type: Bug
> Components: modules/join
> Affects Versions: 3.4, 3.5, 3.6
> Reporter: Christoph Kaser
> Assignee: Michael McCandless
> Attachments: LUCENE-4077.patch, LUCENE-4077.patch
>
>
> The constructor of ToParentBlockJoinCollector allows to turn on the tracking of parent scores and the maximum parent score, however there is no way to access those scores because:
> * maxScore is a private field, and there is no getter
> * TopGroups / GroupDocs does not provide access to the scores for the parent documents, only the children

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-4077) ToParentBlockJoinCollector provides no way to access computed scores and the maxScore [ In reply to ]
[ https://issues.apache.org/jira/browse/LUCENE-4077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael McCandless updated LUCENE-4077:
---------------------------------------

Attachment: LUCENE-4077.patch

I decided to add the maxScore to TopGroups so it's consistent w/ TopDocs; this way you don't have to ask the collector for the maxScore....

> ToParentBlockJoinCollector provides no way to access computed scores and the maxScore
> -------------------------------------------------------------------------------------
>
> Key: LUCENE-4077
> URL: https://issues.apache.org/jira/browse/LUCENE-4077
> Project: Lucene - Java
> Issue Type: Bug
> Components: modules/join
> Affects Versions: 3.4, 3.5, 3.6
> Reporter: Christoph Kaser
> Assignee: Michael McCandless
> Attachments: LUCENE-4077.patch, LUCENE-4077.patch, LUCENE-4077.patch
>
>
> The constructor of ToParentBlockJoinCollector allows to turn on the tracking of parent scores and the maximum parent score, however there is no way to access those scores because:
> * maxScore is a private field, and there is no getter
> * TopGroups / GroupDocs does not provide access to the scores for the parent documents, only the children

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-4077) ToParentBlockJoinCollector provides no way to access computed scores and the maxScore [ In reply to ]
[ https://issues.apache.org/jira/browse/LUCENE-4077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael McCandless updated LUCENE-4077:
---------------------------------------

Attachment: LUCENE-4077.patch

New patch, using the collector's maxScore in TPBJC.getTopGroups.

> ToParentBlockJoinCollector provides no way to access computed scores and the maxScore
> -------------------------------------------------------------------------------------
>
> Key: LUCENE-4077
> URL: https://issues.apache.org/jira/browse/LUCENE-4077
> Project: Lucene - Java
> Issue Type: Bug
> Components: modules/join
> Affects Versions: 3.4, 3.5, 3.6
> Reporter: Christoph Kaser
> Assignee: Michael McCandless
> Attachments: LUCENE-4077.patch, LUCENE-4077.patch, LUCENE-4077.patch, LUCENE-4077.patch
>
>
> The constructor of ToParentBlockJoinCollector allows to turn on the tracking of parent scores and the maximum parent score, however there is no way to access those scores because:
> * maxScore is a private field, and there is no getter
> * TopGroups / GroupDocs does not provide access to the scores for the parent documents, only the children

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org