Mailing List Archive

[jira] [Commented] (SOLR-2690) Date Math should allow clients to override timezone used for rounding (faceting & queries)
[ https://issues.apache.org/jira/browse/SOLR-2690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13264613#comment-13264613 ]

David Schlotfeldt commented on SOLR-2690:
-----------------------------------------

Sorry I'm not familiar with Solr's SVN layout. What SVN location do I look at? The trunk? A branch?

What files were changed? Are all the changes you made in revision 1329837

> Date Math should allow clients to override timezone used for rounding (faceting & queries)
> ------------------------------------------------------------------------------------------
>
> Key: SOLR-2690
> URL: https://issues.apache.org/jira/browse/SOLR-2690
> Project: Solr
> Issue Type: Improvement
> Reporter: David Schlotfeldt
> Assignee: Hoss Man
> Fix For: 4.0
>
> Attachments: SOLR-2690.patch, SOLR-2690.patch, SOLR-2690.patch, add-tz-parameter.patch, add-tz-parameter.patch, timezone-facet-component.tgz
>
> Original Estimate: 3h
> Remaining Estimate: 3h
>
> Timezone needs to be taken into account when doing date math. Currently it isn't. DateMathParser instances created are always being constructed with UTC. This is a huge issue when it comes to faceting. Depending on your timezone day-light-savings changes the length of a month. A facet gap of +1MONTH is different depending on the timezone and the time of the year.
> I believe the issue is very simple to fix. There are three places in the code DateMathParser is created. All three are configured with the timezone being UTC. If a user could specify the TimeZone to pass into DateMathParser this faceting issue would be resolved.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-2690) Date Math should allow clients to override timezone used for rounding (faceting & queries) [ In reply to ]
[ https://issues.apache.org/jira/browse/SOLR-2690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13265430#comment-13265430 ]

Hoss Man commented on SOLR-2690:
--------------------------------

David: r1329837 was the primary commit yes, but there were some subsequent commits to fix the tests.

you can see all commits related to this issue (and all files modified by those ccommits) by clicking the "All" sub-tab under "Activity" (above the list of comments)

https://wiki.apache.org/solr/HowToContribute#JIRA_tips_.28our_issue.2BAC8-bug_tracker.29

> Date Math should allow clients to override timezone used for rounding (faceting & queries)
> ------------------------------------------------------------------------------------------
>
> Key: SOLR-2690
> URL: https://issues.apache.org/jira/browse/SOLR-2690
> Project: Solr
> Issue Type: Improvement
> Reporter: David Schlotfeldt
> Assignee: Hoss Man
> Fix For: 4.0
>
> Attachments: SOLR-2690.patch, SOLR-2690.patch, SOLR-2690.patch, add-tz-parameter.patch, add-tz-parameter.patch, timezone-facet-component.tgz
>
> Original Estimate: 3h
> Remaining Estimate: 3h
>
> Timezone needs to be taken into account when doing date math. Currently it isn't. DateMathParser instances created are always being constructed with UTC. This is a huge issue when it comes to faceting. Depending on your timezone day-light-savings changes the length of a month. A facet gap of +1MONTH is different depending on the timezone and the time of the year.
> I believe the issue is very simple to fix. There are three places in the code DateMathParser is created. All three are configured with the timezone being UTC. If a user could specify the TimeZone to pass into DateMathParser this faceting issue would be resolved.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org