Mailing List Archive

[PATCH]Three corrections of slapd
Hi

1.slapd-001.patch
When there is not PID file, I add the error log output.
2.slapd-002.patch
Bug correction of the while sentence.
3.slapd-003.patch
Spelling miscorrection of the return code.

Regards,
Tomo
Re: [PATCH]Three corrections of slapd [ In reply to ]
Hi,

On Fri, Dec 02, 2011 at 11:59:22AM +0900, nozawat wrote:
> Hi
>
> 1.slapd-001.patch
> When there is not PID file, I add the error log output.

It could happen that slapd takes longer to start. I don't think
it would make sense to log error in that case.

> 2.slapd-002.patch
> Bug correction of the while sentence.

Applied.

> 3.slapd-003.patch
> Spelling miscorrection of the return code.

Applied. Good catch.

Cheers,

Dejan

> Regards,
> Tomo




> _______________________________________________________
> Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> Home Page: http://linux-ha.org/

_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/
Re: [PATCH]Three corrections of slapd [ In reply to ]
Hi Dejan

>> 1.slapd-001.patch
>> When there is not PID file, I add the error log output.
>
> It could happen that slapd takes longer to start. I don't think
> it would make sense to log error in that case.
This patch is not start processing, It is a patch of the monitor processing.
When PID file did not exist by monitor processing, I thought that it
was proper to output error-log.

Regards,
Tomo

2011/12/2 Dejan Muhamedagic <dejan@suse.de>:
> Hi,
>
> On Fri, Dec 02, 2011 at 11:59:22AM +0900, nozawat wrote:
>> Hi
>>
>> 1.slapd-001.patch
>>   When there is not PID file, I add the error log output.
>
> It could happen that slapd takes longer to start. I don't think
> it would make sense to log error in that case.
>
>> 2.slapd-002.patch
>>   Bug correction of the while sentence.
>
> Applied.
>
>> 3.slapd-003.patch
>>   Spelling miscorrection of the return code.
>
> Applied. Good catch.
>
> Cheers,
>
> Dejan
>
>> Regards,
>> Tomo
>
>
>
>
>> _______________________________________________________
>> Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
>> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
>> Home Page: http://linux-ha.org/
>
> _______________________________________________________
> Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> Home Page: http://linux-ha.org/
_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/
Re: [PATCH]Three corrections of slapd [ In reply to ]
Hi Tomo,

On Mon, Dec 05, 2011 at 10:09:24AM +0900, nozawat wrote:
> Hi Dejan
>
> >> 1.slapd-001.patch
> >> When there is not PID file, I add the error log output.
> >
> > It could happen that slapd takes longer to start. I don't think
> > it would make sense to log error in that case.
> This patch is not start processing, It is a patch of the monitor processing.
> When PID file did not exist by monitor processing, I thought that it
> was proper to output error-log.

Oops, I misread the code :-) I'll apply this patch too.

Cheers,

Dejan

> Regards,
> Tomo
>
> 2011/12/2 Dejan Muhamedagic <dejan@suse.de>:
> > Hi,
> >
> > On Fri, Dec 02, 2011 at 11:59:22AM +0900, nozawat wrote:
> >> Hi
> >>
> >> 1.slapd-001.patch
> >>   When there is not PID file, I add the error log output.
> >
> > It could happen that slapd takes longer to start. I don't think
> > it would make sense to log error in that case.
> >
> >> 2.slapd-002.patch
> >>   Bug correction of the while sentence.
> >
> > Applied.
> >
> >> 3.slapd-003.patch
> >>   Spelling miscorrection of the return code.
> >
> > Applied. Good catch.
> >
> > Cheers,
> >
> > Dejan
> >
> >> Regards,
> >> Tomo
> >
> >
> >
> >
> >> _______________________________________________________
> >> Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
> >> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> >> Home Page: http://linux-ha.org/
> >
> > _______________________________________________________
> > Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
> > http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> > Home Page: http://linux-ha.org/
> _______________________________________________________
> Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> Home Page: http://linux-ha.org/
_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/
Re: [PATCH]Three corrections of slapd [ In reply to ]
Hi Dejan

> Oops, I misread the code :-) I'll apply this patch too.
Thanks! I wait to be applied.

Regards,
Tomo

2011/12/5 Dejan Muhamedagic <dejan@suse.de>:
> Hi Tomo,
>
> On Mon, Dec 05, 2011 at 10:09:24AM +0900, nozawat wrote:
>> Hi Dejan
>>
>> >> 1.slapd-001.patch
>> >>   When there is not PID file, I add the error log output.
>> >
>> > It could happen that slapd takes longer to start. I don't think
>> > it would make sense to log error in that case.
>> This patch is not start processing, It is a patch of the monitor processing.
>> When PID file did not exist by monitor processing, I thought that it
>> was proper to output error-log.
>
> Oops, I misread the code :-) I'll apply this patch too.
>
> Cheers,
>
> Dejan
>
>> Regards,
>> Tomo
>>
>> 2011/12/2 Dejan Muhamedagic <dejan@suse.de>:
>> > Hi,
>> >
>> > On Fri, Dec 02, 2011 at 11:59:22AM +0900, nozawat wrote:
>> >> Hi
>> >>
>> >> 1.slapd-001.patch
>> >>   When there is not PID file, I add the error log output.
>> >
>> > It could happen that slapd takes longer to start. I don't think
>> > it would make sense to log error in that case.
>> >
>> >> 2.slapd-002.patch
>> >>   Bug correction of the while sentence.
>> >
>> > Applied.
>> >
>> >> 3.slapd-003.patch
>> >>   Spelling miscorrection of the return code.
>> >
>> > Applied. Good catch.
>> >
>> > Cheers,
>> >
>> > Dejan
>> >
>> >> Regards,
>> >> Tomo
>> >
>> >
>> >
>> >
>> >> _______________________________________________________
>> >> Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
>> >> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
>> >> Home Page: http://linux-ha.org/
>> >
>> > _______________________________________________________
>> > Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
>> > http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
>> > Home Page: http://linux-ha.org/
>> _______________________________________________________
>> Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
>> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
>> Home Page: http://linux-ha.org/
> _______________________________________________________
> Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> Home Page: http://linux-ha.org/
_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/