Mailing List Archive

[PATCH v2] regulator: max77686: Fix checkpatch warnings
Fix below checkpatch warnings:

$ scripts/checkpatch.pl -f drivers/regulator/max77686.c
ERROR: return is not a function, parentheses are not required
+ return (DIV_ROUND_UP(rdev->desc->uV_step

WARNING: line over 80 characters
+ .ops = &max77686_buck_dvs_ops, \

total: 1 errors, 1 warnings, 339 lines checked

Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
v2: Also remove unnecessary parentheses in max77686_set_voltage_time_sel.

drivers/regulator/max77686.c | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/drivers/regulator/max77686.c b/drivers/regulator/max77686.c
index 4e9f4f3..b76a038 100644
--- a/drivers/regulator/max77686.c
+++ b/drivers/regulator/max77686.c
@@ -75,17 +75,18 @@ static int max77686_set_dvs_voltage_time_sel(struct regulator_dev *rdev,
{
struct max77686_data *max77686 = rdev_get_drvdata(rdev);
int ramp_rate[] = {13, 27, 55, 100};
- return (DIV_ROUND_UP(rdev->desc->uV_step
- * abs(new_selector - old_selector),
- ramp_rate[max77686->ramp_delay]));
+
+ return DIV_ROUND_UP(rdev->desc->uV_step *
+ abs(new_selector - old_selector),
+ ramp_rate[max77686->ramp_delay]);
}

static int max77686_set_voltage_time_sel(struct regulator_dev *rdev,
unsigned int old_selector, unsigned int new_selector)
{
/* Unconditionally 100 mV/us */
- return (DIV_ROUND_UP(rdev->desc->uV_step
- * abs(new_selector - old_selector), 100));
+ return DIV_ROUND_UP(rdev->desc->uV_step *
+ abs(new_selector - old_selector), 100);
}

static struct regulator_ops max77686_ops = {
@@ -171,7 +172,7 @@ static struct regulator_ops max77686_buck_dvs_ops = {
#define regulator_desc_buck_dvs(num) { \
.name = "BUCK"#num, \
.id = MAX77686_BUCK##num, \
- .ops = &max77686_buck_dvs_ops, \
+ .ops = &max77686_buck_dvs_ops, \
.type = REGULATOR_VOLTAGE, \
.owner = THIS_MODULE, \
.min_uV = MAX77686_DVS_MINUV, \
--
1.7.9.5



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2] regulator: max77686: Fix checkpatch warnings [ In reply to ]
On Mon, Jun 04, 2012 at 10:19:18AM +0800, Axel Lin wrote:
> Fix below checkpatch warnings:

Applied, thanks.