Mailing List Archive

[PATCH 07/12 v2] pinctrl: add sleep state definition
From: Linus Walleij <linus.walleij@linaro.org>

There is an IDLE definition in the pinctrl framework, but for
ux500 SLEEP is more apropriate.

I've added some comments on the semantics of the common states
so as to avoid misunderstandings.

ChangeLog v1->v2:
- Fixed terminology "on"->"into".

Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
include/linux/pinctrl/pinctrl-state.h | 13 +++++++++++++
1 file changed, 13 insertions(+)

diff --git a/include/linux/pinctrl/pinctrl-state.h b/include/linux/pinctrl/pinctrl-state.h
index 3920e28..634608dc 100644
--- a/include/linux/pinctrl/pinctrl-state.h
+++ b/include/linux/pinctrl/pinctrl-state.h
@@ -2,5 +2,18 @@
* Standard pin control state definitions
*/

+/**
+ * @PINCTRL_STATE_DEFAULT: the state the pinctrl handle shall be put
+ * into as default, usually this means the pins are up and ready to
+ * be used by the device driver. This state is commonly used by
+ * hogs to configure muxing and pins at boot.
+ * @PINCTRL_STATE_IDLE: the state the pinctrl handle shall be put into
+ * when the pins are idle. Could typically be set from a
+ * pm_runtime_suspend() operation.
+ * @PINCTRL_STATE_SLEEP: the state the pinctrl handle shall be put into
+ * when the pins are sleeping. Could typically be set from a
+ * common suspend() function.
+ */
#define PINCTRL_STATE_DEFAULT "default"
#define PINCTRL_STATE_IDLE "idle"
+#define PINCTRL_STATE_SLEEP "sleep"
--
1.7.9.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 07/12 v2] pinctrl: add sleep state definition [ In reply to ]
On 05/11/2012 02:32 AM, Linus Walleij wrote:
> From: Linus Walleij <linus.walleij@linaro.org>
>
> There is an IDLE definition in the pinctrl framework, but for
> ux500 SLEEP is more apropriate.
>
> I've added some comments on the semantics of the common states
> so as to avoid misunderstandings.
>
> ChangeLog v1->v2:
> - Fixed terminology "on"->"into".
>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

The updated patch 2/6/7 all look OK to me too now.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/