Mailing List Archive

Patch for BusinessOnlinePayment
A while back we had a lengthy discussion about passing extra parameters to various BOP backend payment modules. See here http://www.icdevgroup.org/pipermail/interchange-users/2009-March/050260.html. The latest Interchange BusinessOnlinePayment.pm does not allow the values of the 'extra_query_params' to get set. The patch below corrects this.


--- interchange-git/lib/Vend/Payment/BusinessOnlinePayment.pm 2010-05-11 10:19:23.000000000 -0400
+++ interchange-git-build/lib/Vend/Payment/BusinessOnlinePayment.pm 2010-05-20 10:24:44.000000000 -0400
@@ -299,8 +299,7 @@
my @extra = split /[\s,\0]+/, $opt->{extra_query_params};
for (@extra) {
my ( $k, $v ) = split /=/, $_;
- $k ||= $v;
- $params{$k} = $opt->{$v} || charge_param($v);
+ $params{$k} = $v || $opt->{$k} || charge_param($k);
}

$transaction->content(%params);


Bill Carr
Bottlenose - Wine & Spirits eBusiness Specialists
(413) 584-0400

_______________________________________________
interchange-users mailing list
interchange-users@icdevgroup.org
http://www.icdevgroup.org/mailman/listinfo/interchange-users
Re: Patch for BusinessOnlinePayment [ In reply to ]
> A while back we had a lengthy discussion about passing extra parameters to various BOP backend payment modules. See here http://www.icdevgroup.org/pipermail/interchange-users/2009-March/050260.html. The latest Interchange BusinessOnlinePayment.pm does not allow the values of the 'extra_query_params' to get set. The patch below corrects this.


Hi Bill,

A patch to support this went into both the 5.6 and 5.7 branches; have you checked the latest point release of the version you're using?

Thanks,

David
--
David Christensen
End Point Corporation
david@endpoint.com





_______________________________________________
interchange-users mailing list
interchange-users@icdevgroup.org
http://www.icdevgroup.org/mailman/listinfo/interchange-users
Re: Patch for BusinessOnlinePayment [ In reply to ]
On 05/20/2010 04:54 PM, David Christensen wrote:
>> A while back we had a lengthy discussion about passing extra parameters to various BOP backend payment modules. See here http://www.icdevgroup.org/pipermail/interchange-users/2009-March/050260.html. The latest Interchange BusinessOnlinePayment.pm does not allow the values of the 'extra_query_params' to get set. The patch below corrects this.
>
>
> Hi Bill,
>
> A patch to support this went into both the 5.6 and 5.7 branches; have you checked the latest point release of the version you're using?
>

Actually it doesn't work for extra parameters without =, I pushed a fix for that.

Regards
Racke


--
LinuXia Systems => http://www.linuxia.de/
Expert Interchange Consulting and System Administration
ICDEVGROUP => http://www.icdevgroup.org/
Interchange Development Team


_______________________________________________
interchange-users mailing list
interchange-users@icdevgroup.org
http://www.icdevgroup.org/mailman/listinfo/interchange-users