Mailing List Archive

Re: [PATCH 1/2] ruby-ng.eclass: add missing 'estack' inherit to EAPI=6
On Sat, 2019-07-20 at 09:24 +0100, Sergei Trofimovich wrote:
> Noticed when ran egencache:
> $ PORTAGE_ELOG_CLASSES="qa" egencache --repo=gentoo --update --
> update-use-local-desc --jobs=$(nproc)
> * Call stack:
> * ruby-ng.eclass, line 142: Called command_not_found_handle
> 'eshopts_push' '-o' 'noglob'
> * ebuild.sh, line 325: Called __qa_source '/gentoo-
> ebuilds/gentoo/eclass/ruby-fakegem.eclass'
> * ebuild.sh, line 624: Called source '/gentoo-
> ebuilds/gentoo/dev-ruby/moneta/moneta-1.1.0.ebuild'
> * ebuild.sh, line 89: Called die
>
> Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
> ---
> eclass/ruby-ng.eclass | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/eclass/ruby-ng.eclass b/eclass/ruby-ng.eclass
> index a6c4c3396b3..0b0ee696d50 100644
> --- a/eclass/ruby-ng.eclass
> +++ b/eclass/ruby-ng.eclass
> @@ -71,6 +71,9 @@ case ${EAPI} in
> 2|3|4|5)
> inherits="eutils"
> ;;
> + 6)
> + inherits="estack"
> + ;;
> esac
>
> inherit ${inherits} multilib toolchain-funcs ruby-utils

Ack on this change. It seems this got broken when adding EAPI=6 support
but this was never noticed because java-utils-2 also inherits eutils
(and versionator).

Can you commit and push these ASAP? It currently breaks QA. I can also
commit them if you want.

Hans
Re: [PATCH 1/2] ruby-ng.eclass: add missing 'estack' inherit to EAPI=6 [ In reply to ]
On Sat, 20 Jul 2019 10:38:09 +0200
Hans de Graaff <graaff@gentoo.org> wrote:

> On Sat, 2019-07-20 at 09:24 +0100, Sergei Trofimovich wrote:
> > Noticed when ran egencache:
> > $ PORTAGE_ELOG_CLASSES="qa" egencache --repo=gentoo --update --
> > update-use-local-desc --jobs=$(nproc)
> > * Call stack:
> > * ruby-ng.eclass, line 142: Called command_not_found_handle
> > 'eshopts_push' '-o' 'noglob'
> > * ebuild.sh, line 325: Called __qa_source '/gentoo-
> > ebuilds/gentoo/eclass/ruby-fakegem.eclass'
> > * ebuild.sh, line 624: Called source '/gentoo-
> > ebuilds/gentoo/dev-ruby/moneta/moneta-1.1.0.ebuild'
> > * ebuild.sh, line 89: Called die
> >
> > Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
> > ---
> > eclass/ruby-ng.eclass | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/eclass/ruby-ng.eclass b/eclass/ruby-ng.eclass
> > index a6c4c3396b3..0b0ee696d50 100644
> > --- a/eclass/ruby-ng.eclass
> > +++ b/eclass/ruby-ng.eclass
> > @@ -71,6 +71,9 @@ case ${EAPI} in
> > 2|3|4|5)
> > inherits="eutils"
> > ;;
> > + 6)
> > + inherits="estack"
> > + ;;
> > esac
> >
> > inherit ${inherits} multilib toolchain-funcs ruby-utils
>
> Ack on this change. It seems this got broken when adding EAPI=6 support
> but this was never noticed because java-utils-2 also inherits eutils
> (and versionator).
>
> Can you commit and push these ASAP? It currently breaks QA. I can also
> commit them if you want.

Pushed just now.

--

Sergei