Mailing List Archive

Re: [gentoo-commits] gentoo-x86 commit in media-sound/traverso: traverso-0.49.2-r1.ebuild ChangeLog traverso-0.49.2.ebuild traverso-0.49.1.ebuild
> + 07 May 2012; Ben de Groot <yngwin@gentoo.org>
> + +files/traverso-0.49.2-desktop.patch,
> +files/traverso-0.49.2-gold.patch,

that patch is not portable, please fix

> + +traverso-0.49.2-r1.ebuild, -traverso-0.49.1.ebuild,
> -traverso-0.49.2.ebuild:

this leaves a stray patch in files, please fix
Re: [gentoo-commits] gentoo-x86 commit in media-sound/traverso: traverso-0.49.2-r1.ebuild ChangeLog traverso-0.49.2.ebuild traverso-0.49.1.ebuild [ In reply to ]
On Mon, 7 May 2012 21:00:18 +0800
Ben de Groot <yngwin@gentoo.org> wrote:

> On 7 May 2012 20:35, Alexis Ballier <aballier@gentoo.org> wrote:
> >> +  07 May 2012; Ben de Groot <yngwin@gentoo.org>
> >> +  +files/traverso-0.49.2-desktop.patch,
> >> +files/traverso-0.49.2-gold.patch,
> >
> > that patch is not portable, please fix
>
> I considered that, but these patches have been sent upstream,
> so if all is well, then they can be dropped with the next release.
> In case they won't be applied, I'd be happy to make them
> more portable at that time.

if you know that, please do the right thing... now...
if a half-broken patch is applied, that's not because it's good, that's
because the person applying it didn't think about the broken case...

A.

PS: feel free to take maintainership of the package.