Mailing List Archive

[Bug 2413] unexpanded value of dkim_strict is used for comparison in DKIM transport
https://bugs.exim.org/show_bug.cgi?id=2413

Ruben Jenster <r.jenster@drachenfels.de> changed:

What |Removed |Added
----------------------------------------------------------------------------
Summary|dkim_strict value is |unexpanded value of
|compared against unexpanded |dkim_strict is used for
|string in DKIM transport |comparison in DKIM
| |transport

--
You are receiving this mail because:
You are on the CC list for the bug.
--
## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##
[Bug 2413] unexpanded value of dkim_strict is used for comparison in DKIM transport [ In reply to ]
https://bugs.exim.org/show_bug.cgi?id=2413

Jeremy Harris <jgh146exb@wizmail.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Assignee|tom@duncanthrax.net |jgh146exb@wizmail.org
Status|NEW |ASSIGNED

--
You are receiving this mail because:
You are on the CC list for the bug.
--
## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##
[Bug 2413] unexpanded value of dkim_strict is used for comparison in DKIM transport [ In reply to ]
https://bugs.exim.org/show_bug.cgi?id=2413

--- Comment #1 from Ruben Jenster <r.jenster@drachenfels.de> ---
(In reply to Ruben Jenster from comment #0)
> Created attachment 1197 [details]
> Fix dkim_strict evaluation in DKIM transport.
>
> The value of the dkim_strict option in the SMTP transport is expanded but
> compared against the unexpanded value. As a result any dynamic evaluation of
> dkim_strict fails.

more clearly:
The value of the dkim_strict option in the SMTP transport is expanded but the
unexpanded value is compared. As a result any dynamic evaluation of dkim_strict
fails.

> The attached patch fixes this issue.

--
You are receiving this mail because:
You are on the CC list for the bug.
--
## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##
[Bug 2413] unexpanded value of dkim_strict is used for comparison in DKIM transport [ In reply to ]
https://bugs.exim.org/show_bug.cgi?id=2413

Git Commit <git@exim.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |git@exim.org

--- Comment #2 from Git Commit <git@exim.org> ---
Git commit:
https://git.exim.org/exim.git/commitdiff/9fa4d5b45f70b36a46c0d04381a5e05cb39ae3e9

commit 9fa4d5b45f70b36a46c0d04381a5e05cb39ae3e9
Author: Ruben Jenster <r.jenster@drachenfels.de>
AuthorDate: Fri Jul 19 12:56:56 2019 +0100
Commit: Jeremy Harris <jgh146exb@wizmail.org>
CommitDate: Thu Jul 25 12:21:22 2019 +0100

fix dkim_strict expansion. bug 2413

broken since the introduction of dkim support.
testsuite additions by jgh
----
doc/doc-txt/ChangeLog | 4 ++
src/src/dkim.c | 7 +-
src/src/dkim_transport.c | 4 +-
test/confs/4520 | 2 +-
test/log/4520 | 168 +++++++++++++++++++++++---------------------
test/log/4523 | 4 +-
test/log/4524 | 4 +-
test/log/4545 | 8 +--
test/mail/4520.a | 6 +-
test/mail/4520.b | 6 +-
test/mail/4520.b10 | 6 +-
test/mail/4520.b12 | 6 +-
test/mail/4520.b20 | 6 +-
test/mail/4520.b22 | 6 +-
test/mail/4520.d | 6 +-
test/mail/4520.e | 6 +-
test/mail/4520.f | 6 +-
test/paniclog/4520 | 1 +
test/scripts/4500-DKIM/4520 | 7 ++
test/stderr/4520 | 5 +-
20 files changed, 146 insertions(+), 122 deletions(-)

--
You are receiving this mail because:
You are on the CC list for the bug.
--
## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##
[Bug 2413] unexpanded value of dkim_strict is used for comparison in DKIM transport [ In reply to ]
https://bugs.exim.org/show_bug.cgi?id=2413

Jeremy Harris <jgh146exb@wizmail.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED

--- Comment #3 from Jeremy Harris <jgh146exb@wizmail.org> ---
Nobody commented

--
You are receiving this mail because:
You are on the CC list for the bug.
--
## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##