Mailing List Archive

[Bug 423] callout verify failure message as a variable
https://bugs.exim.org/show_bug.cgi?id=423

Simon Arlott <bugzilla.exim.simon@arlott.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #1162|0 |1
is obsolete| |

--- Comment #26 from Simon Arlott <bugzilla.exim.simon@arlott.org> ---
Created attachment 1192
--> https://bugs.exim.org/attachment.cgi?id=1192&action=edit
Add control = no_warn_skipped

I've updated the no_warn_skipped patch to apply against the latest master.

I'd really like to start using this but I don't want to be maintaining a patch
for this feature indefinitely against newer versions of Exim. (I've backported
it to the 4.86.2 version that I'm using and the verify.c code is quite
different).

--
You are receiving this mail because:
You are the QA Contact for the bug.
--
## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##
[Bug 423] callout verify failure message as a variable [ In reply to ]
https://bugs.exim.org/show_bug.cgi?id=423

--- Comment #27 from Simon Arlott <bugzilla.exim.simon@arlott.org> ---
Providing my own user message in the SMTP response is a problem for a defer
because sender_verified_failed is still set and so src/src/smtp_in.c will try
to output it:

if (f.acl_temp_details && user_msg)
{
if ( smtp_return_error_details
&& sender_verified_failed
&& sender_verified_failed->message
)
smtp_respond(smtp_code, codelen, FALSE, sender_verified_failed->message);

smtp_respond(smtp_code, codelen, TRUE, user_msg);
}
else
smtp_respond(smtp_code, codelen, TRUE,
US"Temporary local problem - please try later");

I don't want to disable smtp_return_error_details because that has other side
effects like omitting some of the content of the verify message.

Instead I've invoked ${acl {...}} on an empty ACL because that clears out
sender_verified_failed. Either an additional configuration flag is required to
stop it outputting the most recent sender verify message, or an explicit
control option is required to clear the last result.

--
You are receiving this mail because:
You are the QA Contact for the bug.
--
## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##