Mailing List Archive

Re: svn commit: r1860166 - in /httpd/httpd/branches/2.4.x: ./ docs/manual/mod/ include/ modules/http2/ modules/proxy/ server/
A first heads-up: it seems this commit broke failover for POST requests.
Most (or all?) of the times a balancer failover happens for a POST
request, the request send to the failover node has a Content-Length of
"0" instead of the real content length.

I use a trivial setup like this:

<Proxy balancer://backends/>
ProxySet lbmethod=byrequests
BalancerMember http://localhost:5680
BalancerMember http://localhost:5681
</Proxy>

ProxyPass / balancer://backends/

where one backend node is up and the second node is down.

I will investigate further.

Regards,

Rainer

Am 28.05.2019 um 01:19 schrieb minfrin@apache.org:
> Author: minfrin
> Date: Mon May 27 23:19:12 2019
> New Revision: 1860166
>
> URL: http://svn.apache.org/viewvc?rev=1860166&view=rev
> Log:
> mod_proxy_http: forward 100-continue, and minimize race conditions when
> reusing backend connections. PR 60330.
>
> +1: ylavic, icing, jim
> ylavic: plus http://svn.apache.org/r1856036 (opt-out)
> 2.4.x patch: http://people.apache.org/~ylavic/patches/httpd-2.4.x-forward_100_continue-v6.patch
> +1: ylavic, jim, minfrin
>
> Modified:
> httpd/httpd/branches/2.4.x/CHANGES
> httpd/httpd/branches/2.4.x/STATUS
> httpd/httpd/branches/2.4.x/docs/manual/mod/mod_proxy.xml
> httpd/httpd/branches/2.4.x/include/ap_mmn.h
> httpd/httpd/branches/2.4.x/modules/http2/mod_proxy_http2.c
> httpd/httpd/branches/2.4.x/modules/proxy/mod_proxy.c
> httpd/httpd/branches/2.4.x/modules/proxy/mod_proxy.h
> httpd/httpd/branches/2.4.x/modules/proxy/mod_proxy_http.c
> httpd/httpd/branches/2.4.x/modules/proxy/mod_proxy_wstunnel.c
> httpd/httpd/branches/2.4.x/modules/proxy/proxy_util.c
> httpd/httpd/branches/2.4.x/server/protocol.c
>
> Modified: httpd/httpd/branches/2.4.x/CHANGES
> URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/CHANGES?rev=1860166&r1=1860165&r2=1860166&view=diff
> ==============================================================================
> --- httpd/httpd/branches/2.4.x/CHANGES [utf-8] (original)
> +++ httpd/httpd/branches/2.4.x/CHANGES [utf-8] Mon May 27 23:19:12 2019
> @@ -1,6 +1,9 @@
> -*- coding: utf-8 -*-
> Changes with Apache 2.4.40
>
> + *) mod_proxy_http: forward 100-continue, and minimize race conditions when
> + reusing backend connections. PR 60330. [Yann Ylavic, Jean-Frederic Clere]
> +
> *) Easy patches: synch 2.4.x and trunk
> - core: 80 chars
> - http_core: Clean-uo and style. No functional change overall
>
> Modified: httpd/httpd/branches/2.4.x/STATUS
> URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/STATUS?rev=1860166&r1=1860165&r2=1860166&view=diff
> ==============================================================================
> --- httpd/httpd/branches/2.4.x/STATUS (original)
> +++ httpd/httpd/branches/2.4.x/STATUS Mon May 27 23:19:12 2019
> @@ -128,41 +128,6 @@ PATCHES ACCEPTED TO BACKPORT FROM TRUNK:
> [ start all new proposals below, under PATCHES PROPOSED. ]
>
>
> - *) mod_proxy_http: forward 100-continue, and minimize race conditions when
> - reusing backend connections. PR 60330.
> - trunk patch: http://svn.apache.org/r1656259
> - http://svn.apache.org/r1656359
> - http://svn.apache.org/r1721759
> - http://svn.apache.org/r1729507
> - http://svn.apache.org/r1729749
> - http://svn.apache.org/r1754159
> - http://svn.apache.org/r1836588
> - http://svn.apache.org/r1836648
> - http://svn.apache.org/r1836716
> - http://svn.apache.org/r1836750
> - http://svn.apache.org/r1837040
> - http://svn.apache.org/r1853407
> - http://svn.apache.org/r1853518
> - http://svn.apache.org/r1853561
> - http://svn.apache.org/r1853566
> - http://svn.apache.org/r1853953
> - http://svn.apache.org/r1853956
> - 2.4.x patch: http://people.apache.org/~ylavic/patches/httpd-2.4.x-forward_100_continue-v4.patch
> - ylavic: please note the "s/ASCII_(CRLF|ZERO)/\1_ASCII/g" in the backport,
> - same as in trunk (where definitions come from httpd.h) so doing
> - the change now in 2.4.x helps backports. Since in 2.4.x these
> - macros are still locally #defined, I also added the #ifdefs around
> - them to avoid potential issues..
> - @icing: sorry I had to reset your vote for v4, but it looks
> - sensible to me to have trunk and 2.4.x code in sync as much as
> - possible. Changes from v3 to v4 (r1853953 mainly, r1853956 is only
> - comment) are non functional (or at least intended as such).
> - +1: ylavic, icing, jim
> - ylavic: plus http://svn.apache.org/r1856036 (opt-out)
> - 2.4.x patch: http://people.apache.org/~ylavic/patches/httpd-2.4.x-forward_100_continue-v6.patch
> - +1: ylavic, jim, minfrin
> -
> -
> PATCHES PROPOSED TO BACKPORT FROM TRUNK:
> [. New proposals should be added at the end of the list ]
>
>
> Modified: httpd/httpd/branches/2.4.x/docs/manual/mod/mod_proxy.xml
> URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/docs/manual/mod/mod_proxy.xml?rev=1860166&r1=1860165&r2=1860166&view=diff
> ==============================================================================
> --- httpd/httpd/branches/2.4.x/docs/manual/mod/mod_proxy.xml (original)
> +++ httpd/httpd/branches/2.4.x/docs/manual/mod/mod_proxy.xml Mon May 27 23:19:12 2019
> @@ -2066,6 +2066,29 @@ header for proxied requests</description
> </directivesynopsis>
>
> <directivesynopsis>
> +<name>Proxy100Continue</name>
> +<description>Forward 100-continue expectation to the origin server</description>
> +<syntax>Proxy100Continue Off|On</syntax>
> +<default>Proxy100Continue On</default>
> +<contextlist><context>server config</context>
> +<context>virtual host</context>
> +<context>directory</context>
> +</contextlist>
> +<compatibility>Available in version 2.4.39 and later</compatibility>
> +
> +<usage>
> + <p>This directive determines whether the proxy should forward 100-continue
> + <em>Expect:</em>ation to the origin server and thus let it decide when/if
> + the HTTP request body should be read, or when <code>Off</code> the proxy
> + should generate <em>100 Continue</em> intermediate response by itself before
> + forwarding the request body.</p>
> + <note><title>Effectiveness</title>
> + <p>This option is of use only for HTTP proxying, as handled by <module>mod_proxy_http</module>.</p>
> + </note>
> +</usage>
> +</directivesynopsis>
> +
> +<directivesynopsis>
> <name>ProxySourceAddress</name>
> <description>Set local IP address for outgoing proxy connections</description>
> <syntax>ProxySourceAddress <var>address</var></syntax>
>
> Modified: httpd/httpd/branches/2.4.x/include/ap_mmn.h
> URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/include/ap_mmn.h?rev=1860166&r1=1860165&r2=1860166&view=diff
> ==============================================================================
> --- httpd/httpd/branches/2.4.x/include/ap_mmn.h (original)
> +++ httpd/httpd/branches/2.4.x/include/ap_mmn.h Mon May 27 23:19:12 2019
> @@ -526,7 +526,7 @@
> * 20120211.84 (2.4.35-dev) Add ap_no2slash_ex() and merge_slashes to
> * core_server_conf.
> * 20120211.85 (2.4.40-dev) add ap_set_conn_count().
> - *
> + * 20120211.86 (2.4.35-dev) Add forward_100_continue{,_set} to proxy_dir_conf
> */
>
> #define MODULE_MAGIC_COOKIE 0x41503234UL /* "AP24" */
> @@ -534,7 +534,7 @@
> #ifndef MODULE_MAGIC_NUMBER_MAJOR
> #define MODULE_MAGIC_NUMBER_MAJOR 20120211
> #endif
> -#define MODULE_MAGIC_NUMBER_MINOR 85 /* 0...n */
> +#define MODULE_MAGIC_NUMBER_MINOR 86 /* 0...n */
>
> /**
> * Determine if the server's current MODULE_MAGIC_NUMBER is at least a
>
> Modified: httpd/httpd/branches/2.4.x/modules/http2/mod_proxy_http2.c
> URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/modules/http2/mod_proxy_http2.c?rev=1860166&r1=1860165&r2=1860166&view=diff
> ==============================================================================
> --- httpd/httpd/branches/2.4.x/modules/http2/mod_proxy_http2.c (original)
> +++ httpd/httpd/branches/2.4.x/modules/http2/mod_proxy_http2.c Mon May 27 23:19:12 2019
> @@ -64,7 +64,6 @@ typedef struct h2_proxy_ctx {
> int capacity;
>
> unsigned is_ssl : 1;
> - unsigned flushall : 1;
>
> request_rec *r; /* the request processed in this ctx */
> apr_status_t r_status; /* status of request work */
> @@ -337,7 +336,6 @@ static int proxy_http2_handler(request_r
> ctx->is_ssl = is_ssl;
> ctx->worker = worker;
> ctx->conf = conf;
> - ctx->flushall = apr_table_get(r->subprocess_env, "proxy-flushall")? 1 : 0;
> ctx->req_buffer_size = (32*1024);
> ctx->r = r;
> ctx->r_status = status = HTTP_SERVICE_UNAVAILABLE;
>
> Modified: httpd/httpd/branches/2.4.x/modules/proxy/mod_proxy.c
> URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/modules/proxy/mod_proxy.c?rev=1860166&r1=1860165&r2=1860166&view=diff
> ==============================================================================
> --- httpd/httpd/branches/2.4.x/modules/proxy/mod_proxy.c (original)
> +++ httpd/httpd/branches/2.4.x/modules/proxy/mod_proxy.c Mon May 27 23:19:12 2019
> @@ -1567,6 +1567,8 @@ static void *create_proxy_dir_config(apr
> new->error_override_set = 0;
> new->add_forwarded_headers = 1;
> new->add_forwarded_headers_set = 0;
> + new->forward_100_continue = 1;
> + new->forward_100_continue_set = 0;
>
> return (void *) new;
> }
> @@ -1603,6 +1605,11 @@ static void *merge_proxy_dir_config(apr_
> : add->add_forwarded_headers;
> new->add_forwarded_headers_set = add->add_forwarded_headers_set
> || base->add_forwarded_headers_set;
> + new->forward_100_continue =
> + (add->forward_100_continue_set == 0) ? base->forward_100_continue
> + : add->forward_100_continue;
> + new->forward_100_continue_set = add->forward_100_continue_set
> + || base->forward_100_continue_set;
>
> return new;
> }
> @@ -2103,6 +2110,14 @@ static const char *
> conf->preserve_host_set = 1;
> return NULL;
> }
> +static const char *
> + forward_100_continue(cmd_parms *parms, void *dconf, int flag)
> +{
> + proxy_dir_conf *conf = dconf;
> + conf->forward_100_continue = flag;
> + conf->forward_100_continue_set = 1;
> + return NULL;
> +}
>
> static const char *
> set_recv_buffer_size(cmd_parms *parms, void *dummy, const char *arg)
> @@ -2676,6 +2691,9 @@ static const command_rec proxy_cmds[] =
> "Configure local source IP used for request forward"),
> AP_INIT_FLAG("ProxyAddHeaders", add_proxy_http_headers, NULL, RSRC_CONF|ACCESS_CONF,
> "on if X-Forwarded-* headers should be added or completed"),
> + AP_INIT_FLAG("Proxy100Continue", forward_100_continue, NULL, RSRC_CONF|ACCESS_CONF,
> + "on if 100-Continue should be forwarded to the origin server, off if the "
> + "proxy should handle it by itself"),
> {NULL}
> };
>
>
> Modified: httpd/httpd/branches/2.4.x/modules/proxy/mod_proxy.h
> URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/modules/proxy/mod_proxy.h?rev=1860166&r1=1860165&r2=1860166&view=diff
> ==============================================================================
> --- httpd/httpd/branches/2.4.x/modules/proxy/mod_proxy.h (original)
> +++ httpd/httpd/branches/2.4.x/modules/proxy/mod_proxy.h Mon May 27 23:19:12 2019
> @@ -240,6 +240,8 @@ typedef struct {
> /** Named back references */
> apr_array_header_t *refs;
>
> + unsigned int forward_100_continue:1;
> + unsigned int forward_100_continue_set:1;
> } proxy_dir_conf;
>
> /* if we interpolate env vars per-request, we'll need a per-request
> @@ -379,6 +381,12 @@ do { \
> (w)->s->io_buffer_size_set = (c)->io_buffer_size_set; \
> } while (0)
>
> +#define PROXY_DO_100_CONTINUE(w, r) \
> +((w)->s->ping_timeout_set \
> + && (PROXYREQ_REVERSE == (r)->proxyreq) \
> + && !(apr_table_get((r)->subprocess_env, "force-proxy-request-1.0")) \
> + && ap_request_has_body((r)))
> +
> /* use 2 hashes */
> typedef struct {
> unsigned int def;
>
> Modified: httpd/httpd/branches/2.4.x/modules/proxy/mod_proxy_http.c
> URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/modules/proxy/mod_proxy_http.c?rev=1860166&r1=1860165&r2=1860166&view=diff
> ==============================================================================
> --- httpd/httpd/branches/2.4.x/modules/proxy/mod_proxy_http.c (original)
> +++ httpd/httpd/branches/2.4.x/modules/proxy/mod_proxy_http.c Mon May 27 23:19:12 2019
> @@ -216,8 +216,12 @@ static void add_cl(apr_pool_t *p,
> APR_BRIGADE_INSERT_TAIL(header_brigade, e);
> }
>
> -#define ASCII_CRLF "\015\012"
> -#define ASCII_ZERO "\060"
> +#ifndef CRLF_ASCII
> +#define CRLF_ASCII "\015\012"
> +#endif
> +#ifndef ZERO_ASCII
> +#define ZERO_ASCII "\060"
> +#endif
>
> static void terminate_headers(apr_bucket_alloc_t *bucket_alloc,
> apr_bucket_brigade *header_brigade)
> @@ -225,304 +229,228 @@ static void terminate_headers(apr_bucket
> apr_bucket *e;
>
> /* add empty line at the end of the headers */
> - e = apr_bucket_immortal_create(ASCII_CRLF, 2, bucket_alloc);
> + e = apr_bucket_immortal_create(CRLF_ASCII, 2, bucket_alloc);
> APR_BRIGADE_INSERT_TAIL(header_brigade, e);
> }
>
>
> #define MAX_MEM_SPOOL 16384
>
> -static int stream_reqbody_chunked(apr_pool_t *p,
> - request_rec *r,
> - proxy_conn_rec *p_conn,
> - conn_rec *origin,
> - apr_bucket_brigade *header_brigade,
> - apr_bucket_brigade *input_brigade)
> -{
> - int seen_eos = 0, rv = OK;
> - apr_size_t hdr_len;
> - apr_off_t bytes;
> - apr_status_t status;
> - apr_bucket_alloc_t *bucket_alloc = r->connection->bucket_alloc;
> - apr_bucket_brigade *bb;
> - apr_bucket *e;
> +typedef enum {
> + RB_INIT = 0,
> + RB_STREAM_CL,
> + RB_STREAM_CHUNKED,
> + RB_SPOOL_CL
> +} rb_methods;
> +
> +typedef struct {
> + apr_pool_t *p;
> + request_rec *r;
> + proxy_worker *worker;
> + proxy_server_conf *sconf;
>
> - add_te_chunked(p, bucket_alloc, header_brigade);
> - terminate_headers(bucket_alloc, header_brigade);
> -
> - while (!APR_BUCKET_IS_EOS(APR_BRIGADE_FIRST(input_brigade)))
> - {
> - char chunk_hdr[20]; /* must be here due to transient bucket. */
> -
> - /* If this brigade contains EOS, either stop or remove it. */
> - if (APR_BUCKET_IS_EOS(APR_BRIGADE_LAST(input_brigade))) {
> - seen_eos = 1;
> -
> - /* We can't pass this EOS to the output_filters. */
> - e = APR_BRIGADE_LAST(input_brigade);
> - apr_bucket_delete(e);
> - }
> -
> - apr_brigade_length(input_brigade, 1, &bytes);
> + char server_portstr[32];
> + proxy_conn_rec *backend;
> + conn_rec *origin;
>
> - hdr_len = apr_snprintf(chunk_hdr, sizeof(chunk_hdr),
> - "%" APR_UINT64_T_HEX_FMT CRLF,
> - (apr_uint64_t)bytes);
> -
> - ap_xlate_proto_to_ascii(chunk_hdr, hdr_len);
> - e = apr_bucket_transient_create(chunk_hdr, hdr_len,
> - bucket_alloc);
> - APR_BRIGADE_INSERT_HEAD(input_brigade, e);
> + apr_bucket_alloc_t *bucket_alloc;
> + apr_bucket_brigade *header_brigade;
> + apr_bucket_brigade *input_brigade;
> + char *old_cl_val, *old_te_val;
> + apr_off_t cl_val;
>
> - /*
> - * Append the end-of-chunk CRLF
> - */
> - e = apr_bucket_immortal_create(ASCII_CRLF, 2, bucket_alloc);
> - APR_BRIGADE_INSERT_TAIL(input_brigade, e);
> + rb_methods rb_method;
>
> - if (header_brigade) {
> - /* we never sent the header brigade, so go ahead and
> - * take care of that now
> - */
> - bb = header_brigade;
> + int expecting_100;
> + unsigned int do_100_continue:1,
> + prefetch_nonblocking:1;
> +} proxy_http_req_t;
>
> - /*
> - * Save input_brigade in bb brigade. (At least) in the SSL case
> - * input_brigade contains transient buckets whose data would get
> - * overwritten during the next call of ap_get_brigade in the loop.
> - * ap_save_brigade ensures these buckets to be set aside.
> - * Calling ap_save_brigade with NULL as filter is OK, because
> - * bb brigade already has been created and does not need to get
> - * created by ap_save_brigade.
> - */
> - status = ap_save_brigade(NULL, &bb, &input_brigade, p);
> - if (status != APR_SUCCESS) {
> - return HTTP_INTERNAL_SERVER_ERROR;
> - }
> +/* Read what's in the client pipe. If nonblocking is set and read is EAGAIN,
> + * pass a FLUSH bucket to the backend and read again in blocking mode.
> + */
> +static int stream_reqbody_read(proxy_http_req_t *req, apr_bucket_brigade *bb,
> + int nonblocking)
> +{
> + request_rec *r = req->r;
> + proxy_conn_rec *p_conn = req->backend;
> + apr_bucket_alloc_t *bucket_alloc = req->bucket_alloc;
> + apr_read_type_e block = nonblocking ? APR_NONBLOCK_READ : APR_BLOCK_READ;
> + apr_status_t status;
> + int rv;
>
> - header_brigade = NULL;
> - }
> - else {
> - bb = input_brigade;
> + for (;;) {
> + status = ap_get_brigade(r->input_filters, bb, AP_MODE_READBYTES,
> + block, HUGE_STRING_LEN);
> + if (block == APR_BLOCK_READ
> + || (!APR_STATUS_IS_EAGAIN(status)
> + && (status != APR_SUCCESS || !APR_BRIGADE_EMPTY(bb)))) {
> + break;
> }
>
> - /* The request is flushed below this loop with chunk EOS header */
> - rv = ap_proxy_pass_brigade(bucket_alloc, r, p_conn, origin, bb, 0);
> + /* Flush and retry (blocking) */
> + apr_brigade_cleanup(bb);
> + rv = ap_proxy_pass_brigade(bucket_alloc, r, p_conn, req->origin, bb, 1);
> if (rv != OK) {
> return rv;
> }
> -
> - if (seen_eos) {
> - break;
> - }
> -
> - status = ap_get_brigade(r->input_filters, input_brigade,
> - AP_MODE_READBYTES, APR_BLOCK_READ,
> - HUGE_STRING_LEN);
> -
> - if (status != APR_SUCCESS) {
> - conn_rec *c = r->connection;
> - ap_log_rerror(APLOG_MARK, APLOG_ERR, status, r, APLOGNO(02608)
> - "read request body failed to %pI (%s)"
> - " from %s (%s)", p_conn->addr,
> - p_conn->hostname ? p_conn->hostname: "",
> - c->client_ip, c->remote_host ? c->remote_host: "");
> - return ap_map_http_request_error(status, HTTP_BAD_REQUEST);
> - }
> - }
> -
> - if (header_brigade) {
> - /* we never sent the header brigade because there was no request body;
> - * send it now
> - */
> - bb = header_brigade;
> - }
> - else {
> - if (!APR_BRIGADE_EMPTY(input_brigade)) {
> - /* input brigade still has an EOS which we can't pass to the output_filters. */
> - e = APR_BRIGADE_LAST(input_brigade);
> - AP_DEBUG_ASSERT(APR_BUCKET_IS_EOS(e));
> - apr_bucket_delete(e);
> - }
> - bb = input_brigade;
> + block = APR_BLOCK_READ;
> }
>
> - e = apr_bucket_immortal_create(ASCII_ZERO ASCII_CRLF
> - /* <trailers> */
> - ASCII_CRLF,
> - 5, bucket_alloc);
> - APR_BRIGADE_INSERT_TAIL(bb, e);
> -
> - if (apr_table_get(r->subprocess_env, "proxy-sendextracrlf")) {
> - e = apr_bucket_immortal_create(ASCII_CRLF, 2, bucket_alloc);
> - APR_BRIGADE_INSERT_TAIL(bb, e);
> + if (status != APR_SUCCESS) {
> + conn_rec *c = r->connection;
> + ap_log_rerror(APLOG_MARK, APLOG_ERR, status, r, APLOGNO(02608)
> + "read request body failed to %pI (%s)"
> + " from %s (%s)", p_conn->addr,
> + p_conn->hostname ? p_conn->hostname: "",
> + c->client_ip, c->remote_host ? c->remote_host: "");
> + return ap_map_http_request_error(status, HTTP_BAD_REQUEST);
> }
>
> - /* Now we have headers-only, or the chunk EOS mark; flush it */
> - rv = ap_proxy_pass_brigade(bucket_alloc, r, p_conn, origin, bb, 1);
> - return rv;
> + return OK;
> }
>
> -static int stream_reqbody_cl(apr_pool_t *p,
> - request_rec *r,
> - proxy_conn_rec *p_conn,
> - conn_rec *origin,
> - apr_bucket_brigade *header_brigade,
> - apr_bucket_brigade *input_brigade,
> - char *old_cl_val)
> +static int stream_reqbody(proxy_http_req_t *req, rb_methods rb_method)
> {
> - int seen_eos = 0, rv = 0;
> - apr_status_t status = APR_SUCCESS;
> - apr_bucket_alloc_t *bucket_alloc = r->connection->bucket_alloc;
> - apr_bucket_brigade *bb;
> + request_rec *r = req->r;
> + int seen_eos = 0, rv = OK;
> + apr_size_t hdr_len;
> + char chunk_hdr[20]; /* must be here due to transient bucket. */
> + proxy_conn_rec *p_conn = req->backend;
> + apr_bucket_alloc_t *bucket_alloc = req->bucket_alloc;
> + apr_bucket_brigade *header_brigade = req->header_brigade;
> + apr_bucket_brigade *input_brigade = req->input_brigade;
> + apr_off_t bytes, bytes_streamed = 0;
> apr_bucket *e;
> - apr_off_t cl_val = 0;
> - apr_off_t bytes;
> - apr_off_t bytes_streamed = 0;
> -
> - if (old_cl_val) {
> - char *endstr;
>
> - add_cl(p, bucket_alloc, header_brigade, old_cl_val);
> - status = apr_strtoff(&cl_val, old_cl_val, &endstr, 10);
> -
> - if (status || *endstr || endstr == old_cl_val || cl_val < 0) {
> - ap_log_rerror(APLOG_MARK, APLOG_ERR, status, r, APLOGNO(01085)
> - "could not parse request Content-Length (%s)",
> - old_cl_val);
> - return HTTP_BAD_REQUEST;
> + do {
> + if (APR_BRIGADE_EMPTY(input_brigade)
> + && APR_BRIGADE_EMPTY(header_brigade)) {
> + rv = stream_reqbody_read(req, input_brigade, 1);
> + if (rv != OK) {
> + return rv;
> + }
> }
> - }
> - terminate_headers(bucket_alloc, header_brigade);
> -
> - while (!APR_BUCKET_IS_EOS(APR_BRIGADE_FIRST(input_brigade)))
> - {
> - apr_brigade_length(input_brigade, 1, &bytes);
> - bytes_streamed += bytes;
>
> - /* If this brigade contains EOS, either stop or remove it. */
> - if (APR_BUCKET_IS_EOS(APR_BRIGADE_LAST(input_brigade))) {
> - seen_eos = 1;
> + if (!APR_BRIGADE_EMPTY(input_brigade)) {
> + /* If this brigade contains EOS, either stop or remove it. */
> + if (APR_BUCKET_IS_EOS(APR_BRIGADE_LAST(input_brigade))) {
> + seen_eos = 1;
> +
> + /* We can't pass this EOS to the output_filters. */
> + e = APR_BRIGADE_LAST(input_brigade);
> + apr_bucket_delete(e);
> + }
> +
> + apr_brigade_length(input_brigade, 1, &bytes);
> + bytes_streamed += bytes;
> +
> + if (rb_method == RB_STREAM_CHUNKED) {
> + if (bytes) {
> + /*
> + * Prepend the size of the chunk
> + */
> + hdr_len = apr_snprintf(chunk_hdr, sizeof(chunk_hdr),
> + "%" APR_UINT64_T_HEX_FMT CRLF,
> + (apr_uint64_t)bytes);
> + ap_xlate_proto_to_ascii(chunk_hdr, hdr_len);
> + e = apr_bucket_transient_create(chunk_hdr, hdr_len,
> + bucket_alloc);
> + APR_BRIGADE_INSERT_HEAD(input_brigade, e);
>
> - /* We can't pass this EOS to the output_filters. */
> - e = APR_BRIGADE_LAST(input_brigade);
> - apr_bucket_delete(e);
> + /*
> + * Append the end-of-chunk CRLF
> + */
> + e = apr_bucket_immortal_create(CRLF_ASCII, 2, bucket_alloc);
> + APR_BRIGADE_INSERT_TAIL(input_brigade, e);
> + }
> + if (seen_eos) {
> + /*
> + * Append the tailing 0-size chunk
> + */
> + e = apr_bucket_immortal_create(ZERO_ASCII CRLF_ASCII
> + /* <trailers> */
> + CRLF_ASCII,
> + 5, bucket_alloc);
> + APR_BRIGADE_INSERT_TAIL(input_brigade, e);
> + }
> + }
> + else if (bytes_streamed > req->cl_val) {
> + /* C-L < bytes streamed?!?
> + * We will error out after the body is completely
> + * consumed, but we can't stream more bytes at the
> + * back end since they would in part be interpreted
> + * as another request! If nothing is sent, then
> + * just send nothing.
> + *
> + * Prevents HTTP Response Splitting.
> + */
> + ap_log_rerror(APLOG_MARK, APLOG_ERR, 0, r, APLOGNO(01086)
> + "read more bytes of request body than expected "
> + "(got %" APR_OFF_T_FMT ", expected "
> + "%" APR_OFF_T_FMT ")",
> + bytes_streamed, req->cl_val);
> + return HTTP_INTERNAL_SERVER_ERROR;
> + }
>
> - if (apr_table_get(r->subprocess_env, "proxy-sendextracrlf")) {
> - e = apr_bucket_immortal_create(ASCII_CRLF, 2, bucket_alloc);
> + if (seen_eos && apr_table_get(r->subprocess_env,
> + "proxy-sendextracrlf")) {
> + e = apr_bucket_immortal_create(CRLF_ASCII, 2, bucket_alloc);
> APR_BRIGADE_INSERT_TAIL(input_brigade, e);
> }
> }
>
> - /* C-L < bytes streamed?!?
> - * We will error out after the body is completely
> - * consumed, but we can't stream more bytes at the
> - * back end since they would in part be interpreted
> - * as another request! If nothing is sent, then
> - * just send nothing.
> - *
> - * Prevents HTTP Response Splitting.
> + /* If we never sent the header brigade, go ahead and take care of
> + * that now by prepending it (once only since header_brigade will be
> + * empty afterward).
> */
> - if (bytes_streamed > cl_val) {
> - ap_log_rerror(APLOG_MARK, APLOG_ERR, 0, r, APLOGNO(01086)
> - "read more bytes of request body than expected "
> - "(got %" APR_OFF_T_FMT ", expected %" APR_OFF_T_FMT ")",
> - bytes_streamed, cl_val);
> - return HTTP_INTERNAL_SERVER_ERROR;
> - }
> -
> - if (header_brigade) {
> - /* we never sent the header brigade, so go ahead and
> - * take care of that now
> - */
> - bb = header_brigade;
> + APR_BRIGADE_PREPEND(input_brigade, header_brigade);
>
> - /*
> - * Save input_brigade in bb brigade. (At least) in the SSL case
> - * input_brigade contains transient buckets whose data would get
> - * overwritten during the next call of ap_get_brigade in the loop.
> - * ap_save_brigade ensures these buckets to be set aside.
> - * Calling ap_save_brigade with NULL as filter is OK, because
> - * bb brigade already has been created and does not need to get
> - * created by ap_save_brigade.
> - */
> - status = ap_save_brigade(NULL, &bb, &input_brigade, p);
> - if (status != APR_SUCCESS) {
> - return HTTP_INTERNAL_SERVER_ERROR;
> - }
> -
> - header_brigade = NULL;
> - }
> - else {
> - bb = input_brigade;
> - }
> -
> - /* Once we hit EOS, we are ready to flush. */
> - rv = ap_proxy_pass_brigade(bucket_alloc, r, p_conn, origin, bb, seen_eos);
> + /* Flush here on EOS because we won't stream_reqbody_read() again */
> + rv = ap_proxy_pass_brigade(bucket_alloc, r, p_conn, req->origin,
> + input_brigade, seen_eos);
> if (rv != OK) {
> - return rv ;
> - }
> -
> - if (seen_eos) {
> - break;
> - }
> -
> - status = ap_get_brigade(r->input_filters, input_brigade,
> - AP_MODE_READBYTES, APR_BLOCK_READ,
> - HUGE_STRING_LEN);
> -
> - if (status != APR_SUCCESS) {
> - conn_rec *c = r->connection;
> - ap_log_rerror(APLOG_MARK, APLOG_ERR, status, r, APLOGNO(02609)
> - "read request body failed to %pI (%s)"
> - " from %s (%s)", p_conn->addr,
> - p_conn->hostname ? p_conn->hostname: "",
> - c->client_ip, c->remote_host ? c->remote_host: "");
> - return ap_map_http_request_error(status, HTTP_BAD_REQUEST);
> + return rv;
> }
> - }
> + } while (!seen_eos);
>
> - if (bytes_streamed != cl_val) {
> + if (rb_method == RB_STREAM_CL && bytes_streamed != req->cl_val) {
> ap_log_rerror(APLOG_MARK, APLOG_ERR, 0, r, APLOGNO(01087)
> "client %s given Content-Length did not match"
> " number of body bytes read", r->connection->client_ip);
> return HTTP_BAD_REQUEST;
> }
>
> - if (header_brigade) {
> - /* we never sent the header brigade since there was no request
> - * body; send it now with the flush flag
> - */
> - bb = header_brigade;
> - return(ap_proxy_pass_brigade(bucket_alloc, r, p_conn, origin, bb, 1));
> - }
> -
> return OK;
> }
>
> -static int spool_reqbody_cl(apr_pool_t *p,
> - request_rec *r,
> - proxy_conn_rec *p_conn,
> - conn_rec *origin,
> - apr_bucket_brigade *header_brigade,
> - apr_bucket_brigade *input_brigade,
> - int force_cl)
> +static int spool_reqbody_cl(proxy_http_req_t *req, apr_off_t *bytes_spooled)
> {
> - int seen_eos = 0;
> - apr_status_t status;
> - apr_bucket_alloc_t *bucket_alloc = r->connection->bucket_alloc;
> + apr_pool_t *p = req->p;
> + request_rec *r = req->r;
> + int seen_eos = 0, rv = OK;
> + apr_status_t status = APR_SUCCESS;
> + apr_bucket_alloc_t *bucket_alloc = req->bucket_alloc;
> + apr_bucket_brigade *input_brigade = req->input_brigade;
> apr_bucket_brigade *body_brigade;
> apr_bucket *e;
> - apr_off_t bytes, bytes_spooled = 0, fsize = 0;
> + apr_off_t bytes, fsize = 0;
> apr_file_t *tmpfile = NULL;
> apr_off_t limit;
>
> body_brigade = apr_brigade_create(p, bucket_alloc);
> + *bytes_spooled = 0;
>
> limit = ap_get_limit_req_body(r);
>
> - while (!APR_BUCKET_IS_EOS(APR_BRIGADE_FIRST(input_brigade)))
> - {
> + do {
> + if (APR_BRIGADE_EMPTY(input_brigade)) {
> + rv = stream_reqbody_read(req, input_brigade, 0);
> + if (rv != OK) {
> + return rv;
> + }
> + }
> +
> /* If this brigade contains EOS, either stop or remove it. */
> if (APR_BUCKET_IS_EOS(APR_BRIGADE_LAST(input_brigade))) {
> seen_eos = 1;
> @@ -534,13 +462,13 @@ static int spool_reqbody_cl(apr_pool_t *
>
> apr_brigade_length(input_brigade, 1, &bytes);
>
> - if (bytes_spooled + bytes > MAX_MEM_SPOOL) {
> + if (*bytes_spooled + bytes > MAX_MEM_SPOOL) {
> /*
> * LimitRequestBody does not affect Proxy requests (Should it?).
> * Let it take effect if we decide to store the body in a
> * temporary file on disk.
> */
> - if (limit && (bytes_spooled + bytes > limit)) {
> + if (limit && (*bytes_spooled + bytes > limit)) {
> ap_log_rerror(APLOG_MARK, APLOG_ERR, 0, r, APLOGNO(01088)
> "Request body is larger than the configured "
> "limit of %" APR_OFF_T_FMT, limit);
> @@ -610,69 +538,42 @@ static int spool_reqbody_cl(apr_pool_t *
>
> }
>
> - bytes_spooled += bytes;
> + *bytes_spooled += bytes;
> + } while (!seen_eos);
>
> - if (seen_eos) {
> - break;
> - }
> -
> - status = ap_get_brigade(r->input_filters, input_brigade,
> - AP_MODE_READBYTES, APR_BLOCK_READ,
> - HUGE_STRING_LEN);
> -
> - if (status != APR_SUCCESS) {
> - conn_rec *c = r->connection;
> - ap_log_rerror(APLOG_MARK, APLOG_ERR, status, r, APLOGNO(02610)
> - "read request body failed to %pI (%s)"
> - " from %s (%s)", p_conn->addr,
> - p_conn->hostname ? p_conn->hostname: "",
> - c->client_ip, c->remote_host ? c->remote_host: "");
> - return ap_map_http_request_error(status, HTTP_BAD_REQUEST);
> - }
> - }
> -
> - if (bytes_spooled || force_cl) {
> - add_cl(p, bucket_alloc, header_brigade, apr_off_t_toa(p, bytes_spooled));
> - }
> - terminate_headers(bucket_alloc, header_brigade);
> - APR_BRIGADE_CONCAT(header_brigade, body_brigade);
> + APR_BRIGADE_CONCAT(input_brigade, body_brigade);
> if (tmpfile) {
> - apr_brigade_insert_file(header_brigade, tmpfile, 0, fsize, p);
> + apr_brigade_insert_file(input_brigade, tmpfile, 0, fsize, p);
> }
> if (apr_table_get(r->subprocess_env, "proxy-sendextracrlf")) {
> - e = apr_bucket_immortal_create(ASCII_CRLF, 2, bucket_alloc);
> - APR_BRIGADE_INSERT_TAIL(header_brigade, e);
> + e = apr_bucket_immortal_create(CRLF_ASCII, 2, bucket_alloc);
> + APR_BRIGADE_INSERT_TAIL(input_brigade, e);
> }
> - /* This is all a single brigade, pass with flush flagged */
> - return(ap_proxy_pass_brigade(bucket_alloc, r, p_conn, origin, header_brigade, 1));
> + return OK;
> }
>
> -static
> -int ap_proxy_http_request(apr_pool_t *p, request_rec *r,
> - proxy_conn_rec *p_conn, proxy_worker *worker,
> - proxy_server_conf *conf,
> - apr_uri_t *uri,
> - char *url, char *server_portstr)
> +static int ap_proxy_http_prefetch(proxy_http_req_t *req,
> + apr_uri_t *uri, char *url)
> {
> + apr_pool_t *p = req->p;
> + request_rec *r = req->r;
> conn_rec *c = r->connection;
> - apr_bucket_alloc_t *bucket_alloc = c->bucket_alloc;
> - apr_bucket_brigade *header_brigade;
> - apr_bucket_brigade *input_brigade;
> + proxy_conn_rec *p_conn = req->backend;
> + apr_bucket_alloc_t *bucket_alloc = req->bucket_alloc;
> + apr_bucket_brigade *header_brigade = req->header_brigade;
> + apr_bucket_brigade *input_brigade = req->input_brigade;
> apr_bucket_brigade *temp_brigade;
> apr_bucket *e;
> char *buf;
> apr_status_t status;
> - enum rb_methods {RB_INIT, RB_STREAM_CL, RB_STREAM_CHUNKED, RB_SPOOL_CL};
> - enum rb_methods rb_method = RB_INIT;
> - char *old_cl_val = NULL;
> - char *old_te_val = NULL;
> apr_off_t bytes_read = 0;
> apr_off_t bytes;
> int force10, rv;
> + apr_read_type_e block;
> conn_rec *origin = p_conn->connection;
>
> if (apr_table_get(r->subprocess_env, "force-proxy-request-1.0")) {
> - if (r->expecting_100) {
> + if (req->expecting_100) {
> return HTTP_EXPECTATION_FAILED;
> }
> force10 = 1;
> @@ -680,17 +581,14 @@ int ap_proxy_http_request(apr_pool_t *p,
> force10 = 0;
> }
>
> - header_brigade = apr_brigade_create(p, bucket_alloc);
> rv = ap_proxy_create_hdrbrgd(p, header_brigade, r, p_conn,
> - worker, conf, uri, url, server_portstr,
> - &old_cl_val, &old_te_val);
> + req->worker, req->sconf,
> + uri, url, req->server_portstr,
> + &req->old_cl_val, &req->old_te_val);
> if (rv != OK) {
> return rv;
> }
>
> - /* We have headers, let's figure out our request body... */
> - input_brigade = apr_brigade_create(p, bucket_alloc);
> -
> /* sub-requests never use keepalives, and mustn't pass request bodies.
> * Because the new logic looks at input_brigade, we will self-terminate
> * input_brigade and jump past all of the request body logic...
> @@ -703,9 +601,9 @@ int ap_proxy_http_request(apr_pool_t *p,
> if (!r->kept_body && r->main) {
> /* XXX: Why DON'T sub-requests use keepalives? */
> p_conn->close = 1;
> - old_cl_val = NULL;
> - old_te_val = NULL;
> - rb_method = RB_STREAM_CL;
> + req->old_te_val = NULL;
> + req->old_cl_val = NULL;
> + req->rb_method = RB_STREAM_CL;
> e = apr_bucket_eos_create(input_brigade->bucket_alloc);
> APR_BRIGADE_INSERT_TAIL(input_brigade, e);
> goto skip_body;
> @@ -719,18 +617,19 @@ int ap_proxy_http_request(apr_pool_t *p,
> * encoding has been done by the extensions' handler, and
> * do not modify add_te_chunked's logic
> */
> - if (old_te_val && strcasecmp(old_te_val, "chunked") != 0) {
> + if (req->old_te_val && ap_cstr_casecmp(req->old_te_val, "chunked") != 0) {
> ap_log_rerror(APLOG_MARK, APLOG_ERR, 0, r, APLOGNO(01093)
> - "%s Transfer-Encoding is not supported", old_te_val);
> + "%s Transfer-Encoding is not supported",
> + req->old_te_val);
> return HTTP_INTERNAL_SERVER_ERROR;
> }
>
> - if (old_cl_val && old_te_val) {
> + if (req->old_cl_val && req->old_te_val) {
> ap_log_rerror(APLOG_MARK, APLOG_DEBUG, 0, r, APLOGNO(01094)
> "client %s (%s) requested Transfer-Encoding "
> "chunked body with Content-Length (C-L ignored)",
> c->client_ip, c->remote_host ? c->remote_host: "");
> - old_cl_val = NULL;
> + req->old_cl_val = NULL;
> origin->keepalive = AP_CONN_CLOSE;
> p_conn->close = 1;
> }
> @@ -744,10 +643,19 @@ int ap_proxy_http_request(apr_pool_t *p,
> * reasonable size.
> */
> temp_brigade = apr_brigade_create(p, bucket_alloc);
> + block = req->prefetch_nonblocking ? APR_NONBLOCK_READ : APR_BLOCK_READ;
> do {
> status = ap_get_brigade(r->input_filters, temp_brigade,
> - AP_MODE_READBYTES, APR_BLOCK_READ,
> + AP_MODE_READBYTES, block,
> MAX_MEM_SPOOL - bytes_read);
> + /* ap_get_brigade may return success with an empty brigade
> + * for a non-blocking read which would block
> + */
> + if (block == APR_NONBLOCK_READ
> + && ((status == APR_SUCCESS && APR_BRIGADE_EMPTY(temp_brigade))
> + || APR_STATUS_IS_EAGAIN(status))) {
> + break;
> + }
> if (status != APR_SUCCESS) {
> ap_log_rerror(APLOG_MARK, APLOG_ERR, status, r, APLOGNO(01095)
> "prefetch request body failed to %pI (%s)"
> @@ -785,7 +693,8 @@ int ap_proxy_http_request(apr_pool_t *p,
> * (an arbitrary value.)
> */
> } while ((bytes_read < MAX_MEM_SPOOL - 80)
> - && !APR_BUCKET_IS_EOS(APR_BRIGADE_LAST(input_brigade)));
> + && !APR_BUCKET_IS_EOS(APR_BRIGADE_LAST(input_brigade))
> + && !req->prefetch_nonblocking);
>
> /* Use chunked request body encoding or send a content-length body?
> *
> @@ -822,7 +731,8 @@ int ap_proxy_http_request(apr_pool_t *p,
> * is absent, and the filters are unchanged (the body won't
> * be resized by another content filter).
> */
> - if (APR_BUCKET_IS_EOS(APR_BRIGADE_LAST(input_brigade))) {
> + if (!APR_BRIGADE_EMPTY(input_brigade)
> + && APR_BUCKET_IS_EOS(APR_BRIGADE_LAST(input_brigade))) {
> /* The whole thing fit, so our decision is trivial, use
> * the filtered bytes read from the client for the request
> * body Content-Length.
> @@ -830,34 +740,43 @@ int ap_proxy_http_request(apr_pool_t *p,
> * If we expected no body, and read no body, do not set
> * the Content-Length.
> */
> - if (old_cl_val || old_te_val || bytes_read) {
> - old_cl_val = apr_off_t_toa(r->pool, bytes_read);
> + if (req->old_cl_val || req->old_te_val || bytes_read) {
> + req->old_cl_val = apr_off_t_toa(r->pool, bytes_read);
> + req->cl_val = bytes_read;
> }
> - rb_method = RB_STREAM_CL;
> + req->rb_method = RB_STREAM_CL;
> }
> - else if (old_te_val) {
> + else if (req->old_te_val) {
> if (force10
> || (apr_table_get(r->subprocess_env, "proxy-sendcl")
> && !apr_table_get(r->subprocess_env, "proxy-sendchunks")
> && !apr_table_get(r->subprocess_env, "proxy-sendchunked"))) {
> - rb_method = RB_SPOOL_CL;
> + req->rb_method = RB_SPOOL_CL;
> }
> else {
> - rb_method = RB_STREAM_CHUNKED;
> + req->rb_method = RB_STREAM_CHUNKED;
> }
> }
> - else if (old_cl_val) {
> + else if (req->old_cl_val) {
> if (r->input_filters == r->proto_input_filters) {
> - rb_method = RB_STREAM_CL;
> + char *endstr;
> + status = apr_strtoff(&req->cl_val, req->old_cl_val, &endstr, 10);
> + if (status != APR_SUCCESS || *endstr || req->cl_val < 0) {
> + ap_log_rerror(APLOG_MARK, APLOG_ERR, status, r, APLOGNO(01085)
> + "could not parse request Content-Length (%s)",
> + req->old_cl_val);
> + return HTTP_BAD_REQUEST;
> + }
> + req->rb_method = RB_STREAM_CL;
> }
> else if (!force10
> && (apr_table_get(r->subprocess_env, "proxy-sendchunks")
> || apr_table_get(r->subprocess_env, "proxy-sendchunked"))
> && !apr_table_get(r->subprocess_env, "proxy-sendcl")) {
> - rb_method = RB_STREAM_CHUNKED;
> + req->rb_method = RB_STREAM_CHUNKED;
> }
> else {
> - rb_method = RB_SPOOL_CL;
> + req->rb_method = RB_SPOOL_CL;
> }
> }
> else {
> @@ -865,7 +784,31 @@ int ap_proxy_http_request(apr_pool_t *p,
> * requests, and has the behavior that it will not add any C-L
> * when the old_cl_val is NULL.
> */
> - rb_method = RB_SPOOL_CL;
> + req->rb_method = RB_SPOOL_CL;
> + }
> +
> + switch (req->rb_method) {
> + case RB_STREAM_CHUNKED:
> + add_te_chunked(req->p, bucket_alloc, header_brigade);
> + break;
> +
> + case RB_STREAM_CL:
> + if (req->old_cl_val) {
> + add_cl(req->p, bucket_alloc, header_brigade, req->old_cl_val);
> + }
> + break;
> +
> + default: /* => RB_SPOOL_CL */
> + /* If we have to spool the body, do it now, before connecting or
> + * reusing the backend connection.
> + */
> + rv = spool_reqbody_cl(req, &bytes);
> + if (rv != OK) {
> + return rv;
> + }
> + if (bytes || req->old_te_val || req->old_cl_val) {
> + add_cl(p, bucket_alloc, header_brigade, apr_off_t_toa(p, bytes));
> + }
> }
>
> /* Yes I hate gotos. This is the subrequest shortcut */
> @@ -886,23 +829,44 @@ skip_body:
> e = apr_bucket_pool_create(buf, strlen(buf), p, c->bucket_alloc);
> APR_BRIGADE_INSERT_TAIL(header_brigade, e);
> }
> + terminate_headers(bucket_alloc, header_brigade);
>
> - /* send the request body, if any. */
> - switch(rb_method) {
> - case RB_STREAM_CHUNKED:
> - rv = stream_reqbody_chunked(p, r, p_conn, origin, header_brigade,
> - input_brigade);
> - break;
> + return OK;
> +}
> +
> +static int ap_proxy_http_request(proxy_http_req_t *req)
> +{
> + int rv;
> + request_rec *r = req->r;
> + apr_bucket_alloc_t *bucket_alloc = req->bucket_alloc;
> + apr_bucket_brigade *header_brigade = req->header_brigade;
> + apr_bucket_brigade *input_brigade = req->input_brigade;
> +
> + /* send the request header/body, if any. */
> + switch (req->rb_method) {
> case RB_STREAM_CL:
> - rv = stream_reqbody_cl(p, r, p_conn, origin, header_brigade,
> - input_brigade, old_cl_val);
> + case RB_STREAM_CHUNKED:
> + if (req->do_100_continue) {
> + rv = ap_proxy_pass_brigade(bucket_alloc, r, req->backend,
> + req->origin, header_brigade, 1);
> + }
> + else {
> + rv = stream_reqbody(req, req->rb_method);
> + }
> break;
> +
> case RB_SPOOL_CL:
> - rv = spool_reqbody_cl(p, r, p_conn, origin, header_brigade,
> - input_brigade, (old_cl_val != NULL)
> - || (old_te_val != NULL)
> - || (bytes_read > 0));
> + /* Prefetch has built the header and spooled the whole body;
> + * if we don't expect 100-continue we can flush both all at once,
> + * otherwise flush the header only.
> + */
> + if (!req->do_100_continue) {
> + APR_BRIGADE_CONCAT(header_brigade, input_brigade);
> + }
> + rv = ap_proxy_pass_brigade(bucket_alloc, r, req->backend,
> + req->origin, header_brigade, 1);
> break;
> +
> default:
> /* shouldn't be possible */
> rv = HTTP_INTERNAL_SERVER_ERROR;
> @@ -910,10 +874,12 @@ skip_body:
> }
>
> if (rv != OK) {
> + conn_rec *c = r->connection;
> /* apr_status_t value has been logged in lower level method */
> ap_log_rerror(APLOG_MARK, APLOG_ERR, 0, r, APLOGNO(01097)
> "pass request body failed to %pI (%s) from %s (%s)",
> - p_conn->addr, p_conn->hostname ? p_conn->hostname: "",
> + req->backend->addr,
> + req->backend->hostname ? req->backend->hostname: "",
> c->client_ip, c->remote_host ? c->remote_host: "");
> return rv;
> }
> @@ -1189,12 +1155,16 @@ static int add_trailers(void *data, cons
> }
>
> static
> -apr_status_t ap_proxy_http_process_response(apr_pool_t * p, request_rec *r,
> - proxy_conn_rec **backend_ptr,
> - proxy_worker *worker,
> - proxy_server_conf *conf,
> - char *server_portstr) {
> +int ap_proxy_http_process_response(proxy_http_req_t *req)
> +{
> + apr_pool_t *p = req->p;
> + request_rec *r = req->r;
> conn_rec *c = r->connection;
> + proxy_worker *worker = req->worker;
> + proxy_conn_rec *backend = req->backend;
> + conn_rec *origin = req->origin;
> + int do_100_continue = req->do_100_continue;
> +
> char *buffer;
> char fixed_buffer[HUGE_STRING_LEN];
> const char *buf;
> @@ -1217,19 +1187,11 @@ apr_status_t ap_proxy_http_process_respo
> int proxy_status = OK;
> const char *original_status_line = r->status_line;
> const char *proxy_status_line = NULL;
> - proxy_conn_rec *backend = *backend_ptr;
> - conn_rec *origin = backend->connection;
> apr_interval_time_t old_timeout = 0;
> proxy_dir_conf *dconf;
> - int do_100_continue;
>
> dconf = ap_get_module_config(r->per_dir_config, &proxy_module);
>
> - do_100_continue = (worker->s->ping_timeout_set
> - && ap_request_has_body(r)
> - && (PROXYREQ_REVERSE == r->proxyreq)
> - && !(apr_table_get(r->subprocess_env, "force-proxy-request-1.0")));
> -
> bb = apr_brigade_create(p, c->bucket_alloc);
> pass_bb = apr_brigade_create(p, c->bucket_alloc);
>
> @@ -1248,7 +1210,7 @@ apr_status_t ap_proxy_http_process_respo
> }
>
> /* Setup for 100-Continue timeout if appropriate */
> - if (do_100_continue) {
> + if (do_100_continue && worker->s->ping_timeout_set) {
> apr_socket_timeout_get(backend->sock, &old_timeout);
> if (worker->s->ping_timeout != old_timeout) {
> apr_status_t rc;
> @@ -1273,6 +1235,8 @@ apr_status_t ap_proxy_http_process_respo
> origin->local_addr->port));
> do {
> apr_status_t rc;
> + int major = 0, minor = 0;
> + int toclose = 0;
>
> apr_brigade_cleanup(bb);
>
> @@ -1360,9 +1324,6 @@ apr_status_t ap_proxy_http_process_respo
> * This is buggy if we ever see an HTTP/1.10
> */
> if (apr_date_checkmask(buffer, "HTTP/#.# ###*")) {
> - int major, minor;
> - int toclose;
> -
> major = buffer[5] - '0';
> minor = buffer[7] - '0';
>
> @@ -1412,8 +1373,8 @@ apr_status_t ap_proxy_http_process_respo
> "Set-Cookie", NULL);
>
> /* shove the headers direct into r->headers_out */
> - ap_proxy_read_headers(r, backend->r, buffer, response_field_size, origin,
> - &pread_len);
> + ap_proxy_read_headers(r, backend->r, buffer, response_field_size,
> + origin, &pread_len);
>
> if (r->headers_out == NULL) {
> ap_log_rerror(APLOG_MARK, APLOG_WARNING, 0, r, APLOGNO(01106)
> @@ -1491,7 +1452,8 @@ apr_status_t ap_proxy_http_process_respo
> r->headers_out = ap_proxy_clean_warnings(p, r->headers_out);
>
> /* handle Via header in response */
> - if (conf->viaopt != via_off && conf->viaopt != via_block) {
> + if (req->sconf->viaopt != via_off
> + && req->sconf->viaopt != via_block) {
> const char *server_name = ap_get_server_name(r);
> /* If USE_CANONICAL_NAME_OFF was configured for the proxy virtual host,
> * then the server name returned by ap_get_server_name() is the
> @@ -1502,18 +1464,18 @@ apr_status_t ap_proxy_http_process_respo
> server_name = r->server->server_hostname;
> /* create a "Via:" response header entry and merge it */
> apr_table_addn(r->headers_out, "Via",
> - (conf->viaopt == via_full)
> + (req->sconf->viaopt == via_full)
> ? apr_psprintf(p, "%d.%d %s%s (%s)",
> HTTP_VERSION_MAJOR(r->proto_num),
> HTTP_VERSION_MINOR(r->proto_num),
> server_name,
> - server_portstr,
> + req->server_portstr,
> AP_SERVER_BASEVERSION)
> : apr_psprintf(p, "%d.%d %s%s",
> HTTP_VERSION_MAJOR(r->proto_num),
> HTTP_VERSION_MINOR(r->proto_num),
> server_name,
> - server_portstr)
> + req->server_portstr)
> );
> }
>
> @@ -1531,18 +1493,6 @@ apr_status_t ap_proxy_http_process_respo
> }
>
> if (ap_is_HTTP_INFO(proxy_status)) {
> - interim_response++;
> - /* Reset to old timeout iff we've adjusted it */
> - if (do_100_continue
> - && (r->status == HTTP_CONTINUE)
> - && (worker->s->ping_timeout != old_timeout)) {
> - apr_socket_timeout_set(backend->sock, old_timeout);
> - }
> - }
> - else {
> - interim_response = 0;
> - }
> - if (interim_response) {
> /* RFC2616 tells us to forward this.
> *
> * OTOH, an interim response here may mean the backend
> @@ -1563,7 +1513,13 @@ apr_status_t ap_proxy_http_process_respo
> ap_log_rerror(APLOG_MARK, APLOG_TRACE2, 0, r,
> "HTTP: received interim %d response", r->status);
> if (!policy
> - || (!strcasecmp(policy, "RFC") && ((r->expecting_100 = 1)))) {
> + || (!strcasecmp(policy, "RFC")
> + && (proxy_status != HTTP_CONTINUE
> + || (req->expecting_100 = 1)))) {
> + if (proxy_status == HTTP_CONTINUE) {
> + r->expecting_100 = req->expecting_100;
> + req->expecting_100 = 0;
> + }
> ap_send_interim_response(r, 1);
> }
> /* FIXME: refine this to be able to specify per-response-status
> @@ -1573,7 +1529,106 @@ apr_status_t ap_proxy_http_process_respo
> ap_log_rerror(APLOG_MARK, APLOG_WARNING, 0, r, APLOGNO(01108)
> "undefined proxy interim response policy");
> }
> + interim_response++;
> }
> + else {
> + interim_response = 0;
> + }
> +
> + /* If we still do 100-continue (end-to-end or ping), either the
> + * current response is the expected "100 Continue" and we are done
> + * with this mode, or this is another interim response and we'll wait
> + * for the next one, or this is a final response and hence the backend
> + * did not honor our expectation.
> + */
> + if (do_100_continue && (!interim_response
> + || proxy_status == HTTP_CONTINUE)) {
> + /* RFC 7231 - Section 5.1.1 - Expect - Requirement for servers
> + * A server that responds with a final status code before
> + * reading the entire message body SHOULD indicate in that
> + * response whether it intends to close the connection or
> + * continue reading and discarding the request message.
> + *
> + * So, if this response is not an interim 100 Continue, we can
> + * avoid sending the request body if the backend responded with
> + * "Connection: close" or HTTP < 1.1, and either let the core
> + * discard it or the caller try another balancer member with the
> + * same body (given status 503, though not implemented yet).
> + */
> + int do_send_body = (proxy_status == HTTP_CONTINUE
> + || (!toclose && major > 0 && minor > 0));
> +
> + /* Reset to old timeout iff we've adjusted it. */
> + if (worker->s->ping_timeout_set) {
> + apr_socket_timeout_set(backend->sock, old_timeout);
> + }
> +
> + ap_log_rerror(APLOG_MARK, APLOG_DEBUG, 0, r, APLOGNO(10153)
> + "HTTP: %s100 continue sent by %pI (%s): "
> + "%ssending body (response: HTTP/%i.%i %s)",
> + proxy_status != HTTP_CONTINUE ? "no " : "",
> + backend->addr,
> + backend->hostname ? backend->hostname : "",
> + do_send_body ? "" : "not ",
> + major, minor, proxy_status_line);
> +
> + if (do_send_body) {
> + int status;
> +
> + /* Send the request body (fully). */
> + switch(req->rb_method) {
> + case RB_STREAM_CL:
> + case RB_STREAM_CHUNKED:
> + status = stream_reqbody(req, req->rb_method);
> + break;
> + case RB_SPOOL_CL:
> + /* Prefetch has spooled the whole body, flush it. */
> + status = ap_proxy_pass_brigade(req->bucket_alloc, r,
> + backend, origin,
> + req->input_brigade, 1);
> + break;
> + default:
> + /* Shouldn't happen */
> + status = HTTP_INTERNAL_SERVER_ERROR;
> + break;
> + }
> + if (status != OK) {
> + ap_log_rerror(APLOG_MARK, APLOG_ERR, 0, r,
> + APLOGNO(10154) "pass request body failed "
> + "to %pI (%s) from %s (%s) with status %i",
> + backend->addr,
> + backend->hostname ? backend->hostname : "",
> + c->client_ip,
> + c->remote_host ? c->remote_host : "",
> + status);
> + backend->close = 1;
> + return status;
> + }
> + }
> + else {
> + /* If we don't read the client connection any further, since
> + * there are pending data it should be "Connection: close"d to
> + * prevent reuse. We don't exactly c->keepalive = AP_CONN_CLOSE
> + * here though, because error_override or a potential retry on
> + * another backend could finally read that data and finalize
> + * the request processing, making keep-alive possible. So what
> + * we do is restoring r->expecting_100 for ap_set_keepalive()
> + * to do the right thing according to the final response and
> + * any later update of r->expecting_100.
> + */
> + r->expecting_100 = req->expecting_100;
> + req->expecting_100 = 0;
> + }
> +
> + /* Once only! */
> + do_100_continue = 0;
> + }
> +
> + if (interim_response) {
> + /* Already forwarded above, read next response */
> + continue;
> + }
> +
> /* Moved the fixups of Date headers and those affected by
> * ProxyPassReverse/etc from here to ap_proxy_read_headers
> */
> @@ -1648,7 +1703,6 @@ apr_status_t ap_proxy_http_process_respo
>
> /* send body - but only if a body is expected */
> if ((!r->header_only) && /* not HEAD request */
> - !interim_response && /* not any 1xx response */
> (proxy_status != HTTP_NO_CONTENT) && /* not 204 */
> (proxy_status != HTTP_NOT_MODIFIED)) { /* not 304 */
>
> @@ -1697,7 +1751,7 @@ apr_status_t ap_proxy_http_process_respo
>
> rv = ap_get_brigade(backend->r->input_filters, bb,
> AP_MODE_READBYTES, mode,
> - conf->io_buffer_size);
> + req->sconf->io_buffer_size);
>
> /* ap_get_brigade will return success with an empty brigade
> * for a non-blocking read which would block: */
> @@ -1789,7 +1843,7 @@ apr_status_t ap_proxy_http_process_respo
> ap_proxy_release_connection(backend->worker->s->scheme,
> backend, r->server);
> /* Ensure that the backend is not reused */
> - *backend_ptr = NULL;
> + req->backend = NULL;
>
> }
>
> @@ -1798,12 +1852,13 @@ apr_status_t ap_proxy_http_process_respo
> || c->aborted) {
> /* Ack! Phbtt! Die! User aborted! */
> /* Only close backend if we haven't got all from the
> - * backend. Furthermore if *backend_ptr is NULL it is no
> + * backend. Furthermore if req->backend is NULL it is no
> * longer safe to fiddle around with backend as it might
> * be already in use by another thread.
> */
> - if (*backend_ptr) {
> - backend->close = 1; /* this causes socket close below */
> + if (req->backend) {
> + /* this causes socket close below */
> + req->backend->close = 1;
> }
> finish = TRUE;
> }
> @@ -1816,7 +1871,7 @@ apr_status_t ap_proxy_http_process_respo
> }
> ap_log_rerror(APLOG_MARK, APLOG_TRACE2, 0, r, "end body send");
> }
> - else if (!interim_response) {
> + else {
> ap_log_rerror(APLOG_MARK, APLOG_TRACE2, 0, r, "header only");
>
> /* make sure we release the backend connection as soon
> @@ -1826,7 +1881,7 @@ apr_status_t ap_proxy_http_process_respo
> */
> ap_proxy_release_connection(backend->worker->s->scheme,
> backend, r->server);
> - *backend_ptr = NULL;
> + req->backend = NULL;
>
> /* Pass EOS bucket down the filter chain. */
> e = apr_bucket_eos_create(c->bucket_alloc);
> @@ -1880,14 +1935,17 @@ static int proxy_http_handler(request_re
> apr_port_t proxyport)
> {
> int status;
> - char server_portstr[32];
> char *scheme;
> const char *proxy_function;
> const char *u;
> + proxy_http_req_t *req = NULL;
> proxy_conn_rec *backend = NULL;
> int is_ssl = 0;
> conn_rec *c = r->connection;
> + proxy_dir_conf *dconf;
> int retry = 0;
> + char *locurl = url;
> + int toclose = 0;
> /*
> * Use a shorter-lived pool to reduce memory usage
> * and avoid a memory leak
> @@ -1928,14 +1986,47 @@ static int proxy_http_handler(request_re
> }
> ap_log_rerror(APLOG_MARK, APLOG_TRACE1, 0, r, "HTTP: serving URL %s", url);
>
> -
> /* create space for state information */
> if ((status = ap_proxy_acquire_connection(proxy_function, &backend,
> - worker, r->server)) != OK)
> - goto cleanup;
> + worker, r->server)) != OK) {
> + return status;
> + }
>
> backend->is_ssl = is_ssl;
>
> + req = apr_pcalloc(p, sizeof(*req));
> + req->p = p;
> + req->r = r;
> + req->sconf = conf;
> + req->worker = worker;
> + req->backend = backend;
> + req->bucket_alloc = c->bucket_alloc;
> + req->rb_method = RB_INIT;
> +
> + dconf = ap_get_module_config(r->per_dir_config, &proxy_module);
> +
> + /* Should we handle end-to-end or ping 100-continue? */
> + if ((r->expecting_100 && dconf->forward_100_continue)
> + || PROXY_DO_100_CONTINUE(worker, r)) {
> + /* We need to reset r->expecting_100 or prefetching will cause
> + * ap_http_filter() to send "100 Continue" response by itself. So
> + * we'll use req->expecting_100 in mod_proxy_http to determine whether
> + * the client should be forwarded "100 continue", and r->expecting_100
> + * will be restored at the end of the function with the actual value of
> + * req->expecting_100 (i.e. cleared only if mod_proxy_http sent the
> + * "100 Continue" according to its policy).
> + */
> + req->do_100_continue = req->prefetch_nonblocking = 1;
> + req->expecting_100 = r->expecting_100;
> + r->expecting_100 = 0;
> + }
> + /* Should we block while prefetching the body or try nonblocking and flush
> + * data to the backend ASAP?
> + */
> + else if (apr_table_get(r->subprocess_env, "proxy-prefetch-nonblocking")) {
> + req->prefetch_nonblocking = 1;
> + }
> +
> /*
> * In the case that we are handling a reverse proxy connection and this
> * is not a request that is coming over an already kept alive connection
> @@ -1949,15 +2040,53 @@ static int proxy_http_handler(request_re
> backend->close = 1;
> }
>
> + /* Step One: Determine Who To Connect To */
> + if ((status = ap_proxy_determine_connection(p, r, conf, worker, backend,
> + uri, &locurl, proxyname,
> + proxyport, req->server_portstr,
> + sizeof(req->server_portstr))))
> + goto cleanup;
> +
> + /* Prefetch (nonlocking) the request body so to increase the chance to get
> + * the whole (or enough) body and determine Content-Length vs chunked or
> + * spooled. By doing this before connecting or reusing the backend, we want
> + * to minimize the delay between this connection is considered alive and
> + * the first bytes sent (should the client's link be slow or some input
> + * filter retain the data). This is a best effort to prevent the backend
> + * from closing (from under us) what it thinks is an idle connection, hence
> + * to reduce to the minimum the unavoidable local is_socket_connected() vs
> + * remote keepalive race condition.
> + */
> + req->input_brigade = apr_brigade_create(p, req->bucket_alloc);
> + req->header_brigade = apr_brigade_create(p, req->bucket_alloc);
> + if ((status = ap_proxy_http_prefetch(req, uri, locurl)) != OK)
> + goto cleanup;
> +
> + /* We need to reset backend->close now, since ap_proxy_http_prefetch() set
> + * it to disable the reuse of the connection *after* this request (no keep-
> + * alive), not to close any reusable connection before this request. However
> + * assure what is expected later by using a local flag and do the right thing
> + * when ap_proxy_connect_backend() below provides the connection to close.
> + */
> + toclose = backend->close;
> + backend->close = 0;
> +
> while (retry < 2) {
> - char *locurl = url;
> + if (retry) {
> + char *newurl = url;
>
> - /* Step One: Determine Who To Connect To */
> - if ((status = ap_proxy_determine_connection(p, r, conf, worker, backend,
> - uri, &locurl, proxyname,
> - proxyport, server_portstr,
> - sizeof(server_portstr))) != OK)
> - break;
> + /* Step One (again): (Re)Determine Who To Connect To */
> + if ((status = ap_proxy_determine_connection(p, r, conf, worker,
> + backend, uri, &newurl, proxyname, proxyport,
> + req->server_portstr, sizeof(req->server_portstr))))
> + break;
> +
> + /* The code assumes locurl is not changed during the loop, or
> + * ap_proxy_http_prefetch() would have to be called every time,
> + * and header_brigade be changed accordingly...
> + */
> + AP_DEBUG_ASSERT(strcmp(newurl, locurl) == 0);
> + }
>
> /* Step Two: Make the Connection */
> if (ap_proxy_check_connection(proxy_function, backend, r->server, 1,
> @@ -1975,39 +2104,47 @@ static int proxy_http_handler(request_re
> if ((status = ap_proxy_connection_create_ex(proxy_function,
> backend, r)) != OK)
> break;
> + req->origin = backend->connection;
> +
> + /* Don't recycle the connection if prefetch (above) told not to do so */
> + if (toclose) {
> + backend->close = 1;
> + req->origin->keepalive = AP_CONN_CLOSE;
> + }
>
> /* Step Four: Send the Request
> * On the off-chance that we forced a 100-Continue as a
> * kinda HTTP ping test, allow for retries
> */
> - if ((status = ap_proxy_http_request(p, r, backend, worker,
> - conf, uri, locurl, server_portstr)) != OK) {
> - if ((status == HTTP_SERVICE_UNAVAILABLE) && worker->s->ping_timeout_set) {
> - backend->close = 1;
> + status = ap_proxy_http_request(req);
> + if (status != OK) {
> + if (req->do_100_continue && status == HTTP_SERVICE_UNAVAILABLE) {
> ap_log_rerror(APLOG_MARK, APLOG_INFO, status, r, APLOGNO(01115)
> "HTTP: 100-Continue failed to %pI (%s)",
> worker->cp->addr, worker->s->hostname_ex);
> + backend->close = 1;
> retry++;
> continue;
> - } else {
> - break;
> }
> -
> + break;
> }
>
> /* Step Five: Receive the Response... Fall thru to cleanup */
> - status = ap_proxy_http_process_response(p, r, &backend, worker,
> - conf, server_portstr);
> + status = ap_proxy_http_process_response(req);
>
> break;
> }
>
> /* Step Six: Clean Up */
> cleanup:
> - if (backend) {
> + if (req->backend) {
> if (status != OK)
> - backend->close = 1;
> - ap_proxy_http_cleanup(proxy_function, r, backend);
> + req->backend->close = 1;
> + ap_proxy_http_cleanup(proxy_function, r, req->backend);
> + }
> + if (req->expecting_100) {
> + /* Restore r->expecting_100 if we didn't touch it */
> + r->expecting_100 = req->expecting_100;
> }
> return status;
> }
>
> Modified: httpd/httpd/branches/2.4.x/modules/proxy/mod_proxy_wstunnel.c
> URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/modules/proxy/mod_proxy_wstunnel.c?rev=1860166&r1=1860165&r2=1860166&view=diff
> ==============================================================================
> --- httpd/httpd/branches/2.4.x/modules/proxy/mod_proxy_wstunnel.c (original)
> +++ httpd/httpd/branches/2.4.x/modules/proxy/mod_proxy_wstunnel.c Mon May 27 23:19:12 2019
> @@ -287,8 +287,8 @@ static int proxy_wstunnel_handler(reques
> char server_portstr[32];
> proxy_conn_rec *backend = NULL;
> char *scheme;
> - int retry;
> apr_pool_t *p = r->pool;
> + char *locurl = url;
> apr_uri_t *uri;
> int is_ssl = 0;
> const char *upgrade_method = *worker->s->upgrade ? worker->s->upgrade : "WebSocket";
> @@ -321,57 +321,48 @@ static int proxy_wstunnel_handler(reques
> ap_log_rerror(APLOG_MARK, APLOG_DEBUG, 0, r, APLOGNO(02451) "serving URL %s", url);
>
> /* create space for state information */
> - status = ap_proxy_acquire_connection(scheme, &backend, worker,
> - r->server);
> + status = ap_proxy_acquire_connection(scheme, &backend, worker, r->server);
> if (status != OK) {
> - if (backend) {
> - backend->close = 1;
> - ap_proxy_release_connection(scheme, backend, r->server);
> - }
> - return status;
> + goto cleanup;
> }
>
> backend->is_ssl = is_ssl;
> backend->close = 0;
>
> - retry = 0;
> - while (retry < 2) {
> - char *locurl = url;
> - /* Step One: Determine Who To Connect To */
> - status = ap_proxy_determine_connection(p, r, conf, worker, backend,
> - uri, &locurl, proxyname, proxyport,
> - server_portstr,
> - sizeof(server_portstr));
> -
> - if (status != OK)
> - break;
> -
> - /* Step Two: Make the Connection */
> - if (ap_proxy_connect_backend(scheme, backend, worker, r->server)) {
> - ap_log_rerror(APLOG_MARK, APLOG_ERR, 0, r, APLOGNO(02452)
> - "failed to make connection to backend: %s",
> - backend->hostname);
> - status = HTTP_SERVICE_UNAVAILABLE;
> - break;
> - }
> -
> - /* Step Three: Create conn_rec */
> - status = ap_proxy_connection_create_ex(scheme, backend, r);
> - if (status != OK) {
> - break;
> - }
> -
> - backend->close = 1; /* must be after ap_proxy_determine_connection */
> + /* Step One: Determine Who To Connect To */
> + status = ap_proxy_determine_connection(p, r, conf, worker, backend,
> + uri, &locurl, proxyname, proxyport,
> + server_portstr,
> + sizeof(server_portstr));
> + if (status != OK) {
> + goto cleanup;
> + }
>
> + /* Step Two: Make the Connection */
> + if (ap_proxy_connect_backend(scheme, backend, worker, r->server)) {
> + ap_log_rerror(APLOG_MARK, APLOG_ERR, 0, r, APLOGNO(02452)
> + "failed to make connection to backend: %s",
> + backend->hostname);
> + status = HTTP_SERVICE_UNAVAILABLE;
> + goto cleanup;
> + }
>
> - /* Step Four: Process the Request */
> - status = proxy_wstunnel_request(p, r, backend, worker, conf, uri, locurl,
> - server_portstr);
> - break;
> + /* Step Three: Create conn_rec */
> + status = ap_proxy_connection_create_ex(scheme, backend, r);
> + if (status != OK) {
> + goto cleanup;
> }
>
> + /* Step Four: Process the Request */
> + status = proxy_wstunnel_request(p, r, backend, worker, conf, uri, locurl,
> + server_portstr);
> +
> +cleanup:
> /* Do not close the socket */
> - ap_proxy_release_connection(scheme, backend, r->server);
> + if (backend) {
> + backend->close = 1;
> + ap_proxy_release_connection(scheme, backend, r->server);
> + }
> return status;
> }
>
>
> Modified: httpd/httpd/branches/2.4.x/modules/proxy/proxy_util.c
> URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/modules/proxy/proxy_util.c?rev=1860166&r1=1860165&r2=1860166&view=diff
> ==============================================================================
> --- httpd/httpd/branches/2.4.x/modules/proxy/proxy_util.c (original)
> +++ httpd/httpd/branches/2.4.x/modules/proxy/proxy_util.c Mon May 27 23:19:12 2019
> @@ -3603,10 +3603,7 @@ PROXY_DECLARE(int) ap_proxy_create_hdrbr
> * To be compliant, we only use 100-Continue for requests with bodies.
> * We also make sure we won't be talking HTTP/1.0 as well.
> */
> - do_100_continue = (worker->s->ping_timeout_set
> - && ap_request_has_body(r)
> - && (PROXYREQ_REVERSE == r->proxyreq)
> - && !(apr_table_get(r->subprocess_env, "force-proxy-request-1.0")));
> + do_100_continue = PROXY_DO_100_CONTINUE(worker, r);
>
> if (apr_table_get(r->subprocess_env, "force-proxy-request-1.0")) {
> /*
> @@ -3623,7 +3620,9 @@ PROXY_DECLARE(int) ap_proxy_create_hdrbr
> buf = apr_pstrcat(p, r->method, " ", url, " HTTP/1.1" CRLF, NULL);
> }
> if (apr_table_get(r->subprocess_env, "proxy-nokeepalive")) {
> - origin->keepalive = AP_CONN_CLOSE;
> + if (origin) {
> + origin->keepalive = AP_CONN_CLOSE;
> + }
> p_conn->close = 1;
> }
> ap_xlate_proto_to_ascii(buf, strlen(buf));
> @@ -3715,14 +3714,6 @@ PROXY_DECLARE(int) ap_proxy_create_hdrbr
> if (do_100_continue) {
> const char *val;
>
> - if (!r->expecting_100) {
> - /* Don't forward any "100 Continue" response if the client is
> - * not expecting it.
> - */
> - apr_table_setn(r->subprocess_env, "proxy-interim-response",
> - "Suppress");
> - }
> -
> /* Add the Expect header if not already there. */
> if (((val = apr_table_get(r->headers_in, "Expect")) == NULL)
> || (strcasecmp(val, "100-Continue") != 0 /* fast path */
>
> Modified: httpd/httpd/branches/2.4.x/server/protocol.c
> URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/server/protocol.c?rev=1860166&r1=1860165&r2=1860166&view=diff
> ==============================================================================
> --- httpd/httpd/branches/2.4.x/server/protocol.c (original)
> +++ httpd/httpd/branches/2.4.x/server/protocol.c Mon May 27 23:19:12 2019
> @@ -2188,21 +2188,23 @@ AP_DECLARE(void) ap_send_interim_respons
> "Status is %d - not sending interim response", r->status);
> return;
> }
> - if ((r->status == HTTP_CONTINUE) && !r->expecting_100) {
> - /*
> - * Don't send 100-Continue when there was no Expect: 100-continue
> - * in the request headers. For origin servers this is a SHOULD NOT
> - * for proxies it is a MUST NOT according to RFC 2616 8.2.3
> - */
> - return;
> - }
> + if (r->status == HTTP_CONTINUE) {
> + if (!r->expecting_100) {
> + /*
> + * Don't send 100-Continue when there was no Expect: 100-continue
> + * in the request headers. For origin servers this is a SHOULD NOT
> + * for proxies it is a MUST NOT according to RFC 2616 8.2.3
> + */
> + return;
> + }
>
> - /* if we send an interim response, we're no longer in a state of
> - * expecting one. Also, this could feasibly be in a subrequest,
> - * so we need to propagate the fact that we responded.
> - */
> - for (rr = r; rr != NULL; rr = rr->main) {
> - rr->expecting_100 = 0;
> + /* if we send an interim response, we're no longer in a state of
> + * expecting one. Also, this could feasibly be in a subrequest,
> + * so we need to propagate the fact that we responded.
> + */
> + for (rr = r; rr != NULL; rr = rr->main) {
> + rr->expecting_100 = 0;
> + }
> }
>
> status_line = apr_pstrcat(r->pool, AP_SERVER_PROTOCOL, " ", r->status_line, CRLF, NULL);
Re: svn commit: r1860166 - in /httpd/httpd/branches/2.4.x: ./ docs/manual/mod/ include/ modules/http2/ modules/proxy/ server/ [ In reply to ]
This happens in the case of a small body. We read the body into
req->input_brigade in ap_proxy_http_prefetch() before trying the first
node, but then loose it on the second node, because we use another req
and thus also another req->input_brigade then.

Not sure, how we could best save the read input_brigade for the second
attempt after failover. Will try some experiments.

If you try to reproduce yourself, make sure you use a small POST (here:
30 bytes) and also exclude /favicon.ico from forwarding when using a
browser. Otherwise some of the failovers will be triggered by
favicon.ico and you'll not notice the problem in the POST request:

ProxyPass /favicon.ico !

Regards,

Rainer

Am 29.10.2019 um 11:15 schrieb Rainer Jung:
> A first heads-up: it seems this commit broke failover for POST requests.
> Most (or all?) of the times a balancer failover happens for a POST
> request, the request send to the failover node has a Content-Length of
> "0" instead of the real content length.
>
> I use a trivial setup like this:
>
> <Proxy balancer://backends/>
>   ProxySet lbmethod=byrequests
>   BalancerMember http://localhost:5680
>   BalancerMember http://localhost:5681
> </Proxy>
>
> ProxyPass / balancer://backends/
>
> where one backend node is up and the second node is down.
>
> I will investigate further.
>
> Regards,
>
> Rainer
Re: svn commit: r1860166 - in /httpd/httpd/branches/2.4.x: ./ docs/manual/mod/ include/ modules/http2/ modules/proxy/ server/ [ In reply to ]
The reason why this fails now is that we prefetch in 2.4.41 the request
body before doing the connection check to the backend. In 2.4.39 we did
that after doing the check, so the body was still there when doing the
final request sending.

2.4.39:

In proxy_http_handler():
- ap_proxy_determine_connection()
- ap_proxy_check_connection()
- optionally ap_proxy_connect_backend() which might fail.
- ap_proxy_connection_create_ex()
- ap_proxy_http_request() which does prefetch late!

2.4.41:

In proxy_http_handler():
- ap_proxy_determine_connection()
- early ap_proxy_http_prefetch() which does the prefetch!
- optionally again ap_proxy_determine_connection()
- ap_proxy_check_connection()
- optionally ap_proxy_connect_backend() which might fail.
- ap_proxy_connection_create_ex()
- ap_proxy_http_request()

So we either need to remember the prefetch result for later retries or
switch back to the old order.

Regards,

Rainer

Am 29.10.2019 um 12:46 schrieb Rainer Jung:
> This happens in the case of a small body. We read the body into
> req->input_brigade in ap_proxy_http_prefetch() before trying the first
> node, but then loose it on the second node, because we use another req
> and thus also another req->input_brigade then.
>
> Not sure, how we could best save the read input_brigade for the second
> attempt after failover. Will try some experiments.
>
> If you try to reproduce yourself, make sure you use a small POST (here:
> 30 bytes) and also exclude /favicon.ico from forwarding when using a
> browser. Otherwise some of the failovers will be triggered by
> favicon.ico and you'll not notice the problem in the POST request:
>
> ProxyPass /favicon.ico !
>
> Regards,
>
> Rainer
>
> Am 29.10.2019 um 11:15 schrieb Rainer Jung:
>> A first heads-up: it seems this commit broke failover for POST
>> requests. Most (or all?) of the times a balancer failover happens for
>> a POST request, the request send to the failover node has a
>> Content-Length of "0" instead of the real content length.
>>
>> I use a trivial setup like this:
>>
>> <Proxy balancer://backends/>
>>    ProxySet lbmethod=byrequests
>>    BalancerMember http://localhost:5680
>>    BalancerMember http://localhost:5681
>> </Proxy>
>>
>> ProxyPass / balancer://backends/
>>
>> where one backend node is up and the second node is down.
>>
>> I will investigate further.
>>
>> Regards,
>>
>> Rainer
Re: svn commit: r1860166 - in /httpd/httpd/branches/2.4.x: ./ docs/manual/mod/ include/ modules/http2/ modules/proxy/ server/ [ In reply to ]
Aha, and this is due to the fact, that r1656259 "mod_proxy_http: don't
connect or reuse backend before prefetching request body." or parts of
it was backported from trunk to 2.4 as part of r1860166.

So I think (not yet verified), that the same problems applies to trunk
since r1656259 in February 2015 :(

Regards,

Rainer

Am 29.10.2019 um 14:21 schrieb Rainer Jung:
> The reason why this fails now is that we prefetch in 2.4.41 the request
> body before doing the connection check to the backend. In 2.4.39 we did
> that after doing the check, so the body was still there when doing the
> final request sending.
>
> 2.4.39:
>
> In proxy_http_handler():
> - ap_proxy_determine_connection()
> - ap_proxy_check_connection()
> - optionally ap_proxy_connect_backend() which might fail.
> - ap_proxy_connection_create_ex()
> - ap_proxy_http_request() which does prefetch late!
>
> 2.4.41:
>
> In proxy_http_handler():
> - ap_proxy_determine_connection()
> - early ap_proxy_http_prefetch() which does the prefetch!
> - optionally again ap_proxy_determine_connection()
> - ap_proxy_check_connection()
> - optionally ap_proxy_connect_backend() which might fail.
> - ap_proxy_connection_create_ex()
> - ap_proxy_http_request()
>
> So we either need to remember the prefetch result for later retries or
> switch back to the old order.
>
> Regards,
>
> Rainer
>
> Am 29.10.2019 um 12:46 schrieb Rainer Jung:
>> This happens in the case of a small body. We read the body into
>> req->input_brigade in ap_proxy_http_prefetch() before trying the first
>> node, but then loose it on the second node, because we use another req
>> and thus also another req->input_brigade then.
>>
>> Not sure, how we could best save the read input_brigade for the second
>> attempt after failover. Will try some experiments.
>>
>> If you try to reproduce yourself, make sure you use a small POST
>> (here: 30 bytes) and also exclude /favicon.ico from forwarding when
>> using a browser. Otherwise some of the failovers will be triggered by
>> favicon.ico and you'll not notice the problem in the POST request:
>>
>> ProxyPass /favicon.ico !
>>
>> Regards,
>>
>> Rainer
>>
>> Am 29.10.2019 um 11:15 schrieb Rainer Jung:
>>> A first heads-up: it seems this commit broke failover for POST
>>> requests. Most (or all?) of the times a balancer failover happens for
>>> a POST request, the request send to the failover node has a
>>> Content-Length of "0" instead of the real content length.
>>>
>>> I use a trivial setup like this:
>>>
>>> <Proxy balancer://backends/>
>>>    ProxySet lbmethod=byrequests
>>>    BalancerMember http://localhost:5680
>>>    BalancerMember http://localhost:5681
>>> </Proxy>
>>>
>>> ProxyPass / balancer://backends/
>>>
>>> where one backend node is up and the second node is down.
>>>
>>> I will investigate further.
>>>
>>> Regards,
>>>
>>> Rainer

--
kippdata
informationstechnologie GmbH Tel: 0228 98549 -0
Bornheimer Str. 33a Fax: 0228 98549 -50
53111 Bonn www.kippdata.de

HRB 8018 Amtsgericht Bonn / USt.-IdNr. DE 196 457 417
Geschäftsführer: Dr. Thomas Höfer, Rainer Jung, Sven Maurmann
Re: svn commit: r1860166 - in /httpd/httpd/branches/2.4.x: ./ docs/manual/mod/ include/ modules/http2/ modules/proxy/ server/ [ In reply to ]
> Am 29.10.2019 um 14:45 schrieb Rainer Jung <rainer.jung@kippdata.de>:
>
> Aha, and this is due to the fact, that r1656259 "mod_proxy_http: don't connect or reuse backend before prefetching request body." or parts of it was backported from trunk to 2.4 as part of r1860166.
>
> So I think (not yet verified), that the same problems applies to trunk since r1656259 in February 2015 :(

trunk is the root of all problems!

> Regards,
>
> Rainer
>
> Am 29.10.2019 um 14:21 schrieb Rainer Jung:
>> The reason why this fails now is that we prefetch in 2.4.41 the request body before doing the connection check to the backend. In 2.4.39 we did that after doing the check, so the body was still there when doing the final request sending.
>> 2.4.39:
>> In proxy_http_handler():
>> - ap_proxy_determine_connection()
>> - ap_proxy_check_connection()
>> - optionally ap_proxy_connect_backend() which might fail.
>> - ap_proxy_connection_create_ex()
>> - ap_proxy_http_request() which does prefetch late!
>> 2.4.41:
>> In proxy_http_handler():
>> - ap_proxy_determine_connection()
>> - early ap_proxy_http_prefetch() which does the prefetch!
>> - optionally again ap_proxy_determine_connection()
>> - ap_proxy_check_connection()
>> - optionally ap_proxy_connect_backend() which might fail.
>> - ap_proxy_connection_create_ex()
>> - ap_proxy_http_request()
>> So we either need to remember the prefetch result for later retries or switch back to the old order.
>> Regards,
>> Rainer
>> Am 29.10.2019 um 12:46 schrieb Rainer Jung:
>>> This happens in the case of a small body. We read the body into req->input_brigade in ap_proxy_http_prefetch() before trying the first node, but then loose it on the second node, because we use another req and thus also another req->input_brigade then.
>>>
>>> Not sure, how we could best save the read input_brigade for the second attempt after failover. Will try some experiments.
>>>
>>> If you try to reproduce yourself, make sure you use a small POST (here: 30 bytes) and also exclude /favicon.ico from forwarding when using a browser. Otherwise some of the failovers will be triggered by favicon.ico and you'll not notice the problem in the POST request:
>>>
>>> ProxyPass /favicon.ico !
>>>
>>> Regards,
>>>
>>> Rainer
>>>
>>> Am 29.10.2019 um 11:15 schrieb Rainer Jung:
>>>> A first heads-up: it seems this commit broke failover for POST requests. Most (or all?) of the times a balancer failover happens for a POST request, the request send to the failover node has a Content-Length of "0" instead of the real content length.
>>>>
>>>> I use a trivial setup like this:
>>>>
>>>> <Proxy balancer://backends/>
>>>> ProxySet lbmethod=byrequests
>>>> BalancerMember http://localhost:5680
>>>> BalancerMember http://localhost:5681
>>>> </Proxy>
>>>>
>>>> ProxyPass / balancer://backends/
>>>>
>>>> where one backend node is up and the second node is down.
>>>>
>>>> I will investigate further.
>>>>
>>>> Regards,
>>>>
>>>> Rainer
>
> --
> kippdata
> informationstechnologie GmbH Tel: 0228 98549 -0
> Bornheimer Str. 33a Fax: 0228 98549 -50
> 53111 Bonn www.kippdata.de
>
> HRB 8018 Amtsgericht Bonn / USt.-IdNr. DE 196 457 417
> Geschäftsführer: Dr. Thomas Höfer, Rainer Jung, Sven Maurmann
Re: svn commit: r1860166 - in /httpd/httpd/branches/2.4.x: ./ docs/manual/mod/ include/ modules/http2/ modules/proxy/ server/ [ In reply to ]
Yikes! How can we test for that via the Perl test framework?

> On Oct 29, 2019, at 9:45 AM, Rainer Jung <rainer.jung@kippdata.de> wrote:
>
> Aha, and this is due to the fact, that r1656259 "mod_proxy_http: don't connect or reuse backend before prefetching request body." or parts of it was backported from trunk to 2.4 as part of r1860166.
>
> So I think (not yet verified), that the same problems applies to trunk since r1656259 in February 2015 :(
>
> Regards,
>
> Rainer
>
> Am 29.10.2019 um 14:21 schrieb Rainer Jung:
>> The reason why this fails now is that we prefetch in 2.4.41 the request body before doing the connection check to the backend. In 2.4.39 we did that after doing the check, so the body was still there when doing the final request sending.
>> 2.4.39:
>> In proxy_http_handler():
>> - ap_proxy_determine_connection()
>> - ap_proxy_check_connection()
>> - optionally ap_proxy_connect_backend() which might fail.
>> - ap_proxy_connection_create_ex()
>> - ap_proxy_http_request() which does prefetch late!
>> 2.4.41:
>> In proxy_http_handler():
>> - ap_proxy_determine_connection()
>> - early ap_proxy_http_prefetch() which does the prefetch!
>> - optionally again ap_proxy_determine_connection()
>> - ap_proxy_check_connection()
>> - optionally ap_proxy_connect_backend() which might fail.
>> - ap_proxy_connection_create_ex()
>> - ap_proxy_http_request()
>> So we either need to remember the prefetch result for later retries or switch back to the old order.
>> Regards,
>> Rainer
>> Am 29.10.2019 um 12:46 schrieb Rainer Jung:
>>> This happens in the case of a small body. We read the body into req->input_brigade in ap_proxy_http_prefetch() before trying the first node, but then loose it on the second node, because we use another req and thus also another req->input_brigade then.
>>>
>>> Not sure, how we could best save the read input_brigade for the second attempt after failover. Will try some experiments.
>>>
>>> If you try to reproduce yourself, make sure you use a small POST (here: 30 bytes) and also exclude /favicon.ico from forwarding when using a browser. Otherwise some of the failovers will be triggered by favicon.ico and you'll not notice the problem in the POST request:
>>>
>>> ProxyPass /favicon.ico !
>>>
>>> Regards,
>>>
>>> Rainer
>>>
>>> Am 29.10.2019 um 11:15 schrieb Rainer Jung:
>>>> A first heads-up: it seems this commit broke failover for POST requests. Most (or all?) of the times a balancer failover happens for a POST request, the request send to the failover node has a Content-Length of "0" instead of the real content length.
>>>>
>>>> I use a trivial setup like this:
>>>>
>>>> <Proxy balancer://backends/>
>>>> ProxySet lbmethod=byrequests
>>>> BalancerMember http://localhost:5680
>>>> BalancerMember http://localhost:5681
>>>> </Proxy>
>>>>
>>>> ProxyPass / balancer://backends/
>>>>
>>>> where one backend node is up and the second node is down.
>>>>
>>>> I will investigate further.
>>>>
>>>> Regards,
>>>>
>>>> Rainer
>
> --
> kippdata
> informationstechnologie GmbH Tel: 0228 98549 -0
> Bornheimer Str. 33a Fax: 0228 98549 -50
> 53111 Bonn www.kippdata.de
>
> HRB 8018 Amtsgericht Bonn / USt.-IdNr. DE 196 457 417
> Geschäftsführer: Dr. Thomas Höfer, Rainer Jung, Sven Maurmann
Re: svn commit: r1860166 - in /httpd/httpd/branches/2.4.x: ./ docs/manual/mod/ include/ modules/http2/ modules/proxy/ server/ [ In reply to ]
Hi Rainer,

thanks for looking at this.

>
> Aha, and this is due to the fact, that r1656259 "mod_proxy_http: don't
> connect or reuse backend before prefetching request body." or parts of
> it was backported from trunk to 2.4 as part of r1860166.

Yes, that's where prefetch was moved before connect, but we shouldn't
change that IMHO, besides fixing bugs...

Let me look at how we can reuse the input_brigade between balancers. I
have a small patch already and testing it.

>
> So I think (not yet verified), that the same problems applies to trunk
> since r1656259 in February 2015 :(

Yes, I'm fixing on trunk (first).


Regards,
Yann.
Re: svn commit: r1860166 - in /httpd/httpd/branches/2.4.x: ./ docs/manual/mod/ include/ modules/http2/ modules/proxy/ server/ [ In reply to ]
Am 29.10.2019 um 16:19 schrieb Yann Ylavic:
> Hi Rainer,
>
> thanks for looking at this.
>
>>
>> Aha, and this is due to the fact, that r1656259 "mod_proxy_http: don't
>> connect or reuse backend before prefetching request body." or parts of
>> it was backported from trunk to 2.4 as part of r1860166.
>
> Yes, that's where prefetch was moved before connect, but we shouldn't
> change that IMHO, besides fixing bugs...
>
> Let me look at how we can reuse the input_brigade between balancers. I
> have a small patch already and testing it.
>
>>
>> So I think (not yet verified), that the same problems applies to trunk
>> since r1656259 in February 2015 :(
>
> Yes, I'm fixing on trunk (first).

Thank you Yann. Let me know when I should test something. It's OK, if it
is not yet the final fix ;)

Regards,

Rainer
Re: svn commit: r1860166 - in /httpd/httpd/branches/2.4.x: ./ docs/manual/mod/ include/ modules/http2/ modules/proxy/ server/ [ In reply to ]
On Tue, Oct 29, 2019 at 4:24 PM Rainer Jung <rainer.jung@kippdata.de> wrote:
>
> Thank you Yann. Let me know when I should test something. It's OK, if it
> is not yet the final fix ;)

The attached patch seems to work for me..
Re: svn commit: r1860166 - in /httpd/httpd/branches/2.4.x: ./ docs/manual/mod/ include/ modules/http2/ modules/proxy/ server/ [ In reply to ]
Hi Yann,

Am 29.10.2019 um 16:58 schrieb Yann Ylavic:
> On Tue, Oct 29, 2019 at 4:24 PM Rainer Jung <rainer.jung@kippdata.de> wrote:
>>
>> Thank you Yann. Let me know when I should test something. It's OK, if it
>> is not yet the final fix ;)
>
> The attached patch seems to work for me..

LGTM. I applied/ported to 2.4.x, it fixes the problem for me as well and
looks local enough to not intruduce new problems.

Thanks!

Rainer
Re: svn commit: r1860166 - in /httpd/httpd/branches/2.4.x: ./ docs/manual/mod/ include/ modules/http2/ modules/proxy/ server/ [ In reply to ]
Double check: the condition in the do-while loop that was chaned to a
while loop has also changed:

FROM

do { ... }
while ((bytes_read < MAX_MEM_SPOOL - 80)
&& !APR_BUCKET_IS_EOS(APR_BRIGADE_LAST(input_brigade))
&& !req->prefetch_nonblocking);

TO

while (((bytes_read < MAX_MEM_SPOOL - 80)
&& (APR_BRIGADE_EMPTY(input_brigade)
|| !APR_BUCKET_IS_EOS(APR_BRIGADE_LAST(input_brigade))))
{ ... }

That's intended?

Regards,

Rainer

Am 29.10.2019 um 16:23 schrieb Rainer Jung:
> Am 29.10.2019 um 16:19 schrieb Yann Ylavic:
>> Hi Rainer,
>>
>> thanks for looking at this.
>>
>>>
>>> Aha, and this is due to the fact, that r1656259 "mod_proxy_http: don't
>>> connect or reuse backend before prefetching request body." or parts of
>>> it was backported from trunk to 2.4 as part of r1860166.
>>
>> Yes, that's where prefetch was moved before connect, but we shouldn't
>> change that IMHO, besides fixing bugs...
>>
>> Let me look at how we can reuse the input_brigade between balancers. I
>> have a small patch already and testing it.
>>
>>>
>>> So I think (not yet verified), that the same problems applies to trunk
>>> since r1656259 in February 2015 :(
>>
>> Yes, I'm fixing on trunk (first).
>
> Thank you Yann. Let me know when I should test something. It's OK, if it
> is not yet the final fix ;)
>
> Regards,
>
> Rainer
Re: svn commit: r1860166 - in /httpd/httpd/branches/2.4.x: ./ docs/manual/mod/ include/ modules/http2/ modules/proxy/ server/ [ In reply to ]
On Tue, Oct 29, 2019 at 8:01 PM Rainer Jung <rainer.jung@kippdata.de> wrote:
>
> Double check: the condition in the do-while loop that was chaned to a
> while loop has also changed:
>
> FROM
>
> do { ... }
> while ((bytes_read < MAX_MEM_SPOOL - 80)
> && !APR_BUCKET_IS_EOS(APR_BRIGADE_LAST(input_brigade))
> && !req->prefetch_nonblocking);
>
> TO
>
> while (((bytes_read < MAX_MEM_SPOOL - 80)
> && (APR_BRIGADE_EMPTY(input_brigade)
> || !APR_BUCKET_IS_EOS(APR_BRIGADE_LAST(input_brigade))))
> { ... }
>
> That's intended?

Yes, if req->prefetch_nonblocking we need to enter the loop at least
once, but since we are non-blocking it does not hurt to _try_ to read
more (even when we come back here in the balancer fallback case).

There is corner case though, if balancer members don't have the same
Proxy100Continue configuration we may enter ap_proxy_http_prefetch()
with different req->prefetch_nonblocking but mainly req->expecting_100
too. Since we can rely on the HTTP_IN filter to do 100 continue above
the first call, in case where the first balancer member reached is
"Proxy100Continue on" but the fallback is "off" then could deadlock
(similarly to r1868576).
Possibly it's too much of a corner case, but it looks easy enough to
address in this patch (by ignoring "Proxy100Continue off" on the
fallback), so maybe this v2 (attached) instead?


Regards,
Yann.
Re: svn commit: r1860166 - in /httpd/httpd/branches/2.4.x: ./ docs/manual/mod/ include/ modules/http2/ modules/proxy/ server/ [ In reply to ]
On 2019-10-30 07:07, Yann Ylavic wrote:
> On Tue, Oct 29, 2019 at 8:01 PM Rainer Jung <rainer.jung@kippdata.de> wrote:
...
>> That's intended?
>
> Yes, if req->prefetch_nonblocking we need to enter the loop at least
> once, but since we are non-blocking it does not hurt to _try_ to read
> more (even when we come back here in the balancer fallback case).
>
> There is corner case though....

Some of love to chase into dark corners and this looks like one of them.


--
Dennis Clarke
RISC-V/SPARC/PPC/ARM/CISC
UNIX and Linux spoken
GreyBeard and suspenders optional