Mailing List Archive

httpd 2.4 and maintainer-mode
Anyone else trying to build HEAD of httpd-2.4 with --enable-maintainer-mode?
Re: httpd 2.4 and maintainer-mode [ In reply to ]
Hi Jim,

I always compile (and test) with --enable-maintainer-mode.

I've just updated my 2.4 branch / make clean / make, and there is
nothing special.

Any specific issue?

CJ


Le 09/10/2019 à 15:33, Jim Jagielski a écrit :
> Anyone else trying to build HEAD of httpd-2.4 with --enable-maintainer-mode?
>
Re: httpd 2.4 and maintainer-mode [ In reply to ]
Just the issues w/ libxml comments:

In file included from mod_xml2enc.c:38:
In file included from /usr/local/include/libxml2/libxml/encoding.h:31:
/usr/local/include/unicode/ucnv.h:1:1: error: // comments are not allowed in this language [-Werror,-Wcomment]
// Copyright (C) 2016 and later: Unicode, Inc. and others.
^
In file included from mod_xml2enc.c:38:
In file included from /usr/local/include/libxml2/libxml/encoding.h:31:
In file included from /usr/local/include/unicode/ucnv.h:52:
/usr/local/include/libxml2/unicode/ucnv_err.h:1:1: error: // comments are not allowed in this language [-Werror,-Wcomment]
// Copyright (C) 2016 and later: Unicode, Inc. and others.
^
In file included from mod_xml2enc.c:38:
In file included from /usr/local/include/libxml2/libxml/encoding.h:31:
In file included from /usr/local/include/unicode/ucnv.h:52:
In file included from /usr/local/include/libxml2/unicode/ucnv_err.h:88:
/usr/local/include/libxml2/unicode/utypes.h:1:1: error: // comments are not allowed in this language [-Werror,-Wcomment]
// Copyright (C) 2016 and later: Unicode, Inc. and others.
^
In file included from mod_xml2enc.c:38:
In file included from /usr/local/include/libxml2/libxml/encoding.h:31:
In file included from /usr/local/include/unicode/ucnv.h:52:
In file included from /usr/local/include/libxml2/unicode/ucnv_err.h:88:
In file included from /usr/local/include/libxml2/unicode/utypes.h:38:
/usr/local/include/libxml2/unicode/umachine.h:1:1: error: // comments are not allowed in this language [-Werror,-Wcomment]
// Copyright (C) 2016 and later: Unicode, Inc. and others.
^
In file included from mod_xml2enc.c:38:
In file included from /usr/local/include/libxml2/libxml/encoding.h:31:
In file included from /usr/local/include/unicode/ucnv.h:52:
In file included from /usr/local/include/libxml2/unicode/ucnv_err.h:88:
In file included from /usr/local/include/libxml2/unicode/utypes.h:38:
In file included from /usr/local/include/libxml2/unicode/umachine.h:46:
/usr/local/include/libxml2/unicode/ptypes.h:1:1: error: // comments are not allowed in this language [-Werror,-Wcomment]
// Copyright (C) 2016 and later: Unicode, Inc. and others.
^
In file included from mod_xml2enc.c:38:
In file included from /usr/local/include/libxml2/libxml/encoding.h:31:
In file included from /usr/local/include/unicode/ucnv.h:52:
In file included from /usr/local/include/libxml2/unicode/ucnv_err.h:88:
In file included from /usr/local/include/libxml2/unicode/utypes.h:38:
In file included from /usr/local/include/libxml2/unicode/umachine.h:46:
In file included from /usr/local/include/libxml2/unicode/ptypes.h:52:
/usr/local/include/libxml2/unicode/platform.h:1:1: error: // comments are not allowed in this language [-Werror,-Wcomment]
// Copyright (C) 2016 and later: Unicode, Inc. and others.
^
In file included from mod_xml2enc.c:38:
In file included from /usr/local/include/libxml2/libxml/encoding.h:31:
In file included from /usr/local/include/unicode/ucnv.h:52:
In file included from /usr/local/include/libxml2/unicode/ucnv_err.h:88:
In file included from /usr/local/include/libxml2/unicode/utypes.h:38:
In file included from /usr/local/include/libxml2/unicode/umachine.h:46:
In file included from /usr/local/include/libxml2/unicode/ptypes.h:52:
In file included from /usr/local/include/libxml2/unicode/platform.h:24:
/usr/local/include/libxml2/unicode/uconfig.h:1:1: error: // comments are not allowed in this language [-Werror,-Wcomment]
// Copyright (C) 2016 and later: Unicode, Inc. and others.
^
In file included from mod_xml2enc.c:38:
In file included from /usr/local/include/libxml2/libxml/encoding.h:31:
In file included from /usr/local/include/unicode/ucnv.h:52:
In file included from /usr/local/include/libxml2/unicode/ucnv_err.h:88:
In file included from /usr/local/include/libxml2/unicode/utypes.h:38:
In file included from /usr/local/include/libxml2/unicode/umachine.h:46:
In file included from /usr/local/include/libxml2/unicode/ptypes.h:52:
In file included from /usr/local/include/libxml2/unicode/platform.h:25:
/usr/local/include/libxml2/unicode/uvernum.h:1:1: error: // comments are not allowed in this language [-Werror,-Wcomment]
// Copyright (C) 2016 and later: Unicode, Inc. and others.
^
In file included from mod_xml2enc.c:38:
In file included from /usr/local/include/libxml2/libxml/encoding.h:31:
In file included from /usr/local/include/unicode/ucnv.h:52:
In file included from /usr/local/include/libxml2/unicode/ucnv_err.h:88:
In file included from /usr/local/include/libxml2/unicode/utypes.h:38:
In file included from /usr/local/include/libxml2/unicode/umachine.h:379:
/usr/local/include/libxml2/unicode/urename.h:1:1: error: // comments are not allowed in this language [-Werror,-Wcomment]
// Copyright (C) 2016 and later: Unicode, Inc. and others.
^
In file included from mod_proxy_html.c:44:
In file included from /usr/local/include/libxml2/libxml/HTMLparser.h:16:
In file included from /usr/local/include/libxml2/libxml/parser.h:810:
In file included from /usr/local/include/libxml2/libxml/encoding.h:31:
/usr/local/include/unicode/ucnv.h:1:1: error: // comments are not allowed in this language [-Werror,-Wcomment]
// Copyright (C) 2016 and later: Unicode, Inc. and others.
^
In file included from mod_proxy_html.c:44:
In file included from /usr/local/include/libxml2/libxml/HTMLparser.h:16:
In file included from /usr/local/include/libxml2/libxml/parser.h:810:
In file included from /usr/local/include/libxml2/libxml/encoding.h:31:
In file included from /usr/local/include/unicode/ucnv.h:52:
/usr/local/include/libxml2/unicode/ucnv_err.h:1:1: error: // comments are not allowed in this language [-Werror,-Wcomment]
// Copyright (C) 2016 and later: Unicode, Inc. and others.
^
In file included from mod_proxy_html.c:44:
In file included from /usr/local/include/libxml2/libxml/HTMLparser.h:16:
In file included from /usr/local/include/libxml2/libxml/parser.h:810:
In file included from /usr/local/include/libxml2/libxml/encoding.h:31:
In file included from /usr/local/include/unicode/ucnv.h:52:
In file included from /usr/local/include/libxml2/unicode/ucnv_err.h:88:
/usr/local/include/libxml2/unicode/utypes.h:1:1: error: // comments are not allowed in this language [-Werror,-Wcomment]
// Copyright (C) 2016 and later: Unicode, Inc. and others.
^
In file included from mod_proxy_html.c:44:
In file included from /usr/local/include/libxml2/libxml/HTMLparser.h:16:
In file included from /usr/local/include/libxml2/libxml/parser.h:810:
In file included from /usr/local/include/libxml2/libxml/encoding.h:31:
In file included from /usr/local/include/unicode/ucnv.h:52:
In file included from /usr/local/include/libxml2/unicode/ucnv_err.h:88:
In file included from /usr/local/include/libxml2/unicode/utypes.h:38:
/usr/local/include/libxml2/unicode/umachine.h:1:1: error: // comments are not allowed in this language [-Werror,-Wcomment]
// Copyright (C) 2016 and later: Unicode, Inc. and others.
^
In file included from mod_proxy_html.c:44:
In file included from /usr/local/include/libxml2/libxml/HTMLparser.h:16:
In file included from /usr/local/include/libxml2/libxml/parser.h:810:
In file included from /usr/local/include/libxml2/libxml/encoding.h:31:
In file included from /usr/local/include/unicode/ucnv.h:52:
In file included from /usr/local/include/libxml2/unicode/ucnv_err.h:88:
In file included from /usr/local/include/libxml2/unicode/utypes.h:38:
In file included from /usr/local/include/libxml2/unicode/umachine.h:46:
/usr/local/include/libxml2/unicode/ptypes.h:1:1: error: // comments are not allowed in this language [-Werror,-Wcomment]
// Copyright (C) 2016 and later: Unicode, Inc. and others.
^
In file included from mod_proxy_html.c:44:
In file included from /usr/local/include/libxml2/libxml/HTMLparser.h:16:
In file included from /usr/local/include/libxml2/libxml/parser.h:810:
In file included from /usr/local/include/libxml2/libxml/encoding.h:31:
In file included from /usr/local/include/unicode/ucnv.h:52:
In file included from /usr/local/include/libxml2/unicode/ucnv_err.h:88:
In file included from /usr/local/include/libxml2/unicode/utypes.h:38:
In file included from /usr/local/include/libxml2/unicode/umachine.h:46:
In file included from /usr/local/include/libxml2/unicode/ptypes.h:52:
/usr/local/include/libxml2/unicode/platform.h:1:1: error: // comments are not allowed in this language [-Werror,-Wcomment]
// Copyright (C) 2016 and later: Unicode, Inc. and others.
^
In file included from mod_proxy_html.c:44:
In file included from /usr/local/include/libxml2/libxml/HTMLparser.h:16:
In file included from /usr/local/include/libxml2/libxml/parser.h:810:
In file included from /usr/local/include/libxml2/libxml/encoding.h:31:
In file included from /usr/local/include/unicode/ucnv.h:52:
In file included from /usr/local/include/libxml2/unicode/ucnv_err.h:88:
In file included from /usr/local/include/libxml2/unicode/utypes.h:38:
In file included from /usr/local/include/libxml2/unicode/umachine.h:46:
In file included from /usr/local/include/libxml2/unicode/ptypes.h:52:
In file included from /usr/local/include/libxml2/unicode/platform.h:24:
/usr/local/include/libxml2/unicode/uconfig.h:1:1: error: // comments are not allowed in this language [-Werror,-Wcomment]
// Copyright (C) 2016 and later: Unicode, Inc. and others.
^


> On Oct 9, 2019, at 1:04 PM, Marion & Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote:
>
> Hi Jim,
>
> I always compile (and test) with --enable-maintainer-mode.
>
> I've just updated my 2.4 branch / make clean / make, and there is nothing special.
>
> Any specific issue?
>
> CJ
>
>
> Le 09/10/2019 à 15:33, Jim Jagielski a écrit :
>> Anyone else trying to build HEAD of httpd-2.4 with --enable-maintainer-mode?
>>
Re: httpd 2.4 and maintainer-mode [ In reply to ]
Compiling trunk and 2.4.x under MacOS Vista, no issues. Some homebrew install?

> Am 09.10.2019 um 19:04 schrieb Marion & Christophe JAILLET <christophe.jaillet@wanadoo.fr>:
>
> Hi Jim,
>
> I always compile (and test) with --enable-maintainer-mode.
>
> I've just updated my 2.4 branch / make clean / make, and there is nothing special.
>
> Any specific issue?
>
> CJ
>
>
> Le 09/10/2019 à 15:33, Jim Jagielski a écrit :
>> Anyone else trying to build HEAD of httpd-2.4 with --enable-maintainer-mode?
>>
Re: httpd 2.4 and maintainer-mode [ In reply to ]
I am using MacPorts libxml2. But the issue seems to be w/ libxml2 itself; it is the package that uses the '//' comment style. Where does your build grab its xml2 stuff from?

> On Oct 10, 2019, at 3:58 AM, Stefan Eissing <stefan.eissing@greenbytes.de> wrote:
>
> Compiling trunk and 2.4.x under MacOS Vista, no issues. Some homebrew install?
>
>> Am 09.10.2019 um 19:04 schrieb Marion & Christophe JAILLET <christophe.jaillet@wanadoo.fr>:
>>
>> Hi Jim,
>>
>> I always compile (and test) with --enable-maintainer-mode.
>>
>> I've just updated my 2.4 branch / make clean / make, and there is nothing special.
>>
>> Any specific issue?
>>
>> CJ
>>
>>
>> Le 09/10/2019 à 15:33, Jim Jagielski a écrit :
>>> Anyone else trying to build HEAD of httpd-2.4 with --enable-maintainer-mode?
>>>
>
Re: httpd 2.4 and maintainer-mode [ In reply to ]
When will I learn to read mails completely?

- Ok, proxy-html is not build by default, which explains the happiness due to ignorance.
- Once enabled, it does not find libxml2 (I think MacOS Vista removed it)
- brew reinstall libxml2
- configure .... --with-libxml2=/usr/local/opt/libxml2

and it builds on my machine.

- Stefan

> Am 10.10.2019 um 14:10 schrieb Jim Jagielski <jim@jaguNET.com>:
>
> I am using MacPorts libxml2. But the issue seems to be w/ libxml2 itself; it is the package that uses the '//' comment style. Where does your build grab its xml2 stuff from?
>
>> On Oct 10, 2019, at 3:58 AM, Stefan Eissing <stefan.eissing@greenbytes.de> wrote:
>>
>> Compiling trunk and 2.4.x under MacOS Vista, no issues. Some homebrew install?
>>
>>> Am 09.10.2019 um 19:04 schrieb Marion & Christophe JAILLET <christophe.jaillet@wanadoo.fr>:
>>>
>>> Hi Jim,
>>>
>>> I always compile (and test) with --enable-maintainer-mode.
>>>
>>> I've just updated my 2.4 branch / make clean / make, and there is nothing special.
>>>
>>> Any specific issue?
>>>
>>> CJ
>>>
>>>
>>> Le 09/10/2019 à 15:33, Jim Jagielski a écrit :
>>>> Anyone else trying to build HEAD of httpd-2.4 with --enable-maintainer-mode?
>>>>
>>
>
Re: httpd 2.4 and maintainer-mode [ In reply to ]
On Wed, Oct 9, 2019 at 3:42 PM Jim Jagielski <jim@jagunet.com> wrote:

> Just the issues w/ libxml comments:
>
> In file included from mod_xml2enc.c:38:
> In file included from /usr/local/include/libxml2/libxml/encoding.h:31:
> /usr/local/include/unicode/ucnv.h:1:1: error: // comments are not allowed
> in this language [-Werror,-Wcomment]
> // Copyright (C) 2016 and later: Unicode, Inc. and others.
>

Jim, are you missing
http://svn.apache.org/viewvc?view=revision&revision=1867183
which you had already fixed the quirk on trunk/? Seems that clang is being
a bit opaque
about it's identity and confounding the pragmas wrapping our libxml2.h
includes.
Re: httpd 2.4 and maintainer-mode [ In reply to ]
And this is with maintainer-mode? I'm wondering why your setup is either OK w/ the C++ style comments or maybe Homebrew changes the comment style??

> On Oct 10, 2019, at 8:33 AM, Stefan Eissing <stefan.eissing@greenbytes.de> wrote:
>
> When will I learn to read mails completely?
>
> - Ok, proxy-html is not build by default, which explains the happiness due to ignorance.
> - Once enabled, it does not find libxml2 (I think MacOS Vista removed it)
> - brew reinstall libxml2
> - configure .... --with-libxml2=/usr/local/opt/libxml2
>
> and it builds on my machine.
>
> - Stefan
>
>> Am 10.10.2019 um 14:10 schrieb Jim Jagielski <jim@jaguNET.com>:
>>
>> I am using MacPorts libxml2. But the issue seems to be w/ libxml2 itself; it is the package that uses the '//' comment style. Where does your build grab its xml2 stuff from?
>>
>>> On Oct 10, 2019, at 3:58 AM, Stefan Eissing <stefan.eissing@greenbytes.de> wrote:
>>>
>>> Compiling trunk and 2.4.x under MacOS Vista, no issues. Some homebrew install?
>>>
>>>> Am 09.10.2019 um 19:04 schrieb Marion & Christophe JAILLET <christophe.jaillet@wanadoo.fr>:
>>>>
>>>> Hi Jim,
>>>>
>>>> I always compile (and test) with --enable-maintainer-mode.
>>>>
>>>> I've just updated my 2.4 branch / make clean / make, and there is nothing special.
>>>>
>>>> Any specific issue?
>>>>
>>>> CJ
>>>>
>>>>
>>>> Le 09/10/2019 à 15:33, Jim Jagielski a écrit :
>>>>> Anyone else trying to build HEAD of httpd-2.4 with --enable-maintainer-mode?
>>>>>
>>>
>>
>
Re: httpd 2.4 and maintainer-mode [ In reply to ]
as mentioned, this is httpd-2.4... I was curious why I seem to be the only one whom this hits.

> On Oct 10, 2019, at 9:43 AM, William A Rowe Jr <wrowe@rowe-clan.net> wrote:
>
> On Wed, Oct 9, 2019 at 3:42 PM Jim Jagielski <jim@jagunet.com <mailto:jim@jagunet.com>> wrote:
> Just the issues w/ libxml comments:
>
> In file included from mod_xml2enc.c:38:
> In file included from /usr/local/include/libxml2/libxml/encoding.h:31:
> /usr/local/include/unicode/ucnv.h:1:1: error: // comments are not allowed in this language [-Werror,-Wcomment]
> // Copyright (C) 2016 and later: Unicode, Inc. and others.
>
> Jim, are you missing http://svn.apache.org/viewvc?view=revision&revision=1867183 <http://svn.apache.org/viewvc?view=revision&revision=1867183>
> which you had already fixed the quirk on trunk/? Seems that clang is being a bit opaque
> about it's identity and confounding the pragmas wrapping our libxml2.h includes.
>
Re: httpd 2.4 and maintainer-mode [ In reply to ]
Hi,

not a libxml guru at all, but looking at
/usr/local/include/libxml2/libxml/encoding.h:31 (taken from your
compilation warnings)

    #ifdef LIBXML_ICONV_ENABLED
    #include <iconv.h>
    #endif
    #ifdef LIBXML_ICU_ENABLED
    #include <unicode/ucnv.h>
    #endif

and on my system:

    cd usr/include/

    find . -name iconv.h
    ./iconv.h

    find . -name ucnv.h
    ./unicode/ucnv.h

So, both are there.
And 'unicode/ucnv.h' has some // at its very beginning.


In order to confirm, I've manually modified <unicode/ucnv.h> to generate
some error. It IS parsed in my build.
However, when unmodified, no error or warning is generated.

If I remove the workaround at the beginning of mod_xml2enc.c, it also
compiles without any issue at all.


Looking at this workaround, I don't think it is correct.
According to latest gcc doc, Wcomment is described as:

    Warn whenever a comment-start sequence ‘/*’ appears in a ‘/*’
comment, or whenever a backslash-newline appears in a ‘//’ comment. This
warning is enabled by -Wall.

Apparently nothing to do with accepting or not // (in c89 in our case)


Adding a // within the "protected" block in mod_xml2enc.c leads to:
mod_xml2enc.c:36:1: error: C++ style comments are not allowed in ISO C90
 //

This confirms that the workaround does not what is expected.


I guess that my version of GCC (i.e. 8.3.0) tolerates some c89 deviation
in .h files included from "outside".


CJ


Le 10/10/2019 à 18:05, Jim Jagielski a écrit :
> And this is with maintainer-mode? I'm wondering why your setup is either OK w/ the C++ style comments or maybe Homebrew changes the comment style??
>
>> On Oct 10, 2019, at 8:33 AM, Stefan Eissing <stefan.eissing@greenbytes.de> wrote:
>>
>> When will I learn to read mails completely?
>>
>> - Ok, proxy-html is not build by default, which explains the happiness due to ignorance.
>> - Once enabled, it does not find libxml2 (I think MacOS Vista removed it)
>> - brew reinstall libxml2
>> - configure .... --with-libxml2=/usr/local/opt/libxml2
>>
>> and it builds on my machine.
>>
>> - Stefan
>>
>>> Am 10.10.2019 um 14:10 schrieb Jim Jagielski <jim@jaguNET.com>:
>>>
>>> I am using MacPorts libxml2. But the issue seems to be w/ libxml2 itself; it is the package that uses the '//' comment style. Where does your build grab its xml2 stuff from?
>>>
>>>> On Oct 10, 2019, at 3:58 AM, Stefan Eissing <stefan.eissing@greenbytes.de> wrote:
>>>>
>>>> Compiling trunk and 2.4.x under MacOS Vista, no issues. Some homebrew install?
>>>>
>>>>> Am 09.10.2019 um 19:04 schrieb Marion & Christophe JAILLET <christophe.jaillet@wanadoo.fr>:
>>>>>
>>>>> Hi Jim,
>>>>>
>>>>> I always compile (and test) with --enable-maintainer-mode.
>>>>>
>>>>> I've just updated my 2.4 branch / make clean / make, and there is nothing special.
>>>>>
>>>>> Any specific issue?
>>>>>
>>>>> CJ
>>>>>
>>>>>
>>>>> Le 09/10/2019 à 15:33, Jim Jagielski a écrit :
>>>>>> Anyone else trying to build HEAD of httpd-2.4 with --enable-maintainer-mode?
>>>>>>
>
Re: httpd 2.4 and maintainer-mode [ In reply to ]
> On Oct 10, 2019, at 2:49 PM, Marion & Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote:
>
> I guess that my version of GCC (i.e. 8.3.0) tolerates some c89 deviation in .h files included from "outside".
>

So you aren't using Xcode and clang?
Re: httpd 2.4 and maintainer-mode [ In reply to ]
Le 14/10/2019 à 17:15, Jim Jagielski a écrit :
>
>> On Oct 10, 2019, at 2:49 PM, Marion & Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote:
>>
>> I guess that my version of GCC (i.e. 8.3.0) tolerates some c89 deviation in .h files included from "outside".
> So you aren't using Xcode and clang?


No, just some comand line tools, some scripts, gcc and Geany as an IDE.

CJ
Re: httpd 2.4 and maintainer-mode [ In reply to ]
Yeah, this seems clang specific...

> On Oct 14, 2019, at 2:48 PM, Marion & Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote:
>
>
> Le 14/10/2019 à 17:15, Jim Jagielski a écrit :
>>
>>> On Oct 10, 2019, at 2:49 PM, Marion & Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote:
>>>
>>> I guess that my version of GCC (i.e. 8.3.0) tolerates some c89 deviation in .h files included from "outside".
>> So you aren't using Xcode and clang?
>
>
> No, just some comand line tools, some scripts, gcc and Geany as an IDE.
>
> CJ
>